[jira] [Commented] (AIRFLOW-3937) KubernetesPodOperator support for envFrom configMapRef and secretRef

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16776817#comment-16776817 ] 

ASF GitHub Bot commented on AIRFLOW-3937:
-----------------------------------------

galuszkak commented on pull request #4772: [AIRFLOW-3937] KubernetesPodOperator support for envFrom configMapRef…
URL: https://github.com/apache/airflow/pull/4772
 
 
   … and secretRef
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [X] My PR addresses the following [AIRFLOW-3937](https://issues.apache.org/jira/browse/AIRFLOW-3937/) issues and references them in the PR title. 
     - https://issues.apache.org/jira/browse/AIRFLOW-3937/
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-3937\], code changes always need a Jira issue.
   
   ### Description
   
   - [X] Here are some details about my PR, including screenshots of any UI changes:
   
   ### Tests
   
   - [X] My PR adds the following unit tests:
   * test_envs_from_secrets
   * test_envs_from_configmaps
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
   
   ### Code Quality
   
   - [ ] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> KubernetesPodOperator support for envFrom configMapRef and secretRef
> --------------------------------------------------------------------
>
>                 Key: AIRFLOW-3937
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3937
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: kubernetes, operators
>    Affects Versions: 1.10.2
>            Reporter: Kamil Gałuszka
>            Assignee: Kamil Gałuszka
>            Priority: Minor
>
> KubernetesPodOperator has basic support for Secret and Configmap, mostly by mounting them in files or mounting specific keys in environment variables.
> As for now there is lack of support of just mounting environment variables directly through whole k8s Configmap or Secret. Like this:
> {code:java}
> containers:
> -
>   name: worker-celery
>   image: us.gcr.io/organisation/image-name
>   imagePullPolicy: Always
>   envFrom:
>     - configMapRef:
>       name: my-configmap-name
>     - secretRef:
>       name: my-secret-name
> {code}
> There is very convienient pattern to have secrets and configmaps per image that is just attached by k8s to Pod, that should be very useful in Apache Airflow.
> As for now I'm aware that there is also in progress AIRFLOW-3381 but it solves different problem (still mounting specific keys, rather than whole Secret/Configmap), which if Secret/Configmap object has a lot of variables it become very inconvenient to add new variable every time it is added to Secret/Configmap object.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)