You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/04/24 08:42:08 UTC

[GitHub] [druid] kanibs opened a new pull request #9764: Enabling Static Imports for Unit Testing DSLs (#331)

kanibs opened a new pull request #9764:
URL: https://github.com/apache/druid/pull/9764


   Co-authored-by: mohammadshoaib <mo...@miqdigital.com>
   
   <!-- Thanks for trying to help us make Apache Druid be the best it can be! Please fill out as much of the following information as is possible (where relevant, and remove it when irrelevant) to help make the intention and scope of this PR clear in order to ease review. -->
   
   Fixes #8885 .
   
   <!-- Replace XXXX with the id of the issue fixed in this PR. Remove this section if there is no corresponding issue. Don't reference the issue in the title of this pull-request. -->
   
   <!-- If you are a committer, follow the PR action item checklist for committers:
   https://github.com/apache/druid/blob/master/dev/committer-instructions.md#pr-and-issue-action-item-checklist-for-committers. -->
   
   ### Description
   
   <!-- Describe the goal of this PR, what problem are you fixing. If there is a corresponding issue (referenced above), it's not necessary to repeat the description here, however, you may choose to keep one summary sentence. -->
   Enabled the Static Imports for some of the Unit testing DSL classes
   
   <!-- Describe your patch: what did you change in code? How did you fix the problem? -->
   Modified checkstyle.xml file's `AvoidStaticImport` module to allow static imports from a few unit-testing-utility Classes 
   <!-- If there are several relatively logically separate changes in this PR, create a mini-section for each of them. For example: -->
   
   #### Fixed the bug : NA
   #### Renamed the class : NO
   #### Added a forbidden-apis entry : NO
   
   ##### Key changed/added classes in this PR
    * `checkstyle.xml`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] stale[bot] commented on pull request #9764: Enabling Static Imports for Unit Testing DSLs (#331)

Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #9764:
URL: https://github.com/apache/druid/pull/9764#issuecomment-650273490


   This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@druid.apache.org list. Thank you for your contributions.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] stale[bot] commented on pull request #9764: Enabling Static Imports for Unit Testing DSLs (#331)

Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #9764:
URL: https://github.com/apache/druid/pull/9764#issuecomment-651556520


   This pull request/issue is no longer marked as stale.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] suneet-s merged pull request #9764: Enabling Static Imports for Unit Testing DSLs (#331)

Posted by GitBox <gi...@apache.org>.
suneet-s merged pull request #9764:
URL: https://github.com/apache/druid/pull/9764


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] kanibs commented on pull request #9764: Enabling Static Imports for Unit Testing DSLs (#331)

Posted by GitBox <gi...@apache.org>.
kanibs commented on pull request #9764:
URL: https://github.com/apache/druid/pull/9764#issuecomment-651582330


   Hey @suneet-s, Thanks for the suggestions. I have updated the pull request accordingly. Also, as per your suggestion, I have used static import of `assert` and `org.apache.druid.common.config.NullHandling.replaceWithDefault` in a test class called `NullHandlingTest`, to verify that the change is working as expected.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org