You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by jw...@apache.org on 2011/02/19 01:32:43 UTC
svn commit: r1072213 -
/myfaces/trinidad/trunk/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/style/util/CSSGenerationUtils.java
Author: jwaldman
Date: Sat Feb 19 00:32:42 2011
New Revision: 1072213
URL: http://svn.apache.org/viewvc?rev=1072213&view=rev
Log:
TRINIDAD-2041 the design time tool needs browser supported pseudo-classes to be converted like non-browser-supported pseudo-classes
one line fix in CSSGenerationUtils
Modified:
myfaces/trinidad/trunk/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/style/util/CSSGenerationUtils.java
Modified: myfaces/trinidad/trunk/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/style/util/CSSGenerationUtils.java
URL: http://svn.apache.org/viewvc/myfaces/trinidad/trunk/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/style/util/CSSGenerationUtils.java?rev=1072213&r1=1072212&r2=1072213&view=diff
==============================================================================
--- myfaces/trinidad/trunk/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/style/util/CSSGenerationUtils.java (original)
+++ myfaces/trinidad/trunk/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/style/util/CSSGenerationUtils.java Sat Feb 19 00:32:42 2011
@@ -18,6 +18,8 @@
*/
package org.apache.myfaces.trinidadinternal.style.util;
+import java.beans.Beans;
+
import java.io.PrintWriter;
import java.util.ArrayList;
@@ -1388,7 +1390,9 @@ public class CSSGenerationUtils
static private String _convertPseudoClass(String pseudoClass)
{
- if (_BUILT_IN_PSEUDO_CLASSES.contains(pseudoClass))
+ // The design time needs the browser-supported pseudo-classes to be converted so they
+ // can show a preview of the skinned component.
+ if (_BUILT_IN_PSEUDO_CLASSES.contains(pseudoClass) && !Beans.isDesignTime())
return pseudoClass;
StringBuilder builder = new StringBuilder(pseudoClass.length() + 3);
builder.append(".");
@@ -1406,8 +1410,7 @@ public class CSSGenerationUtils
return builder.toString();
}
-
- // =-=AEW Do we care about built-in pseudo-elements???
+ // We want to output to the css the browser-supported pseudo-classes as is
static private final Set<String> _BUILT_IN_PSEUDO_CLASSES =
new HashSet<String>();
static
@@ -1420,7 +1423,6 @@ public class CSSGenerationUtils
_BUILT_IN_PSEUDO_CLASSES.add(":focus");
}
- private static final Pattern _SPACE_PATTERN = Pattern.compile("\\s");
private static final Pattern _DASH_PATTERN = Pattern.compile("-");
private static final String[] _EMPTY_STRING_ARRAY = new String[0];
private static final int _MSIE_SELECTOR_LIMIT = 4095;