You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "airborne12 (via GitHub)" <gi...@apache.org> on 2023/06/19 05:37:12 UTC
[GitHub] [doris] airborne12 opened a new pull request, #20970: [Fix](inverted index) remove IndexReader::indexExists, use fs interface
airborne12 opened a new pull request, #20970:
URL: https://github.com/apache/doris/pull/20970
## Proposed changes
Issue Number: close #xxx
IndexReader::indexExists in CLucene will use system fs interface to find out whether a directory is exists, which is dangerous when writing files into S3, use fs->exists instead.
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] airborne12 commented on pull request #20970: [Fix](inverted index) remove IndexReader::indexExists, use fs interface
Posted by "airborne12 (via GitHub)" <gi...@apache.org>.
airborne12 commented on PR #20970:
URL: https://github.com/apache/doris/pull/20970#issuecomment-1596535156
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20970: [Fix](inverted index) remove IndexReader::indexExists, use fs interface
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20970:
URL: https://github.com/apache/doris/pull/20970#issuecomment-1598083977
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20970: [Fix](inverted index) remove IndexReader::indexExists, use fs interface
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20970:
URL: https://github.com/apache/doris/pull/20970#issuecomment-1598084009
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zzzxl1993 commented on pull request #20970: [Fix](inverted index) remove IndexReader::indexExists, use fs interface
Posted by "zzzxl1993 (via GitHub)" <gi...@apache.org>.
zzzxl1993 commented on PR #20970:
URL: https://github.com/apache/doris/pull/20970#issuecomment-1596559065
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xiaokang merged pull request #20970: [Fix](inverted index) remove IndexReader::indexExists, use fs interface
Posted by "xiaokang (via GitHub)" <gi...@apache.org>.
xiaokang merged PR #20970:
URL: https://github.com/apache/doris/pull/20970
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20970: [Fix](inverted index) remove IndexReader::indexExists, use fs interface
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20970:
URL: https://github.com/apache/doris/pull/20970#issuecomment-1596538724
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xiaokang commented on a diff in pull request #20970: [Fix](inverted index) remove IndexReader::indexExists, use fs interface
Posted by "xiaokang (via GitHub)" <gi...@apache.org>.
xiaokang commented on code in PR #20970:
URL: https://github.com/apache/doris/pull/20970#discussion_r1233581289
##########
be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:
##########
@@ -133,12 +133,18 @@ class InvertedIndexColumnWriterImpl : public InvertedIndexColumnWriter {
_directory + "/" + _segment_file_name, _index_meta->index_id());
// LOG(INFO) << "inverted index path: " << index_path;
-
- if (lucene::index::IndexReader::indexExists(index_path.c_str())) {
- create = false;
- if (lucene::index::IndexReader::isLocked(index_path.c_str())) {
- LOG(WARNING) << ("Lucene Index was locked... unlocking it.\n");
- lucene::index::IndexReader::unlock(index_path.c_str());
+ bool exists = false;
+ auto st = _fs->exists(index_path.c_str(), &exists);
+ if (!st.ok()) {
+ LOG(ERROR) << "index_path:"
+ << " exists error:" << st;
+ return st;
+ }
+ if (exists) {
+ st = _fs->delete_directory(index_path.c_str());
Review Comment:
can just return error Status
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20970: [Fix](inverted index) remove IndexReader::indexExists, use fs interface
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20970:
URL: https://github.com/apache/doris/pull/20970#issuecomment-1598034274
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] airborne12 commented on pull request #20970: [Fix](inverted index) remove IndexReader::indexExists, use fs interface
Posted by "airborne12 (via GitHub)" <gi...@apache.org>.
airborne12 commented on PR #20970:
URL: https://github.com/apache/doris/pull/20970#issuecomment-1598030920
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org