You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/05/06 06:27:27 UTC

[GitHub] [pulsar] eolivelli commented on pull request #10484: Support Pulsar Auth token for Debezium and Kafka connect adaptor

eolivelli commented on pull request #10484:
URL: https://github.com/apache/pulsar/pull/10484#issuecomment-833262428


   @sijie @rdhabalia @freeznet 
   I agree with the comments in #8668 and we probably should provide PulsarClient together with PulsarAdmin.
   
   This patch was a quick and dirty fix that we had in some local fork in order to unblock usage of these connectors in environments where you use Token Auth.
   
   I wanted to shared this patch more to start a discussion and to see the feedback from the community.
   
   if we want to go down the way of providing PulsarClient I am to work on that solution.
   
   IIRC there were some discussions about Classpath pollution introduced by adding support for PulsarAdmin,
   personally I believe that it is better to add PulsarClient and PulsarAdmin to the Context, so I am happy to go that way. It will make life easier for implementors of Pulsar IO adapters.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org