[GitHub] [iceberg] jackye1995 commented on a diff in pull request #4428: Core, API: Support table scan from a ref

[GitBox <gi...@apache.org>]

jackye1995 commented on code in PR #4428:
URL: https://github.com/apache/iceberg/pull/4428#discussion_r881252364


##########
api/src/main/java/org/apache/iceberg/TableScan.java:
##########
@@ -49,6 +49,24 @@
    */
   TableScan useSnapshot(long snapshotId);
 
+  /**
+   * Create a new {@link TableScan} from this scan's configuration that will use the given branch
+   *
+   * @param branch the branch to scan from
+   * @return a new scan based on this with the given branch
+   * @throws IllegalArgumentException if the branch cannot be found
+   */
+  TableScan branch(String branch);

Review Comment:
   Would `useRef` be better? Just to match `useSnapshot`. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org