You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Deepak Goel <de...@gmail.com> on 2018/12/19 00:12:51 UTC
Review Request 69590: Moves CNI root directory to a persistent
location.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69590/
-----------------------------------------------------------
Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Sergey Urbanovich.
Bugs: MESOS-9492
https://issues.apache.org/jira/browse/MESOS-9492
Repository: mesos
Description
-------
This patch moves the CNI root directory to mesos working directory
so that the network related information persist across reboot which
will allow cni isolator to do proper cleanup post reboot
Diffs
-----
src/slave/containerizer/mesos/isolators/network/cni/cni.cpp f19edce0671686bc2dccf5dc6d3abc40b925852e
src/slave/containerizer/mesos/isolators/network/cni/paths.hpp 3b06fb101d03b32a3a148e2b79502413a7268d1e
src/slave/containerizer/mesos/isolators/network/cni/paths.cpp c1cb4f7d667159abbf87219cde30528a4a7b5283
src/slave/flags.hpp 29d8b7985ffde57da02b5fe0d3a524e98acc27c8
src/slave/flags.cpp ccaf65029ec2d0e78041fc3992a0bf5ca0798686
src/tests/containerizer/cni_isolator_tests.cpp 5473737cdc71a3179c22be0d4db2060a6ef53d24
Diff: https://reviews.apache.org/r/69590/diff/1/
Testing
-------
Thanks,
Deepak Goel
Re: Review Request 69590: Moves CNI root directory to a persistent
location.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
> On Dec. 19, 2018, 2:51 a.m., Qian Zhang wrote:
> > src/slave/flags.cpp
> > Lines 1191 (patched)
> > <https://reviews.apache.org/r/69590/diff/1/?file=2114817#file2114817line1191>
> >
> > Should the default value be `false` for backward compatibility?
>
> Chun-Hung Hsiao wrote:
> Hmm yeah maybe it's better if we make it default to `false` for now, and ask around the community to make the discussion transparent for a plan to enable it by default if needed.
>
> Also it is worth mentioning this new flag in `docs/configuration/agent.md` and `docs/upgrades.md`.
Oops it seems that you already updated `docs/configuration/agent.md`. My bad on missing that.
- Chun-Hung
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69590/#review211418
-----------------------------------------------------------
On Dec. 19, 2018, 3:25 a.m., Deepak Goel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69590/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2018, 3:25 a.m.)
>
>
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Sergey Urbanovich.
>
>
> Bugs: MESOS-9492
> https://issues.apache.org/jira/browse/MESOS-9492
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch moves the CNI root directory to mesos working directory
> so that the network related information persist across reboot which
> will allow cni isolator to do proper cleanup post reboot
>
>
> Diffs
> -----
>
> docs/cni.md 4a0e0bf57c6ff8d2bcc9fdf30d20672324da224c
> docs/configuration/agent.md 7a8df6852dc2af174a6c5a552dca88fa1b1c29f3
> src/slave/containerizer/mesos/isolators/network/cni/cni.cpp f19edce0671686bc2dccf5dc6d3abc40b925852e
> src/slave/containerizer/mesos/isolators/network/cni/paths.hpp 3b06fb101d03b32a3a148e2b79502413a7268d1e
> src/slave/containerizer/mesos/isolators/network/cni/paths.cpp c1cb4f7d667159abbf87219cde30528a4a7b5283
> src/slave/flags.hpp 29d8b7985ffde57da02b5fe0d3a524e98acc27c8
> src/slave/flags.cpp ccaf65029ec2d0e78041fc3992a0bf5ca0798686
> src/tests/containerizer/cni_isolator_tests.cpp 5473737cdc71a3179c22be0d4db2060a6ef53d24
>
>
> Diff: https://reviews.apache.org/r/69590/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Deepak Goel
>
>
Re: Review Request 69590: Moves CNI root directory to a persistent
location.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
> On Dec. 19, 2018, 2:51 a.m., Qian Zhang wrote:
> > src/slave/flags.cpp
> > Lines 1191 (patched)
> > <https://reviews.apache.org/r/69590/diff/1/?file=2114817#file2114817line1191>
> >
> > Should the default value be `false` for backward compatibility?
Hmm yeah maybe it's better if we make it default to `false` for now, and ask around the community to make the discussion transparent for a plan to enable it by default if needed.
Also it is worth mentioning this new flag in `docs/configuration/agent.md` and `docs/upgrades.md`.
- Chun-Hung
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69590/#review211418
-----------------------------------------------------------
On Dec. 19, 2018, 3:25 a.m., Deepak Goel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69590/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2018, 3:25 a.m.)
>
>
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Sergey Urbanovich.
>
>
> Bugs: MESOS-9492
> https://issues.apache.org/jira/browse/MESOS-9492
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch moves the CNI root directory to mesos working directory
> so that the network related information persist across reboot which
> will allow cni isolator to do proper cleanup post reboot
>
>
> Diffs
> -----
>
> docs/cni.md 4a0e0bf57c6ff8d2bcc9fdf30d20672324da224c
> docs/configuration/agent.md 7a8df6852dc2af174a6c5a552dca88fa1b1c29f3
> src/slave/containerizer/mesos/isolators/network/cni/cni.cpp f19edce0671686bc2dccf5dc6d3abc40b925852e
> src/slave/containerizer/mesos/isolators/network/cni/paths.hpp 3b06fb101d03b32a3a148e2b79502413a7268d1e
> src/slave/containerizer/mesos/isolators/network/cni/paths.cpp c1cb4f7d667159abbf87219cde30528a4a7b5283
> src/slave/flags.hpp 29d8b7985ffde57da02b5fe0d3a524e98acc27c8
> src/slave/flags.cpp ccaf65029ec2d0e78041fc3992a0bf5ca0798686
> src/tests/containerizer/cni_isolator_tests.cpp 5473737cdc71a3179c22be0d4db2060a6ef53d24
>
>
> Diff: https://reviews.apache.org/r/69590/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Deepak Goel
>
>
Re: Review Request 69590: Moves CNI root directory to a persistent
location.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69590/#review211418
-----------------------------------------------------------
src/slave/containerizer/mesos/isolators/network/cni/paths.hpp
Line 49 (original), 52 (patched)
<https://reviews.apache.org/r/69590/#comment296507>
One more newline.
src/slave/containerizer/mesos/isolators/network/cni/paths.hpp
Line 50 (original), 54 (patched)
<https://reviews.apache.org/r/69590/#comment296508>
Ditto.
src/slave/containerizer/mesos/isolators/network/cni/paths.cpp
Lines 37-38 (patched)
<https://reviews.apache.org/r/69590/#comment296505>
A newline between.
src/slave/containerizer/mesos/isolators/network/cni/paths.cpp
Lines 40 (patched)
<https://reviews.apache.org/r/69590/#comment296506>
One more newline.
src/slave/flags.hpp
Lines 165 (patched)
<https://reviews.apache.org/r/69590/#comment296504>
We need to update `agent.md` by adding this new flag into it, and also need to update `cni.md` to describe this new flag.
src/slave/flags.cpp
Lines 1191 (patched)
<https://reviews.apache.org/r/69590/#comment296503>
Should the default value be `false` for backward compatibility?
- Qian Zhang
On Dec. 19, 2018, 10:03 a.m., Deepak Goel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69590/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2018, 10:03 a.m.)
>
>
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Sergey Urbanovich.
>
>
> Bugs: MESOS-9492
> https://issues.apache.org/jira/browse/MESOS-9492
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch moves the CNI root directory to mesos working directory
> so that the network related information persist across reboot which
> will allow cni isolator to do proper cleanup post reboot
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/network/cni/cni.cpp f19edce0671686bc2dccf5dc6d3abc40b925852e
> src/slave/containerizer/mesos/isolators/network/cni/paths.hpp 3b06fb101d03b32a3a148e2b79502413a7268d1e
> src/slave/containerizer/mesos/isolators/network/cni/paths.cpp c1cb4f7d667159abbf87219cde30528a4a7b5283
> src/slave/flags.hpp 29d8b7985ffde57da02b5fe0d3a524e98acc27c8
> src/slave/flags.cpp ccaf65029ec2d0e78041fc3992a0bf5ca0798686
> src/tests/containerizer/cni_isolator_tests.cpp 5473737cdc71a3179c22be0d4db2060a6ef53d24
>
>
> Diff: https://reviews.apache.org/r/69590/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Deepak Goel
>
>
Re: Review Request 69590: Moves CNI root directory to a persistent
location.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69590/#review211424
-----------------------------------------------------------
Fix it, then Ship it!
The commit message of this patch seems not accurate to me, we are not moving CNI root directory to a persistent location, we actually added a new agent flag for operator to specify whether persist the network related information or not.
docs/cni.md
Lines 106 (patched)
<https://reviews.apache.org/r/69590/#comment296521>
As Chun mentioned, please also mention this flag in `docs/upgrades.md`.
docs/configuration/agent.md
Lines 1184 (patched)
<https://reviews.apache.org/r/69590/#comment296519>
s/persist/persists/
src/slave/flags.cpp
Lines 1190 (patched)
<https://reviews.apache.org/r/69590/#comment296520>
s/persist/persists/
And no need the leading space.
- Qian Zhang
On Dec. 19, 2018, 12:52 p.m., Deepak Goel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69590/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2018, 12:52 p.m.)
>
>
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Sergey Urbanovich.
>
>
> Bugs: MESOS-9492
> https://issues.apache.org/jira/browse/MESOS-9492
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch moves the CNI root directory to mesos working directory
> so that the network related information persist across reboot which
> will allow cni isolator to do proper cleanup post reboot
>
>
> Diffs
> -----
>
> docs/cni.md 4a0e0bf57c6ff8d2bcc9fdf30d20672324da224c
> docs/configuration/agent.md 7a8df6852dc2af174a6c5a552dca88fa1b1c29f3
> src/slave/containerizer/mesos/isolators/network/cni/cni.cpp f19edce0671686bc2dccf5dc6d3abc40b925852e
> src/slave/containerizer/mesos/isolators/network/cni/paths.hpp 3b06fb101d03b32a3a148e2b79502413a7268d1e
> src/slave/containerizer/mesos/isolators/network/cni/paths.cpp c1cb4f7d667159abbf87219cde30528a4a7b5283
> src/slave/flags.hpp 29d8b7985ffde57da02b5fe0d3a524e98acc27c8
> src/slave/flags.cpp ccaf65029ec2d0e78041fc3992a0bf5ca0798686
> src/tests/containerizer/cni_isolator_tests.cpp 5473737cdc71a3179c22be0d4db2060a6ef53d24
>
>
> Diff: https://reviews.apache.org/r/69590/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Deepak Goel
>
>
Re: Review Request 69590: Moves CNI root directory to a persistent
location.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69590/#review211423
-----------------------------------------------------------
Fix it, then Ship it!
src/slave/containerizer/mesos/isolators/network/cni/cni.cpp
Lines 1312-1313 (patched)
<https://reviews.apache.org/r/69590/#comment296517>
This log line along is not enough information. You need to at containerId and network name so that folks can correlate.
src/slave/containerizer/mesos/isolators/network/cni/cni.cpp
Lines 1785 (patched)
<https://reviews.apache.org/r/69590/#comment296518>
Ditto
src/slave/containerizer/mesos/isolators/network/cni/paths.hpp
Line 35 (original), 37 (patched)
<https://reviews.apache.org/r/69590/#comment296516>
Please update the comments here.
src/slave/containerizer/mesos/isolators/network/cni/paths.hpp
Line 48 (original), 50 (patched)
<https://reviews.apache.org/r/69590/#comment296515>
No need for this variable anymore. See my comments below.
src/slave/containerizer/mesos/isolators/network/cni/paths.cpp
Lines 37 (patched)
<https://reviews.apache.org/r/69590/#comment296514>
instead of use `paths::ROOT_DIR`, you should use `flags.runtime_dir`
- Jie Yu
On Dec. 19, 2018, 4:52 a.m., Deepak Goel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69590/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2018, 4:52 a.m.)
>
>
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Sergey Urbanovich.
>
>
> Bugs: MESOS-9492
> https://issues.apache.org/jira/browse/MESOS-9492
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch moves the CNI root directory to mesos working directory
> so that the network related information persist across reboot which
> will allow cni isolator to do proper cleanup post reboot
>
>
> Diffs
> -----
>
> docs/cni.md 4a0e0bf57c6ff8d2bcc9fdf30d20672324da224c
> docs/configuration/agent.md 7a8df6852dc2af174a6c5a552dca88fa1b1c29f3
> src/slave/containerizer/mesos/isolators/network/cni/cni.cpp f19edce0671686bc2dccf5dc6d3abc40b925852e
> src/slave/containerizer/mesos/isolators/network/cni/paths.hpp 3b06fb101d03b32a3a148e2b79502413a7268d1e
> src/slave/containerizer/mesos/isolators/network/cni/paths.cpp c1cb4f7d667159abbf87219cde30528a4a7b5283
> src/slave/flags.hpp 29d8b7985ffde57da02b5fe0d3a524e98acc27c8
> src/slave/flags.cpp ccaf65029ec2d0e78041fc3992a0bf5ca0798686
> src/tests/containerizer/cni_isolator_tests.cpp 5473737cdc71a3179c22be0d4db2060a6ef53d24
>
>
> Diff: https://reviews.apache.org/r/69590/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Deepak Goel
>
>
Re: Review Request 69590: Moves CNI root directory to a persistent
location.
Posted by Deepak Goel <de...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69590/
-----------------------------------------------------------
(Updated Dec. 19, 2018, 4:52 a.m.)
Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Sergey Urbanovich.
Bugs: MESOS-9492
https://issues.apache.org/jira/browse/MESOS-9492
Repository: mesos
Description
-------
This patch moves the CNI root directory to mesos working directory
so that the network related information persist across reboot which
will allow cni isolator to do proper cleanup post reboot
Diffs (updated)
-----
docs/cni.md 4a0e0bf57c6ff8d2bcc9fdf30d20672324da224c
docs/configuration/agent.md 7a8df6852dc2af174a6c5a552dca88fa1b1c29f3
src/slave/containerizer/mesos/isolators/network/cni/cni.cpp f19edce0671686bc2dccf5dc6d3abc40b925852e
src/slave/containerizer/mesos/isolators/network/cni/paths.hpp 3b06fb101d03b32a3a148e2b79502413a7268d1e
src/slave/containerizer/mesos/isolators/network/cni/paths.cpp c1cb4f7d667159abbf87219cde30528a4a7b5283
src/slave/flags.hpp 29d8b7985ffde57da02b5fe0d3a524e98acc27c8
src/slave/flags.cpp ccaf65029ec2d0e78041fc3992a0bf5ca0798686
src/tests/containerizer/cni_isolator_tests.cpp 5473737cdc71a3179c22be0d4db2060a6ef53d24
Diff: https://reviews.apache.org/r/69590/diff/4/
Changes: https://reviews.apache.org/r/69590/diff/3-4/
Testing
-------
Thanks,
Deepak Goel
Re: Review Request 69590: Moves CNI root directory to a persistent
location.
Posted by Deepak Goel <de...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69590/
-----------------------------------------------------------
(Updated Dec. 19, 2018, 3:25 a.m.)
Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Sergey Urbanovich.
Bugs: MESOS-9492
https://issues.apache.org/jira/browse/MESOS-9492
Repository: mesos
Description
-------
This patch moves the CNI root directory to mesos working directory
so that the network related information persist across reboot which
will allow cni isolator to do proper cleanup post reboot
Diffs (updated)
-----
docs/cni.md 4a0e0bf57c6ff8d2bcc9fdf30d20672324da224c
docs/configuration/agent.md 7a8df6852dc2af174a6c5a552dca88fa1b1c29f3
src/slave/containerizer/mesos/isolators/network/cni/cni.cpp f19edce0671686bc2dccf5dc6d3abc40b925852e
src/slave/containerizer/mesos/isolators/network/cni/paths.hpp 3b06fb101d03b32a3a148e2b79502413a7268d1e
src/slave/containerizer/mesos/isolators/network/cni/paths.cpp c1cb4f7d667159abbf87219cde30528a4a7b5283
src/slave/flags.hpp 29d8b7985ffde57da02b5fe0d3a524e98acc27c8
src/slave/flags.cpp ccaf65029ec2d0e78041fc3992a0bf5ca0798686
src/tests/containerizer/cni_isolator_tests.cpp 5473737cdc71a3179c22be0d4db2060a6ef53d24
Diff: https://reviews.apache.org/r/69590/diff/3/
Changes: https://reviews.apache.org/r/69590/diff/2-3/
Testing
-------
Thanks,
Deepak Goel
Re: Review Request 69590: Moves CNI root directory to a persistent
location.
Posted by Deepak Goel <de...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69590/
-----------------------------------------------------------
(Updated Dec. 19, 2018, 2:03 a.m.)
Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Sergey Urbanovich.
Bugs: MESOS-9492
https://issues.apache.org/jira/browse/MESOS-9492
Repository: mesos
Description
-------
This patch moves the CNI root directory to mesos working directory
so that the network related information persist across reboot which
will allow cni isolator to do proper cleanup post reboot
Diffs (updated)
-----
src/slave/containerizer/mesos/isolators/network/cni/cni.cpp f19edce0671686bc2dccf5dc6d3abc40b925852e
src/slave/containerizer/mesos/isolators/network/cni/paths.hpp 3b06fb101d03b32a3a148e2b79502413a7268d1e
src/slave/containerizer/mesos/isolators/network/cni/paths.cpp c1cb4f7d667159abbf87219cde30528a4a7b5283
src/slave/flags.hpp 29d8b7985ffde57da02b5fe0d3a524e98acc27c8
src/slave/flags.cpp ccaf65029ec2d0e78041fc3992a0bf5ca0798686
src/tests/containerizer/cni_isolator_tests.cpp 5473737cdc71a3179c22be0d4db2060a6ef53d24
Diff: https://reviews.apache.org/r/69590/diff/2/
Changes: https://reviews.apache.org/r/69590/diff/1-2/
Testing
-------
Thanks,
Deepak Goel
Re: Review Request 69590: Moves CNI root directory to a persistent
location.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
> On Dec. 19, 2018, 12:48 a.m., Till Toenshoff wrote:
> > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp
> > Lines 1307-1308 (original)
> > <https://reviews.apache.org/r/69590/diff/1/?file=2114813#file2114813line1309>
> >
> > Are we assuming that this location was never meant for users?
>
> Deepak Goel wrote:
> Didn't understand your comment? Which location you are talking about?
I guess Till was asking why the log of `networkConfigJSON` is hidden from user-facing logs (`LOG(INFO)`), unlike the other log lines.
- Chun-Hung
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69590/#review211416
-----------------------------------------------------------
On Dec. 19, 2018, 3:25 a.m., Deepak Goel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69590/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2018, 3:25 a.m.)
>
>
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Sergey Urbanovich.
>
>
> Bugs: MESOS-9492
> https://issues.apache.org/jira/browse/MESOS-9492
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch moves the CNI root directory to mesos working directory
> so that the network related information persist across reboot which
> will allow cni isolator to do proper cleanup post reboot
>
>
> Diffs
> -----
>
> docs/cni.md 4a0e0bf57c6ff8d2bcc9fdf30d20672324da224c
> docs/configuration/agent.md 7a8df6852dc2af174a6c5a552dca88fa1b1c29f3
> src/slave/containerizer/mesos/isolators/network/cni/cni.cpp f19edce0671686bc2dccf5dc6d3abc40b925852e
> src/slave/containerizer/mesos/isolators/network/cni/paths.hpp 3b06fb101d03b32a3a148e2b79502413a7268d1e
> src/slave/containerizer/mesos/isolators/network/cni/paths.cpp c1cb4f7d667159abbf87219cde30528a4a7b5283
> src/slave/flags.hpp 29d8b7985ffde57da02b5fe0d3a524e98acc27c8
> src/slave/flags.cpp ccaf65029ec2d0e78041fc3992a0bf5ca0798686
> src/tests/containerizer/cni_isolator_tests.cpp 5473737cdc71a3179c22be0d4db2060a6ef53d24
>
>
> Diff: https://reviews.apache.org/r/69590/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Deepak Goel
>
>
Re: Review Request 69590: Moves CNI root directory to a persistent
location.
Posted by Deepak Goel <de...@gmail.com>.
> On Dec. 19, 2018, 12:48 a.m., Till Toenshoff wrote:
> > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp
> > Lines 1307-1308 (original)
> > <https://reviews.apache.org/r/69590/diff/1/?file=2114813#file2114813line1309>
> >
> > Are we assuming that this location was never meant for users?
>
> Deepak Goel wrote:
> Didn't understand your comment? Which location you are talking about?
>
> Chun-Hung Hsiao wrote:
> I guess Till was asking why the log of `networkConfigJSON` is hidden from user-facing logs (`LOG(INFO)`), unlike the other log lines.
Got it. networkConfigJSON might get big and could quickly fill up the log space. Hence, kept it at VLOG level just for debugging purpose.
- Deepak
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69590/#review211416
-----------------------------------------------------------
On Dec. 19, 2018, 4:52 a.m., Deepak Goel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69590/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2018, 4:52 a.m.)
>
>
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Sergey Urbanovich.
>
>
> Bugs: MESOS-9492
> https://issues.apache.org/jira/browse/MESOS-9492
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch moves the CNI root directory to mesos working directory
> so that the network related information persist across reboot which
> will allow cni isolator to do proper cleanup post reboot
>
>
> Diffs
> -----
>
> docs/cni.md 4a0e0bf57c6ff8d2bcc9fdf30d20672324da224c
> docs/configuration/agent.md 7a8df6852dc2af174a6c5a552dca88fa1b1c29f3
> src/slave/containerizer/mesos/isolators/network/cni/cni.cpp f19edce0671686bc2dccf5dc6d3abc40b925852e
> src/slave/containerizer/mesos/isolators/network/cni/paths.hpp 3b06fb101d03b32a3a148e2b79502413a7268d1e
> src/slave/containerizer/mesos/isolators/network/cni/paths.cpp c1cb4f7d667159abbf87219cde30528a4a7b5283
> src/slave/flags.hpp 29d8b7985ffde57da02b5fe0d3a524e98acc27c8
> src/slave/flags.cpp ccaf65029ec2d0e78041fc3992a0bf5ca0798686
> src/tests/containerizer/cni_isolator_tests.cpp 5473737cdc71a3179c22be0d4db2060a6ef53d24
>
>
> Diff: https://reviews.apache.org/r/69590/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Deepak Goel
>
>
Re: Review Request 69590: Moves CNI root directory to a persistent
location.
Posted by Deepak Goel <de...@gmail.com>.
> On Dec. 19, 2018, 12:48 a.m., Till Toenshoff wrote:
> > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp
> > Lines 1307-1308 (original)
> > <https://reviews.apache.org/r/69590/diff/1/?file=2114813#file2114813line1309>
> >
> > Are we assuming that this location was never meant for users?
Didn't understand your comment? Which location you are talking about?
- Deepak
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69590/#review211416
-----------------------------------------------------------
On Dec. 19, 2018, 2:03 a.m., Deepak Goel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69590/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2018, 2:03 a.m.)
>
>
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Sergey Urbanovich.
>
>
> Bugs: MESOS-9492
> https://issues.apache.org/jira/browse/MESOS-9492
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch moves the CNI root directory to mesos working directory
> so that the network related information persist across reboot which
> will allow cni isolator to do proper cleanup post reboot
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/network/cni/cni.cpp f19edce0671686bc2dccf5dc6d3abc40b925852e
> src/slave/containerizer/mesos/isolators/network/cni/paths.hpp 3b06fb101d03b32a3a148e2b79502413a7268d1e
> src/slave/containerizer/mesos/isolators/network/cni/paths.cpp c1cb4f7d667159abbf87219cde30528a4a7b5283
> src/slave/flags.hpp 29d8b7985ffde57da02b5fe0d3a524e98acc27c8
> src/slave/flags.cpp ccaf65029ec2d0e78041fc3992a0bf5ca0798686
> src/tests/containerizer/cni_isolator_tests.cpp 5473737cdc71a3179c22be0d4db2060a6ef53d24
>
>
> Diff: https://reviews.apache.org/r/69590/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Deepak Goel
>
>
Re: Review Request 69590: Moves CNI root directory to a persistent
location.
Posted by Till Toenshoff via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69590/#review211416
-----------------------------------------------------------
Thanks for this. Just some nitpicking below :)
src/slave/containerizer/mesos/isolators/network/cni/cni.cpp
Lines 1307-1308 (original)
<https://reviews.apache.org/r/69590/#comment296498>
Are we assuming that this location was never meant for users?
src/slave/containerizer/mesos/isolators/network/cni/cni.cpp
Lines 1312 (patched)
<https://reviews.apache.org/r/69590/#comment296497>
s/"network/"Network/g
src/slave/containerizer/mesos/isolators/network/cni/cni.cpp
Line 1779 (original)
<https://reviews.apache.org/r/69590/#comment296495>
See above.
src/slave/containerizer/mesos/isolators/network/cni/cni.cpp
Lines 1785 (patched)
<https://reviews.apache.org/r/69590/#comment296496>
See above.
src/slave/flags.cpp
Lines 1189 (patched)
<https://reviews.apache.org/r/69590/#comment296493>
```
"This setting controls whether the CNI root directory\n"
" persists beyond reboots or not."
```
Maybe?
src/tests/containerizer/cni_isolator_tests.cpp
Lines 2542 (patched)
<https://reviews.apache.org/r/69590/#comment296491>
Add a trailing period please. And maybe
```
// This test verifies the CNI root directory path.
```
src/tests/containerizer/cni_isolator_tests.cpp
Lines 2564 (patched)
<https://reviews.apache.org/r/69590/#comment296499>
We can do without this, I feel.
src/tests/containerizer/cni_isolator_tests.cpp
Lines 2567 (patched)
<https://reviews.apache.org/r/69590/#comment296501>
This seems to be the most relevant part of this test - checking with and without this flag enabled. Maybe we should add a comment here?
src/tests/containerizer/cni_isolator_tests.cpp
Lines 2569 (patched)
<https://reviews.apache.org/r/69590/#comment296500>
Either remove these two please or start with capital letter and end with punctuation. Thanks.
- Till Toenshoff
On Dec. 19, 2018, 12:12 a.m., Deepak Goel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69590/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2018, 12:12 a.m.)
>
>
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Sergey Urbanovich.
>
>
> Bugs: MESOS-9492
> https://issues.apache.org/jira/browse/MESOS-9492
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch moves the CNI root directory to mesos working directory
> so that the network related information persist across reboot which
> will allow cni isolator to do proper cleanup post reboot
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/network/cni/cni.cpp f19edce0671686bc2dccf5dc6d3abc40b925852e
> src/slave/containerizer/mesos/isolators/network/cni/paths.hpp 3b06fb101d03b32a3a148e2b79502413a7268d1e
> src/slave/containerizer/mesos/isolators/network/cni/paths.cpp c1cb4f7d667159abbf87219cde30528a4a7b5283
> src/slave/flags.hpp 29d8b7985ffde57da02b5fe0d3a524e98acc27c8
> src/slave/flags.cpp ccaf65029ec2d0e78041fc3992a0bf5ca0798686
> src/tests/containerizer/cni_isolator_tests.cpp 5473737cdc71a3179c22be0d4db2060a6ef53d24
>
>
> Diff: https://reviews.apache.org/r/69590/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Deepak Goel
>
>