You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/01/19 13:01:00 UTC
[jira] [Commented] (CB-13800) Drop pre-KitKat specific code
[ https://issues.apache.org/jira/browse/CB-13800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332220#comment-16332220 ]
ASF GitHub Bot commented on CB-13800:
-------------------------------------
BBosman opened a new pull request #429: CB-13800: Drop pre-KitKat specific code
URL: https://github.com/apache/cordova-android/pull/429
### Platforms affected
Android
### What does this PR do?
With the release of cordova-android 7.0.0 the minimum API-Level was set to 19. There are a couple of places in the codebase where we have specific logic for older API-levels which are now no longer needed and can therefore be removed.
This PR removes them. It results in (negligible) faster execution and smaller binary sizes, but most importantly less code to maintain.
### What testing has been done on this change?
Ran:
* npm test
* gradlew test
* gradlew connectedAndroidTest
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Drop pre-KitKat specific code
> -----------------------------
>
> Key: CB-13800
> URL: https://issues.apache.org/jira/browse/CB-13800
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-android
> Affects Versions: 7.0.0
> Reporter: Bas Bosman
> Assignee: Bas Bosman
> Priority: Minor
>
> With the release of cordova-android 7.0.0 the minimum API-Level was set to 19.
>
> There are a couple of places in the codebase where we have specific logic for older API-levels, which are now no longer needed and therefore can be removed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org