[GitHub] [maven] sultan commented on a diff in pull request #929: [MNG-7559] Fix version comparison (master 4.0.x branch)

["sultan (via GitHub)" <gi...@apache.org>]

sultan commented on code in PR #929:
URL: https://github.com/apache/maven/pull/929#discussion_r1121522502


##########
maven-artifact/src/test/java/org/apache/maven/artifact/versioning/ComparableVersionTest.java:
##########
@@ -346,4 +342,22 @@ public void testReuse() {
 
         assertEquals(c1, c2, "reused instance should be equivalent to new instance");
     }
+
+    /**
+     * Test <a href="https://issues.apache.org/jira/browse/MNG-7559">MNG-7559</a> edge cases
+     * 1.0.0.RC1 < 1.0.0-RC2
+     * -pfd < final, ga, release
+     * 2.0.1.MR < 2.0.1
+     * 9.4.1.jre16 > 9.4.1.jre16-preview
+     */
+    @Test
+    public void testMng7559() {
+        checkVersionsOrder("1.0.0.RC1", "1.0.0-RC2");
+        checkVersionsOrder("4.0.0.Beta3", "4.0.0-RC2");
+        checkVersionsOrder("2.3-pfd", "2.3");
+        checkVersionsOrder("2.0.1.MR", "2.0.1");
+        checkVersionsOrder("9.4.1.jre16-preview", "9.4.1.jre16");
+        checkVersionsEqual("2.0.a", "2.0.0.a"); // previously ordered, now equals
+        checkVersionsOrder("1-sp-1", "1-ga-1"); // proving website documentation right.

Review Comment:
   i think the number are already taken into account but a unit test for will not hurt
   
   i'll have to amend the code; meanwhile there should be a talk -maybe i should join the mailing list- about what the future yields between Maven and 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org