You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@directory.apache.org by el...@apache.org on 2014/03/18 13:38:51 UTC

svn commit: r1578847 - in /directory/shared/trunk/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/extended: cancel/ certGeneration/ gracefulDisconnect/ gracefulShutdown/ storedProcedure/

Author: elecharny
Date: Tue Mar 18 12:38:51 2014
New Revision: 1578847

URL: http://svn.apache.org/r1578847
Log:
o Added a missing ExtensionOID
o Added missing Javadoc
o Minor formating and typoes fixing

Modified:
    directory/shared/trunk/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/extended/cancel/CancelRequest.java
    directory/shared/trunk/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/extended/cancel/CancelResponse.java
    directory/shared/trunk/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/extended/certGeneration/CertGenerationRequest.java
    directory/shared/trunk/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/extended/gracefulDisconnect/GracefulDisconnectResponse.java
    directory/shared/trunk/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/extended/gracefulShutdown/GracefulShutdownRequest.java
    directory/shared/trunk/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/extended/storedProcedure/StoredProcedureParameter.java
    directory/shared/trunk/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/extended/storedProcedure/StoredProcedureRequest.java

Modified: directory/shared/trunk/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/extended/cancel/CancelRequest.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/extended/cancel/CancelRequest.java?rev=1578847&r1=1578846&r2=1578847&view=diff
==============================================================================
--- directory/shared/trunk/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/extended/cancel/CancelRequest.java (original)
+++ directory/shared/trunk/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/extended/cancel/CancelRequest.java Tue Mar 18 12:38:51 2014
@@ -30,8 +30,7 @@ import org.apache.directory.api.ldap.mod
  */
 public interface CancelRequest extends ExtendedRequest
 {
-
-    /** The requestName for this extended request */
+    /** The OID for the Cancel extended operation request. */
     static final String EXTENSION_OID = "1.3.6.1.1.8";
 
 

Modified: directory/shared/trunk/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/extended/cancel/CancelResponse.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/extended/cancel/CancelResponse.java?rev=1578847&r1=1578846&r2=1578847&view=diff
==============================================================================
--- directory/shared/trunk/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/extended/cancel/CancelResponse.java (original)
+++ directory/shared/trunk/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/extended/cancel/CancelResponse.java Tue Mar 18 12:38:51 2014
@@ -30,5 +30,6 @@ import org.apache.directory.api.ldap.mod
  */
 public interface CancelResponse extends ExtendedResponse
 {
-
+    /** The OID for the Cancel extended operation request. */
+    static final String EXTENSION_OID = CancelRequest.EXTENSION_OID;
 }
\ No newline at end of file

Modified: directory/shared/trunk/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/extended/certGeneration/CertGenerationRequest.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/extended/certGeneration/CertGenerationRequest.java?rev=1578847&r1=1578846&r2=1578847&view=diff
==============================================================================
--- directory/shared/trunk/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/extended/certGeneration/CertGenerationRequest.java (original)
+++ directory/shared/trunk/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/extended/certGeneration/CertGenerationRequest.java Tue Mar 18 12:38:51 2014
@@ -30,9 +30,11 @@ import org.apache.directory.api.ldap.mod
  */
 public interface CertGenerationRequest extends ExtendedRequest
 {
+    /** The OID for the Certificate Generation extended operation request. */
     static final String EXTENSION_OID = "1.3.6.1.4.1.18060.0.1.8";
 
 
+    /** Get the Traget DN for the certificate storage */
     String getTargetDN();
 
 

Modified: directory/shared/trunk/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/extended/gracefulDisconnect/GracefulDisconnectResponse.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/extended/gracefulDisconnect/GracefulDisconnectResponse.java?rev=1578847&r1=1578846&r2=1578847&view=diff
==============================================================================
--- directory/shared/trunk/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/extended/gracefulDisconnect/GracefulDisconnectResponse.java (original)
+++ directory/shared/trunk/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/extended/gracefulDisconnect/GracefulDisconnectResponse.java Tue Mar 18 12:38:51 2014
@@ -48,7 +48,7 @@ public interface GracefulDisconnectRespo
 
 
     /**
-     * Sets the delay befor disconnection, in seconds.
+     * Sets the delay before disconnection, in seconds.
      *
      * @param delay the new delay before disconnection
      */

Modified: directory/shared/trunk/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/extended/gracefulShutdown/GracefulShutdownRequest.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/extended/gracefulShutdown/GracefulShutdownRequest.java?rev=1578847&r1=1578846&r2=1578847&view=diff
==============================================================================
--- directory/shared/trunk/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/extended/gracefulShutdown/GracefulShutdownRequest.java (original)
+++ directory/shared/trunk/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/extended/gracefulShutdown/GracefulShutdownRequest.java Tue Mar 18 12:38:51 2014
@@ -34,7 +34,6 @@ import org.apache.directory.api.ldap.mod
  */
 public interface GracefulShutdownRequest extends ExtendedRequest
 {
-
     /** The OID for the graceful shutdown extended operation request. */
     String EXTENSION_OID = "1.3.6.1.4.1.18060.0.1.3";
 
@@ -54,7 +53,7 @@ public interface GracefulShutdownRequest
 
 
     /**
-     * Sets the delay befor disconnection, in seconds.
+     * Sets the delay before disconnection, in seconds.
      *
      * @param delay the new delay before disconnection
      */

Modified: directory/shared/trunk/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/extended/storedProcedure/StoredProcedureParameter.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/extended/storedProcedure/StoredProcedureParameter.java?rev=1578847&r1=1578846&r2=1578847&view=diff
==============================================================================
--- directory/shared/trunk/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/extended/storedProcedure/StoredProcedureParameter.java (original)
+++ directory/shared/trunk/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/extended/storedProcedure/StoredProcedureParameter.java Tue Mar 18 12:38:51 2014
@@ -32,6 +32,7 @@ public class StoredProcedureParameter
 {
     /** the type of the parameter */
     private byte[] type;
+
     /** the value of the parameter */
     private byte[] value;
 

Modified: directory/shared/trunk/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/extended/storedProcedure/StoredProcedureRequest.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/extended/storedProcedure/StoredProcedureRequest.java?rev=1578847&r1=1578846&r2=1578847&view=diff
==============================================================================
--- directory/shared/trunk/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/extended/storedProcedure/StoredProcedureRequest.java (original)
+++ directory/shared/trunk/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/extended/storedProcedure/StoredProcedureRequest.java Tue Mar 18 12:38:51 2014
@@ -52,9 +52,15 @@ public interface StoredProcedureRequest 
     void setLanguage( String language );
 
 
+    /**
+     * @return The byte[] containing the procedure's bytecode
+     */
     byte[] getProcedure();
 
 
+    /**
+     * @param procedure The procedure's bytecode
+     */
     void setProcedure( byte[] procedure );
 
 
@@ -69,7 +75,7 @@ public interface StoredProcedureRequest 
     /**
      * Size.
      *
-     * @return the int
+     * @return the procedure's bytcode size
      */
     int size();