[GitHub] [incubator-druid] mcbrewster commented on a change in pull request #7986: Web Console: add Group by interval to segments view

[GitBox <gi...@apache.org>]

mcbrewster commented on a change in pull request #7986: Web Console: add Group by interval to segments view
URL: https://github.com/apache/incubator-druid/pull/7986#discussion_r298470982
 
 

 ##########
 File path: web-console/src/views/segments-view/segments-view.tsx
 ##########
 @@ -114,7 +116,7 @@ interface SegmentQueryResultRow {
 export class SegmentsView extends React.PureComponent<SegmentsViewProps, SegmentsViewState> {
   private segmentsSqlQueryManager: QueryManager<QueryAndSkip, SegmentQueryResultRow[]>;
   private segmentsJsonQueryManager: QueryManager<any, SegmentQueryResultRow[]>;
-
+  private previousTableState: any;
 
 Review comment:
   Why I am using that is because when you click on the interval button you have to call fetch data() because there is no onPivotBy for the react table or anything like that. You need the state of the table though to get the number of segments, and I'm not sure how to get that from outside the table. I looked at the documentation and there are like accessors for you to set state but not to return state, I also though about using a ref but typescript didn't like that. How would you solve that problem ? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org