[jira] [Commented] (HBASE-20928) Rewrite calculation of midpoint in binarySearch functions to prevent overflow

["Hudson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-20928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16741001#comment-16741001 ] 

Hudson commented on HBASE-20928:
--------------------------------

Results for branch branch-1
	[build #629 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/629/]: (x) *{color:red}-1 overall{color}*
----
details (if available):

(x) {color:red}-1 general checks{color}
-- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/629//General_Nightly_Build_Report/]


(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7 report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/629//JDK7_Nightly_Build_Report/]


(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/629//JDK8_Nightly_Build_Report_(Hadoop2)/]




(x) {color:red}-1 source release artifact{color}
-- See build output for details.


> Rewrite calculation of midpoint in binarySearch functions to prevent overflow
> -----------------------------------------------------------------------------
>
>                 Key: HBASE-20928
>                 URL: https://issues.apache.org/jira/browse/HBASE-20928
>             Project: HBase
>          Issue Type: Bug
>          Components: io
>            Reporter: saurabh singh
>            Assignee: saurabh singh
>            Priority: Minor
>             Fix For: 1.5.0, 2.2.0
>
>         Attachments: HBASE-20928-addendum.patch, HBASE-20928-fix-binarySearch-v5.patch, HBASE-20928-fix-binarySearch-v5.patch
>
>
> There are couple of issues in the function:
>  * {{>>>}} operator would mess the values if {{low}} + {{high}} end up being negative. This shouldn't happen but I don't see anything to prevent this from happening.
>  * The code fails around boundary values of {{low}} and {{high}}. This is a well known binary search catch. [https://ai.googleblog.com/2006/06/extra-extra-read-all-about-it-nearly.html]
>  
> Most of the code should already be covered by tests. I would have liked to add a test that actually fails without the fix but given these are private methods I am not sure on the best place to add the test. Suggestions?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)