You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/08/29 13:32:35 UTC
[GitHub] [ignite-3] zstan opened a new pull request, #1042: IGNITE-16040 Bump calcite version to 1.31.
zstan opened a new pull request, #1042:
URL: https://github.com/apache/ignite-3/pull/1042
New calcite version contains fix for queries with several correlated sub-queries in select list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] zstan closed pull request #1042: IGNITE-16040 Bump calcite version to 1.31.
Posted by GitBox <gi...@apache.org>.
zstan closed pull request #1042: IGNITE-16040 Bump calcite version to 1.31.
URL: https://github.com/apache/ignite-3/pull/1042
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] korlov42 commented on a diff in pull request #1042: IGNITE-16040 Bump calcite version to 1.31.
Posted by GitBox <gi...@apache.org>.
korlov42 commented on code in PR #1042:
URL: https://github.com/apache/ignite-3/pull/1042#discussion_r962923853
##########
modules/runner/src/integrationTest/sql/subquery/exists/test_correlated_exists.test_ignore:
##########
@@ -13,9 +13,29 @@ PRAGMA enable_verification
statement ok
CREATE TABLE integers(i INTEGER)
+statement ok
+CREATE TABLE t1(a INTEGER, b INTEGER, c INTEGER, d INTEGER, e INTEGER, f INTEGER)
+
+statement ok
+INSERT INTO t1 VALUES (1, 2, 6, 4, 5, 6), (2, 3, 6, 5, 6, 7)
+
statement ok
INSERT INTO integers VALUES (1), (2), (3), (NULL)
+query IIIIII
Review Comment:
then why do we have such a test at all?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] zstan commented on a diff in pull request #1042: IGNITE-16040 Bump calcite version to 1.31.
Posted by GitBox <gi...@apache.org>.
zstan commented on code in PR #1042:
URL: https://github.com/apache/ignite-3/pull/1042#discussion_r964538055
##########
modules/runner/src/integrationTest/sql/sqlite/join/join1.test_ignore:
##########
@@ -0,0 +1,159 @@
+# Ignore https://issues.apache.org/jira/browse/CALCITE-5253
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] zstan commented on a diff in pull request #1042: IGNITE-16040 Bump calcite version to 1.31.
Posted by GitBox <gi...@apache.org>.
zstan commented on code in PR #1042:
URL: https://github.com/apache/ignite-3/pull/1042#discussion_r963277904
##########
modules/runner/src/integrationTest/sql/sqlite/join/join1.test_ignore:
##########
@@ -0,0 +1,159 @@
+# Ignore https://issues.apache.org/jira/browse/CALCITE-5253
Review Comment:
I assure you that i not forget and i plan to complete with calcite issue soon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] korlov42 commented on a diff in pull request #1042: IGNITE-16040 Bump calcite version to 1.31.
Posted by GitBox <gi...@apache.org>.
korlov42 commented on code in PR #1042:
URL: https://github.com/apache/ignite-3/pull/1042#discussion_r962658058
##########
modules/runner/src/integrationTest/sql/sqlite/join/join1.test_ignore:
##########
@@ -0,0 +1,159 @@
+# Ignore https://issues.apache.org/jira/browse/CALCITE-5253
Review Comment:
Could you please file IGNITE ticket related to a CALCITE ticket? I'm afraid we will forget to uncomment this if there won't be a corresponding ticket in Ignite backlog
##########
modules/runner/src/integrationTest/sql/subquery/exists/test_correlated_exists.test_ignore:
##########
@@ -13,9 +13,29 @@ PRAGMA enable_verification
statement ok
CREATE TABLE integers(i INTEGER)
+statement ok
+CREATE TABLE t1(a INTEGER, b INTEGER, c INTEGER, d INTEGER, e INTEGER, f INTEGER)
+
+statement ok
+INSERT INTO t1 VALUES (1, 2, 6, 4, 5, 6), (2, 3, 6, 5, 6, 7)
+
statement ok
INSERT INTO integers VALUES (1), (2), (3), (NULL)
+query IIIIII
Review Comment:
we already have this very test in `select1.test` script
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] zstan commented on pull request #1042: IGNITE-16040 Bump calcite version to 1.31.
Posted by GitBox <gi...@apache.org>.
zstan commented on PR #1042:
URL: https://github.com/apache/ignite-3/pull/1042#issuecomment-1239069725
@korlov42 all done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] zstan commented on a diff in pull request #1042: IGNITE-16040 Bump calcite version to 1.31.
Posted by GitBox <gi...@apache.org>.
zstan commented on code in PR #1042:
URL: https://github.com/apache/ignite-3/pull/1042#discussion_r962811841
##########
modules/runner/src/integrationTest/sql/subquery/exists/test_correlated_exists.test_ignore:
##########
@@ -13,9 +13,29 @@ PRAGMA enable_verification
statement ok
CREATE TABLE integers(i INTEGER)
+statement ok
+CREATE TABLE t1(a INTEGER, b INTEGER, c INTEGER, d INTEGER, e INTEGER, f INTEGER)
+
+statement ok
+INSERT INTO t1 VALUES (1, 2, 6, 4, 5, 6), (2, 3, 6, 5, 6, 7)
+
statement ok
INSERT INTO integers VALUES (1), (2), (3), (NULL)
+query IIIIII
Review Comment:
in test1 returned resultset not checked, here i fill appropriate data and check result too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] korlov42 commented on a diff in pull request #1042: IGNITE-16040 Bump calcite version to 1.31.
Posted by GitBox <gi...@apache.org>.
korlov42 commented on code in PR #1042:
URL: https://github.com/apache/ignite-3/pull/1042#discussion_r963308897
##########
modules/runner/src/integrationTest/sql/sqlite/join/join1.test_ignore:
##########
@@ -0,0 +1,159 @@
+# Ignore https://issues.apache.org/jira/browse/CALCITE-5253
Review Comment:
Well, patch in Calcite's upstream is not the only requirement. We need to bump a version in Ignite to acquire that fix as well. So, please file IGNITE ticket
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org