You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/02/01 11:28:56 UTC

[GitHub] leventov opened a new issue #6977: Design of MaterializedViewQuery

leventov opened a new issue #6977: Design of MaterializedViewQuery
URL: https://github.com/apache/incubator-druid/issues/6977
 
 
   Currently, #5556 implements it as `MaterializedViewQuery` and `MaterializedViewQueryQueryToolChest`, i. e. in the same type framework as `Query` and `QueryToolChest`. However, `MaterializedViewQuery` and `MaterializedViewQueryQueryToolChest` are shallow and pass-through classes. `MaterializedViewQueryQueryToolChest` couldn't sensibly return something from `getResultTypeReference()`, so I wonder why it didn't throw NPE in `DirectDruidClient` before, but I hit this problem in my change #6898.
   
   There should probably be an abstraction like "query modifier" and other parts of the infrastructure should recognize it.
   
   cc @zhangxinyu1 @jihoonson 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org