You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/05 03:42:01 UTC

[GitHub] [pulsar] Technoboy- opened a new pull request, #15937: [fix][test] Fix flaky test PersistentTopicsTest#testTriggerCompactionTopic

Technoboy- opened a new pull request, #15937:
URL: https://github.com/apache/pulsar/pull/15937

   Fixes #15894
   ### Motivation
   
   `testTriggerCompactionTopic` is flaky, because `createNonPartitionedTopic ` and `compact` use the same response: 
   
   https://github.com/apache/pulsar/blob/ecd275dc21f33483a649e5b872990771257b1d45/pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/PersistentTopicsTest.java#L902-L908
   
   they are both return `Status.NO_CONTENT`, so the test fails sporadically with below error:
   ```
   But was 2 times:
   -> at org.apache.pulsar.broker.admin.impl.PersistentTopicsBase.lambda$internalTriggerCompactionNonPartitionedTopic$309(PersistentTopicsBase.java:3804)
   -> at org.apache.pulsar.broker.admin.v2.PersistentTopics.lambda$createNonPartitionedTopic$2(PersistentTopics.java:352)
   ```
   
   ### Documentation
   
   - [x] `doc-not-needed` 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] BewareMyPower commented on pull request #15937: [fix][test] Fix flaky test PersistentTopicsTest#testTriggerCompactionTopic

Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on PR #15937:
URL: https://github.com/apache/pulsar/pull/15937#issuecomment-1197778237

   Remove these labels since this flakiness is related to the code changes from https://github.com/apache/pulsar/pull/14030.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] lhotari merged pull request #15937: [fix][test] Fix flaky test PersistentTopicsTest#testTriggerCompactionTopic

Posted by GitBox <gi...@apache.org>.
lhotari merged PR #15937:
URL: https://github.com/apache/pulsar/pull/15937


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] BewareMyPower commented on pull request #15937: [fix][test] Fix flaky test PersistentTopicsTest#testTriggerCompactionTopic

Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on PR #15937:
URL: https://github.com/apache/pulsar/pull/15937#issuecomment-1197759260

   Add `release/xxx` labels because I see it also fail in branch-2.8: https://github.com/apache/pulsar/runs/7552588163?check_suite_focus=true


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org