[GitHub] spark pull request #13189: [SPARK-14670][SQL][WIP] allow updating driver sid...

[davies <gi...@git.apache.org>]

Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13189#discussion_r65990142
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SQLListener.scala ---
    @@ -361,17 +377,22 @@ private[spark] class SQLHistoryListener(conf: SparkConf, sparkUI: SparkUI)
     /**
      * Represent all necessary data for an execution that will be used in Web UI.
      */
    -private[ui] class SQLExecutionUIData(
    -    val executionId: Long,
    -    val description: String,
    -    val details: String,
    -    val physicalPlanDescription: String,
    -    val physicalPlanGraph: SparkPlanGraph,
    -    val accumulatorMetrics: Map[Long, SQLPlanMetric],
    -    val submissionTime: Long,
    -    var completionTime: Option[Long] = None,
    -    val jobs: mutable.HashMap[Long, JobExecutionStatus] = mutable.HashMap.empty,
    -    val stages: mutable.ArrayBuffer[Int] = mutable.ArrayBuffer()) {
    +private[ui] case class SQLExecutionUIData(
    +    executionId: Long,
    +    description: String,
    +    details: String,
    +    physicalPlanDescription: String,
    +    physicalPlanGraph: SparkPlanGraph,
    +    accumulatorMetrics: Map[Long, SQLPlanMetric],
    +    submissionTime: Long) {
    +
    +  var completionTime: Option[Long] = None
    +
    +  val jobs: mutable.HashMap[Long, JobExecutionStatus] = mutable.HashMap.empty
    +
    +  val stages: mutable.ArrayBuffer[Int] = mutable.ArrayBuffer()
    +
    +  val driverAccumUpdates: mutable.HashMap[Long, Long] = mutable.HashMap.empty
    --- End diff --
    
    [Long, String] ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org