You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by skyahead <gi...@git.apache.org> on 2016/04/11 20:05:20 UTC

[GitHub] flink pull request: [FLINK-3732] [Core] Potential null deference i...

GitHub user skyahead opened a pull request:

    https://github.com/apache/flink/pull/1871

    [FLINK-3732] [Core] Potential null deference in ExecutionConfig#equals()

    Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your changes.
    
    - [ ] General
      - The pull request references the related JIRA issue
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message
    
    - [ ] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [ ] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/skyahead/flink FLINK-3732

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1871.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1871
    
----
commit 4c9ea53502d95db619a0ce2f800132c1bf117303
Author: Tianji Li <ti...@alcatel-lucent.com>
Date:   2016-04-11T17:56:34Z

    [FLINK-3732] [Core] Potential null deference in ExecutionConfig#equals()

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3732] [Core] Potential null deference i...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/1871


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3732] [Core] Potential null deference i...

Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/1871#issuecomment-209062546
  
    Code looks good, but it triggers a checkstyle violation: indentation includes a space.
    Please have a look at the Travis CI logs...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3732] [Core] Potential null deference i...

Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/1871#issuecomment-209407499
  
    Looks good. Failed test seems to be a Scala compiler issue, not related to this pull request.
    
    Merging this...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---