You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2023/09/22 04:02:42 UTC
[GitHub] [spark] zhengruifeng opened a new pull request, #43045: [SPARK-45268][PYTHON][DOCS] python function categories should be consistent with SQL function groups
zhengruifeng opened a new pull request, #43045:
URL: https://github.com/apache/spark/pull/43045
### What changes were proposed in this pull request?
re-org python function categories
### Why are the changes needed?
should be consistent with SQL function groups
### Does this PR introduce _any_ user-facing change?
yes
### How was this patch tested?
manually check
### Was this patch authored or co-authored using generative AI tooling?
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #43045: [SPARK-45268][PYTHON][DOCS] python function categories should be consistent with SQL side
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #43045:
URL: https://github.com/apache/spark/pull/43045#issuecomment-1734897917
put `lambda functions` into `collection functions`, to be consistent with SQL references and Scala docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #43045: [SPARK-45268][PYTHON][DOCS] python function categories should be consistent with SQL function groups
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #43045:
URL: https://github.com/apache/spark/pull/43045#issuecomment-1730781367
cc @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #43045: [SPARK-45268][PYTHON][DOCS] python function categories should be consistent with SQL expression groups
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #43045:
URL: https://github.com/apache/spark/pull/43045#issuecomment-1730792686
This PR make categories follow expression descriptions, instead of `functions.scala`:
one major difference is that `lambda function` is in group `collect function` in `functions.scala`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #43045: [SPARK-45268][PYTHON][DOCS] python function categories should be consistent with SQL function groups
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #43045:
URL: https://github.com/apache/spark/pull/43045#issuecomment-1730775047
In `functions.py`, I think only the comments are incorrect, I guess we can leave it alone?
https://github.com/apache/spark/blob/c1dc9ae1c10e7c102407526e0ddc3d4b76d84119/python/pyspark/sql/functions.py#L11670
In `functions.scala`, I think we should correct the groups to be the same with expression groups
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #43045: [SPARK-45268][PYTHON][DOCS] python function categories should be consistent with SQL ExpressionDescriptions
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #43045:
URL: https://github.com/apache/spark/pull/43045#issuecomment-1730831739
Please hold off for a while, we may need to rename `lambda functions` which sounds too "technology"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng closed pull request #43045: [SPARK-45268][PYTHON][DOCS] python function categories should be consistent with SQL References
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #43045: [SPARK-45268][PYTHON][DOCS] python function categories should be consistent with SQL References
URL: https://github.com/apache/spark/pull/43045
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #43045: [SPARK-45268][PYTHON][DOCS] python function categories should be consistent with SQL References
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #43045:
URL: https://github.com/apache/spark/pull/43045#issuecomment-1736993254
thanks all for reviewing, merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org