[GitHub] [airflow] jedcunningham commented on a diff in pull request #29338: Fixed link to airflow variable in docs

["jedcunningham (via GitHub)" <gi...@apache.org>]

jedcunningham commented on code in PR #29338:
URL: https://github.com/apache/airflow/pull/29338#discussion_r1095220401


##########
docs/apache-airflow/howto/dynamic-dag-generation.rst:
##########
@@ -40,7 +40,7 @@ If you want to use variables to configure your code, you should always use
 `environment variables <https://wiki.archlinux.org/title/environment_variables>`_ in your
 top-level code rather than :doc:`Airflow Variables </core-concepts/variables>`. Using Airflow Variables
 at top-level code creates a connection to metadata DB of Airflow to fetch the value, which can slow

Review Comment:
   ```suggestion
   in top-level code creates a connection to the metadata DB of Airflow to fetch the value, which can slow
   ```



##########
docs/apache-airflow/howto/dynamic-dag-generation.rst:
##########
@@ -40,7 +40,7 @@ If you want to use variables to configure your code, you should always use
 `environment variables <https://wiki.archlinux.org/title/environment_variables>`_ in your
 top-level code rather than :doc:`Airflow Variables </core-concepts/variables>`. Using Airflow Variables
 at top-level code creates a connection to metadata DB of Airflow to fetch the value, which can slow
-down parsing and place extra load on the DB. See the `Airflow Variables <_best_practices/airflow_variables>`_
+down parsing and place extra load on the DB. See the :ref:`best_practices/airflow_variables`
 on how to make best use of Airflow Variables in your DAGs using Jinja templates .

Review Comment:
   ```suggestion
   down parsing and place extra load on the DB. See the `best practices on Airflow Variables <best_practices/airflow_variables>`_
   to make the best use of Airflow Variables in your DAGs using Jinja templates.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org