You are viewing a plain text version of this content. The canonical link for it is here.

Posted to java-dev@axis.apache.org by ax...@ws.apache.org on 2004/10/11 08:39:51 UTC

[jira] Created: (AXIS-1598) Generated Java artifacts name for Schema Anonymous type

Message:

A new issue has been created in JIRA.

---------------------------------------------------------------------
View the issue:
http://issues.apache.org/jira/browse/AXIS-1598

Here is an overview of the issue:
---------------------------------------------------------------------
Key: AXIS-1598
Summary: Generated Java artifacts name for Schema Anonymous type
Type: Improvement

Status: Unassigned
Priority: Major

Project: Axis
Components:
WSDL processing
Versions:
current (nightly)

Assignee:
Reporter: Jongjin Choi

Created: Sun, 10 Oct 2004 11:39 PM
Updated: Sun, 10 Oct 2004 11:39 PM

Description:
Dear all.

In the current version of Axis, the generated java artifacts
name for schema anonymous type begins with underscore.

For example, in the AddressBook.wsdl in the
ws-axis/java/test/wsdl/addrNoImplSEI directory,

<xsd:element name="Phone">
<xsd:complexType>
<xsd:all>
<xsd:element name="areaCode" type="xsd:int"/>
<xsd:element name="exchange" type="xsd:string"/>
<xsd:element name="number" type="xsd:string/>
</xsd:all>
</xsd:complexType>
</xsd:element>

The generated Java artifact for the element's complex type is
'_phone.java'.

This convention may confuse the user because it does not
follow general java naming rule.
It would be better if the generated arftifact name is
'Phone.java' instead of '_phone.java' in this case.

The JSR-109 introduces the new QName scheme for anonymous type.
Currently Axis makes a Java name from the QName by replacing '>' with '_'.
I think that java name can be derived from the QName by using
empty string instead of '_' and making the character
following '>' as upper case.

For example, the QName and its derived java name should be like these:
QName --> java name

X:>root --> Root
X:>root>inside --> RootInside ('I' is also upper case)

If name collision occurs, it will be resolved in the
resolveNameClashes() method of JavaGeneratorFactory.

It seems that the JAX-RPC 1.1 is not clear for this. But the
SUN's JWSDP works the way I said.

I have fixed this in my local axis copy and passed all-tests with some modification for generated artifacts name
to the test cases for wsdl (ws-axis/java/test/wsdl/).

I know that it will break existing application using Axis.
But the change will provide the users with more friendly
names, compatibility with other JAX-RPC runtime and less confusion.

---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira

[jira] Updated: (AXIS-1598) Generated Java artifacts name for Schema Anonymous type

Posted by ax...@ws.apache.org.

The following issue has been updated:

    Updater: Jongjin Choi (mailto:gunsnroz@hotmail.com)
       Date: Sun, 10 Oct 2004 11:40 PM
    Comment:
diff for ws-axis/java/test/wsdl
    Changes:
             Attachment changed to diff-tests.txt
    ---------------------------------------------------------------------
For a full history of the issue, see:

  http://issues.apache.org/jira/browse/AXIS-1598?page=history

---------------------------------------------------------------------
View the issue:
  http://issues.apache.org/jira/browse/AXIS-1598

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: AXIS-1598
    Summary: Generated Java artifacts name for Schema Anonymous type
       Type: Improvement

     Status: Unassigned
   Priority: Major

    Project: Axis
 Components: 
             WSDL processing
   Versions:
             current (nightly)

   Assignee: 
   Reporter: Jongjin Choi

    Created: Sun, 10 Oct 2004 11:39 PM
    Updated: Sun, 10 Oct 2004 11:40 PM

Description:
Dear all. 

In the current version of Axis, the generated java artifacts 
name for schema anonymous type begins with underscore. 
 
For example, in the AddressBook.wsdl in the 
ws-axis/java/test/wsdl/addrNoImplSEI directory, 
 
 <xsd:element name="Phone"> 
    <xsd:complexType> 
       <xsd:all> 
            <xsd:element name="areaCode" type="xsd:int"/> 
            <xsd:element name="exchange" type="xsd:string"/> 
            <xsd:element name="number" type="xsd:string/> 
       </xsd:all> 
    </xsd:complexType> 
 </xsd:element> 
 
The generated Java artifact for the element's complex type is 
'_phone.java'. 
 
This convention may confuse the user because it does not 
follow general java naming rule. 
It would be better if the generated arftifact name is 
'Phone.java' instead of '_phone.java' in this case. 
 
The JSR-109 introduces the new QName scheme for anonymous type. 
Currently Axis makes a Java name from the QName by replacing '>' with '_'. 
I think that java name can be derived from the QName by using 
empty string instead of '_' and making the character 
following '>' as upper case. 
 
For example, the QName and its derived java name should be like these: 
 QName --> java name 
 
 X:>root   --> Root 
 X:>root>inside --> RootInside   ('I' is also upper case) 
 
If name collision occurs, it will be resolved in the 
resolveNameClashes() method of JavaGeneratorFactory. 
 
It seems that the JAX-RPC 1.1 is not clear for this. But the 
SUN's JWSDP works the way I said. 
 
I have fixed this in my local axis copy and passed all-tests with some modification for generated artifacts name 
to the test cases for wsdl (ws-axis/java/test/wsdl/). 
 
I know that it will break existing application using Axis. 
But the change will provide the users with more friendly 
names, compatibility with other JAX-RPC runtime and less confusion. 




---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira

[jira] Closed: (AXIS-1598) Generated Java artifacts name for Schema Anonymous type

Posted by ax...@ws.apache.org.

Message:

The following issue has been closed.

Resolver: Ias
Date: Fri, 15 Oct 2004 9:50 AM

All the patches applied. Thanks, Jongjin.
---------------------------------------------------------------------
View the issue:
http://issues.apache.org/jira/browse/AXIS-1598

Status: Closed
Priority: Major
Resolution: FIXED

Project: Axis
Components:
WSDL processing
Fix Fors:
current (nightly)
Versions:
current (nightly)

Assignee: Ias
Reporter: Jongjin Choi

Created: Sun, 10 Oct 2004 11:39 PM
Updated: Fri, 15 Oct 2004 9:50 AM