[jira] Commented: (TRINIDAD-1994) remove unused @locale selectors to improve skinning performance

["Jeanne Waldman (JIRA)" <de...@myfaces.apache.org>]

    [ https://issues.apache.org/jira/browse/TRINIDAD-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12978106#action_12978106 ] 

Jeanne Waldman commented on TRINIDAD-1994:
------------------------------------------

It turns out that we have @locale th, zh_CN, etc selectors that are necessary, so removing these aliases will not reduce the number of stylesheetnodes. It is still nice to remove these since they are not being used.

> remove unused @locale selectors to improve skinning performance
> ---------------------------------------------------------------
>
>                 Key: TRINIDAD-1994
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-1994
>             Project: MyFaces Trinidad
>          Issue Type: Improvement
>          Components: Skinning
>            Reporter: Jeanne Waldman
>
> This is related to TRINIDAD-1985 High live memory usage from SkinStyleProvider
> The fewer @locale selectors we have, the fewer specialized StyleSheetNodes we have, and thus the fewer generated css files we will create.
> remove selectors that have @locale blocks if they are not being used.
> e.g., 
> /** Style sheet just for Korean-specific styles **/
> @locale ko{
>   /** Button padding for Albany WT K **/
>   .ButtonServerPaddingAlbany WT K:alias {
>     -tr-rule-ref: selector(".AlbanyButtonPadding:alias");
>   }
> }
> .DefaultServerFontFamily:alias
> /** Style sheet just for Traditional Chinese specific styles **/
> @locale zh_TW{
>   /** Button padding for Albany WT TC **/
>   .ButtonServerPaddingAlbany WT TC:alias {
>     -tr-rule-ref: selector(".AlbanyButtonPadding:alias");
>   }
> }
> /** Style sheet just for Simplified Chinese specific styles **/
> @locale zh_CN{
>   /** Button padding for Albany WT SC **/
>   .ButtonServerPaddingAlbany WT SC:alias {
>     -tr-rule-ref: selector(".AlbanyButtonPadding:alias");
>   }
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.