You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/22 16:22:01 UTC
[GitHub] [flink] matriv opened a new pull request #17550: [FLINK-24599][table] Replace static methods with member methods
matriv opened a new pull request #17550:
URL: https://github.com/apache/flink/pull/17550
Make the code of calling `hasRoot`/`hasFamily` less verbose by
replacing the static utility methods with member methods
`LogicalType#is()`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: yes
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17550: [FLINK-24599][table] Replace static methods with member methods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17550:
URL: https://github.com/apache/flink/pull/17550#issuecomment-949779530
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "66c9ead84d9309bce59c77d12a913bd3471edec1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25378",
"triggerID" : "66c9ead84d9309bce59c77d12a913bd3471edec1",
"triggerType" : "PUSH"
}, {
"hash" : "42654639404e713c482245aa77474c731a918ad4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25423",
"triggerID" : "42654639404e713c482245aa77474c731a918ad4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 66c9ead84d9309bce59c77d12a913bd3471edec1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25378)
* 42654639404e713c482245aa77474c731a918ad4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25423)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] matriv commented on a change in pull request #17550: [FLINK-24599][table] Replace static methods with member methods
Posted by GitBox <gi...@apache.org>.
matriv commented on a change in pull request #17550:
URL: https://github.com/apache/flink/pull/17550#discussion_r735338182
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/logical/LogicalType.java
##########
@@ -77,6 +77,33 @@ public LogicalTypeRoot getTypeRoot() {
return typeRoot;
}
+ /**
+ * Returns whether the root of the type equals to the {@code typeRoot} or not.
+ *
+ * @param typeRoot The root type to check against for equality
+ */
+ public boolean is(LogicalTypeRoot typeRoot) {
+ return this.typeRoot == typeRoot;
+ }
+
+ /**
+ * Returns whether the root of the type equals to at least on of the {@code typeRoots} or not.
+ *
+ * @param typeRoots The root types to check against for equality
+ */
+ public boolean isAnyOf(LogicalTypeRoot... typeRoots) {
+ return Arrays.stream(typeRoots).anyMatch(tr -> this.typeRoot == tr);
+ }
+
+ /**
+ * Returns whether the family type of the type equals to the {@code family} or not.
+ *
+ * @param family The family type to check against for equality
+ */
+ public boolean is(LogicalTypeFamily family) {
Review comment:
I don't have a strong opinion here, I kind of like the more simplistic `is` or maybe `isOf` but: `is` is already defined, and this is an overload, to me is totally fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17550: [FLINK-24599][table] Replace static methods with member methods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17550:
URL: https://github.com/apache/flink/pull/17550#issuecomment-949779530
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "66c9ead84d9309bce59c77d12a913bd3471edec1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25378",
"triggerID" : "66c9ead84d9309bce59c77d12a913bd3471edec1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 66c9ead84d9309bce59c77d12a913bd3471edec1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25378)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17550: [FLINK-24599][table] Replace static methods with member methods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17550:
URL: https://github.com/apache/flink/pull/17550#issuecomment-949779530
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "66c9ead84d9309bce59c77d12a913bd3471edec1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25378",
"triggerID" : "66c9ead84d9309bce59c77d12a913bd3471edec1",
"triggerType" : "PUSH"
}, {
"hash" : "42654639404e713c482245aa77474c731a918ad4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25423",
"triggerID" : "42654639404e713c482245aa77474c731a918ad4",
"triggerType" : "PUSH"
}, {
"hash" : "220fcb4c0756aa76684923447db7983457b353a5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "220fcb4c0756aa76684923447db7983457b353a5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 66c9ead84d9309bce59c77d12a913bd3471edec1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25378)
* 42654639404e713c482245aa77474c731a918ad4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25423)
* 220fcb4c0756aa76684923447db7983457b353a5 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17550: [FLINK-24599][table] Replace static methods with member methods
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17550:
URL: https://github.com/apache/flink/pull/17550#issuecomment-949779530
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "66c9ead84d9309bce59c77d12a913bd3471edec1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "66c9ead84d9309bce59c77d12a913bd3471edec1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 66c9ead84d9309bce59c77d12a913bd3471edec1 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17550: [FLINK-24599][table] Replace static methods with member methods
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17550:
URL: https://github.com/apache/flink/pull/17550#issuecomment-949780576
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 66c9ead84d9309bce59c77d12a913bd3471edec1 (Fri Oct 22 16:25:03 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] matriv commented on a change in pull request #17550: [FLINK-24599][table] Replace static methods with member methods
Posted by GitBox <gi...@apache.org>.
matriv commented on a change in pull request #17550:
URL: https://github.com/apache/flink/pull/17550#discussion_r735339080
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/logical/LogicalType.java
##########
@@ -77,6 +77,33 @@ public LogicalTypeRoot getTypeRoot() {
return typeRoot;
}
+ /**
+ * Returns whether the root of the type equals to the {@code typeRoot} or not.
+ *
+ * @param typeRoot The root type to check against for equality
+ */
+ public boolean is(LogicalTypeRoot typeRoot) {
+ return this.typeRoot == typeRoot;
+ }
+
+ /**
+ * Returns whether the root of the type equals to at least on of the {@code typeRoots} or not.
+ *
+ * @param typeRoots The root types to check against for equality
+ */
+ public boolean isAnyOf(LogicalTypeRoot... typeRoots) {
+ return Arrays.stream(typeRoots).anyMatch(tr -> this.typeRoot == tr);
+ }
+
+ /**
+ * Returns whether the family type of the type equals to the {@code family} or not.
+ *
+ * @param family The family type to check against for equality
+ */
+ public boolean is(LogicalTypeFamily family) {
Review comment:
@twalthr What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr closed pull request #17550: [FLINK-24599][table] Replace static methods with member methods
Posted by GitBox <gi...@apache.org>.
twalthr closed pull request #17550:
URL: https://github.com/apache/flink/pull/17550
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] matriv commented on pull request #17550: [FLINK-24599][table] Replace static methods with member methods
Posted by GitBox <gi...@apache.org>.
matriv commented on pull request #17550:
URL: https://github.com/apache/flink/pull/17550#issuecomment-950626529
> Does it makes sense for you to push `is(LogicalTypeFamily)` method inside `LogicalTypeRoot` and then have it `LogicalType` as well?
The point of the ticket and PR is to move those methods as member methods and have them on the LogicalType which is always what we have at hand, and want to check to which LogicalTypeRoot or LogicalTypeFamily it belongs to. If we move the method inside LogicalTypeFamily then we'd have calls like: `LogicalTypeFamily.NUMERIC.is(myType)` which IMHO is slightly more weird than the inverse, considering also that `LogicalTypeFamily` is an enum and not a class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on a change in pull request #17550: [FLINK-24599][table] Replace static methods with member methods
Posted by GitBox <gi...@apache.org>.
twalthr commented on a change in pull request #17550:
URL: https://github.com/apache/flink/pull/17550#discussion_r735604158
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/logical/LogicalType.java
##########
@@ -77,6 +77,33 @@ public LogicalTypeRoot getTypeRoot() {
return typeRoot;
}
+ /**
+ * Returns whether the root of the type equals to the {@code typeRoot} or not.
+ *
+ * @param typeRoot The root type to check against for equality
+ */
+ public boolean is(LogicalTypeRoot typeRoot) {
+ return this.typeRoot == typeRoot;
+ }
+
+ /**
+ * Returns whether the root of the type equals to at least on of the {@code typeRoots} or not.
+ *
+ * @param typeRoots The root types to check against for equality
+ */
+ public boolean isAnyOf(LogicalTypeRoot... typeRoots) {
+ return Arrays.stream(typeRoots).anyMatch(tr -> this.typeRoot == tr);
+ }
+
+ /**
+ * Returns whether the family type of the type equals to the {@code family} or not.
+ *
+ * @param family The family type to check against for equality
+ */
+ public boolean is(LogicalTypeFamily family) {
Review comment:
btw while reviewing the code: actually `is(LogicalTypeFamily.TIMESTAMP)` reads nicely because the enum is always prefixes with `LogicalTypeFamily` any way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17550: [FLINK-24599][table] Replace static methods with member methods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17550:
URL: https://github.com/apache/flink/pull/17550#issuecomment-949779530
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "66c9ead84d9309bce59c77d12a913bd3471edec1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25378",
"triggerID" : "66c9ead84d9309bce59c77d12a913bd3471edec1",
"triggerType" : "PUSH"
}, {
"hash" : "42654639404e713c482245aa77474c731a918ad4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25423",
"triggerID" : "42654639404e713c482245aa77474c731a918ad4",
"triggerType" : "PUSH"
}, {
"hash" : "220fcb4c0756aa76684923447db7983457b353a5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25429",
"triggerID" : "220fcb4c0756aa76684923447db7983457b353a5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 66c9ead84d9309bce59c77d12a913bd3471edec1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25378)
* 42654639404e713c482245aa77474c731a918ad4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25423)
* 220fcb4c0756aa76684923447db7983457b353a5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25429)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17550: [FLINK-24599][table] Replace static methods with member methods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17550:
URL: https://github.com/apache/flink/pull/17550#issuecomment-949779530
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "66c9ead84d9309bce59c77d12a913bd3471edec1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25378",
"triggerID" : "66c9ead84d9309bce59c77d12a913bd3471edec1",
"triggerType" : "PUSH"
}, {
"hash" : "42654639404e713c482245aa77474c731a918ad4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25423",
"triggerID" : "42654639404e713c482245aa77474c731a918ad4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 66c9ead84d9309bce59c77d12a913bd3471edec1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25378)
* 42654639404e713c482245aa77474c731a918ad4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25423)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17550: [FLINK-24599][table] Replace static methods with member methods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17550:
URL: https://github.com/apache/flink/pull/17550#issuecomment-949779530
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "66c9ead84d9309bce59c77d12a913bd3471edec1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25378",
"triggerID" : "66c9ead84d9309bce59c77d12a913bd3471edec1",
"triggerType" : "PUSH"
}, {
"hash" : "42654639404e713c482245aa77474c731a918ad4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25423",
"triggerID" : "42654639404e713c482245aa77474c731a918ad4",
"triggerType" : "PUSH"
}, {
"hash" : "220fcb4c0756aa76684923447db7983457b353a5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "220fcb4c0756aa76684923447db7983457b353a5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 66c9ead84d9309bce59c77d12a913bd3471edec1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25378)
* 42654639404e713c482245aa77474c731a918ad4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25423)
* 220fcb4c0756aa76684923447db7983457b353a5 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17550: [FLINK-24599][table] Replace static methods with member methods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17550:
URL: https://github.com/apache/flink/pull/17550#issuecomment-949779530
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "66c9ead84d9309bce59c77d12a913bd3471edec1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25378",
"triggerID" : "66c9ead84d9309bce59c77d12a913bd3471edec1",
"triggerType" : "PUSH"
}, {
"hash" : "42654639404e713c482245aa77474c731a918ad4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "42654639404e713c482245aa77474c731a918ad4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 66c9ead84d9309bce59c77d12a913bd3471edec1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25378)
* 42654639404e713c482245aa77474c731a918ad4 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17550: [FLINK-24599][table] Replace static methods with member methods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17550:
URL: https://github.com/apache/flink/pull/17550#issuecomment-949779530
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "66c9ead84d9309bce59c77d12a913bd3471edec1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25378",
"triggerID" : "66c9ead84d9309bce59c77d12a913bd3471edec1",
"triggerType" : "PUSH"
}, {
"hash" : "42654639404e713c482245aa77474c731a918ad4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25423",
"triggerID" : "42654639404e713c482245aa77474c731a918ad4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 66c9ead84d9309bce59c77d12a913bd3471edec1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25378)
* 42654639404e713c482245aa77474c731a918ad4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25423)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17550: [FLINK-24599][table] Replace static methods with member methods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17550:
URL: https://github.com/apache/flink/pull/17550#issuecomment-949779530
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "66c9ead84d9309bce59c77d12a913bd3471edec1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25378",
"triggerID" : "66c9ead84d9309bce59c77d12a913bd3471edec1",
"triggerType" : "PUSH"
}, {
"hash" : "42654639404e713c482245aa77474c731a918ad4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25423",
"triggerID" : "42654639404e713c482245aa77474c731a918ad4",
"triggerType" : "PUSH"
}, {
"hash" : "220fcb4c0756aa76684923447db7983457b353a5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "220fcb4c0756aa76684923447db7983457b353a5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 66c9ead84d9309bce59c77d12a913bd3471edec1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25378)
* 42654639404e713c482245aa77474c731a918ad4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25423)
* 220fcb4c0756aa76684923447db7983457b353a5 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17550: [FLINK-24599][table] Replace static methods with member methods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17550:
URL: https://github.com/apache/flink/pull/17550#issuecomment-949779530
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "66c9ead84d9309bce59c77d12a913bd3471edec1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25378",
"triggerID" : "66c9ead84d9309bce59c77d12a913bd3471edec1",
"triggerType" : "PUSH"
}, {
"hash" : "42654639404e713c482245aa77474c731a918ad4",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25423",
"triggerID" : "42654639404e713c482245aa77474c731a918ad4",
"triggerType" : "PUSH"
}, {
"hash" : "220fcb4c0756aa76684923447db7983457b353a5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25429",
"triggerID" : "220fcb4c0756aa76684923447db7983457b353a5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 42654639404e713c482245aa77474c731a918ad4 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25423)
* 220fcb4c0756aa76684923447db7983457b353a5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25429)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17550: [FLINK-24599][table] Replace static methods with member methods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17550:
URL: https://github.com/apache/flink/pull/17550#issuecomment-949779530
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "66c9ead84d9309bce59c77d12a913bd3471edec1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25378",
"triggerID" : "66c9ead84d9309bce59c77d12a913bd3471edec1",
"triggerType" : "PUSH"
}, {
"hash" : "42654639404e713c482245aa77474c731a918ad4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25423",
"triggerID" : "42654639404e713c482245aa77474c731a918ad4",
"triggerType" : "PUSH"
}, {
"hash" : "220fcb4c0756aa76684923447db7983457b353a5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "220fcb4c0756aa76684923447db7983457b353a5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 66c9ead84d9309bce59c77d12a913bd3471edec1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25378)
* 42654639404e713c482245aa77474c731a918ad4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25423)
* 220fcb4c0756aa76684923447db7983457b353a5 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17550: [FLINK-24599][table] Replace static methods with member methods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17550:
URL: https://github.com/apache/flink/pull/17550#issuecomment-949779530
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "66c9ead84d9309bce59c77d12a913bd3471edec1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25378",
"triggerID" : "66c9ead84d9309bce59c77d12a913bd3471edec1",
"triggerType" : "PUSH"
}, {
"hash" : "42654639404e713c482245aa77474c731a918ad4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25423",
"triggerID" : "42654639404e713c482245aa77474c731a918ad4",
"triggerType" : "PUSH"
}, {
"hash" : "220fcb4c0756aa76684923447db7983457b353a5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "220fcb4c0756aa76684923447db7983457b353a5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 66c9ead84d9309bce59c77d12a913bd3471edec1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25378)
* 42654639404e713c482245aa77474c731a918ad4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25423)
* 220fcb4c0756aa76684923447db7983457b353a5 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17550: [FLINK-24599][table] Replace static methods with member methods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17550:
URL: https://github.com/apache/flink/pull/17550#issuecomment-949779530
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "66c9ead84d9309bce59c77d12a913bd3471edec1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25378",
"triggerID" : "66c9ead84d9309bce59c77d12a913bd3471edec1",
"triggerType" : "PUSH"
}, {
"hash" : "42654639404e713c482245aa77474c731a918ad4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25423",
"triggerID" : "42654639404e713c482245aa77474c731a918ad4",
"triggerType" : "PUSH"
}, {
"hash" : "220fcb4c0756aa76684923447db7983457b353a5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "220fcb4c0756aa76684923447db7983457b353a5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 66c9ead84d9309bce59c77d12a913bd3471edec1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25378)
* 42654639404e713c482245aa77474c731a918ad4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25423)
* 220fcb4c0756aa76684923447db7983457b353a5 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on a change in pull request #17550: [FLINK-24599][table] Replace static methods with member methods
Posted by GitBox <gi...@apache.org>.
twalthr commented on a change in pull request #17550:
URL: https://github.com/apache/flink/pull/17550#discussion_r735605118
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/logical/utils/LogicalTypeCasts.java
##########
@@ -500,8 +497,7 @@ public Boolean visit(VarCharType targetType) {
return false;
}
// CHAR and VARCHAR are very compatible within bounds
- if ((hasRoot(sourceType, LogicalTypeRoot.CHAR)
- || hasRoot(sourceType, LogicalTypeRoot.VARCHAR))
+ if ((sourceType.isAnyOf(LogicalTypeRoot.CHAR, LogicalTypeRoot.VARCHAR))
Review comment:
redundant parenthesis
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/logical/utils/LogicalTypeCasts.java
##########
@@ -514,8 +510,7 @@ public Boolean visit(VarBinaryType targetType) {
return false;
}
// BINARY and VARBINARY are very compatible within bounds
- if ((hasRoot(sourceType, LogicalTypeRoot.BINARY)
- || hasRoot(sourceType, LogicalTypeRoot.VARBINARY))
+ if ((sourceType.isAnyOf(LogicalTypeRoot.BINARY, LogicalTypeRoot.VARBINARY))
Review comment:
redundant parenthesis
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on a change in pull request #17550: [FLINK-24599][table] Replace static methods with member methods
Posted by GitBox <gi...@apache.org>.
twalthr commented on a change in pull request #17550:
URL: https://github.com/apache/flink/pull/17550#discussion_r735597583
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/logical/LogicalType.java
##########
@@ -77,6 +77,33 @@ public LogicalTypeRoot getTypeRoot() {
return typeRoot;
}
+ /**
+ * Returns whether the root of the type equals to the {@code typeRoot} or not.
+ *
+ * @param typeRoot The root type to check against for equality
+ */
+ public boolean is(LogicalTypeRoot typeRoot) {
+ return this.typeRoot == typeRoot;
+ }
+
+ /**
+ * Returns whether the root of the type equals to at least on of the {@code typeRoots} or not.
+ *
+ * @param typeRoots The root types to check against for equality
+ */
+ public boolean isAnyOf(LogicalTypeRoot... typeRoots) {
+ return Arrays.stream(typeRoots).anyMatch(tr -> this.typeRoot == tr);
+ }
+
+ /**
+ * Returns whether the family type of the type equals to the {@code family} or not.
+ *
+ * @param family The family type to check against for equality
+ */
+ public boolean is(LogicalTypeFamily family) {
Review comment:
The root and family names have been designed to be statically important concurrently. We should keep frequently used methods as short as possible since everyone knows what they are doing. `type.is(NUMERIC)` or `type.is(CHARACTER_STRING)` reads nicer than `type.isFamily(NUMERIC)`. But this is just my personal opinion. In `InputTypeStrategies#logical()` we also just treat them equal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slinkydeveloper commented on a change in pull request #17550: [FLINK-24599][table] Replace static methods with member methods
Posted by GitBox <gi...@apache.org>.
slinkydeveloper commented on a change in pull request #17550:
URL: https://github.com/apache/flink/pull/17550#discussion_r735307913
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/logical/LogicalType.java
##########
@@ -77,6 +77,33 @@ public LogicalTypeRoot getTypeRoot() {
return typeRoot;
}
+ /**
+ * Returns whether the root of the type equals to the {@code typeRoot} or not.
+ *
+ * @param typeRoot The root type to check against for equality
+ */
+ public boolean is(LogicalTypeRoot typeRoot) {
+ return this.typeRoot == typeRoot;
+ }
+
+ /**
+ * Returns whether the root of the type equals to at least on of the {@code typeRoots} or not.
+ *
+ * @param typeRoots The root types to check against for equality
+ */
+ public boolean isAnyOf(LogicalTypeRoot... typeRoots) {
+ return Arrays.stream(typeRoots).anyMatch(tr -> this.typeRoot == tr);
+ }
+
+ /**
+ * Returns whether the family type of the type equals to the {@code family} or not.
+ *
+ * @param family The family type to check against for equality
+ */
+ public boolean is(LogicalTypeFamily family) {
Review comment:
Naming this method `is` seems not correct to me, for two reasons: family is a set, and also `is` is already defined with `typeRoot` argument. Perhaps `isFamily` is better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17550: [FLINK-24599][table] Replace static methods with member methods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17550:
URL: https://github.com/apache/flink/pull/17550#issuecomment-949779530
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "66c9ead84d9309bce59c77d12a913bd3471edec1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25378",
"triggerID" : "66c9ead84d9309bce59c77d12a913bd3471edec1",
"triggerType" : "PUSH"
}, {
"hash" : "42654639404e713c482245aa77474c731a918ad4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25423",
"triggerID" : "42654639404e713c482245aa77474c731a918ad4",
"triggerType" : "PUSH"
}, {
"hash" : "220fcb4c0756aa76684923447db7983457b353a5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "220fcb4c0756aa76684923447db7983457b353a5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 66c9ead84d9309bce59c77d12a913bd3471edec1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25378)
* 42654639404e713c482245aa77474c731a918ad4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25423)
* 220fcb4c0756aa76684923447db7983457b353a5 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17550: [FLINK-24599][table] Replace static methods with member methods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17550:
URL: https://github.com/apache/flink/pull/17550#issuecomment-949779530
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "66c9ead84d9309bce59c77d12a913bd3471edec1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25378",
"triggerID" : "66c9ead84d9309bce59c77d12a913bd3471edec1",
"triggerType" : "PUSH"
}, {
"hash" : "42654639404e713c482245aa77474c731a918ad4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25423",
"triggerID" : "42654639404e713c482245aa77474c731a918ad4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 66c9ead84d9309bce59c77d12a913bd3471edec1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25378)
* 42654639404e713c482245aa77474c731a918ad4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25423)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17550: [FLINK-24599][table] Replace static methods with member methods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17550:
URL: https://github.com/apache/flink/pull/17550#issuecomment-949779530
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "66c9ead84d9309bce59c77d12a913bd3471edec1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25378",
"triggerID" : "66c9ead84d9309bce59c77d12a913bd3471edec1",
"triggerType" : "PUSH"
}, {
"hash" : "42654639404e713c482245aa77474c731a918ad4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25423",
"triggerID" : "42654639404e713c482245aa77474c731a918ad4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 66c9ead84d9309bce59c77d12a913bd3471edec1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25378)
* 42654639404e713c482245aa77474c731a918ad4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25423)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17550: [FLINK-24599][table] Replace static methods with member methods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17550:
URL: https://github.com/apache/flink/pull/17550#issuecomment-949779530
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "66c9ead84d9309bce59c77d12a913bd3471edec1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25378",
"triggerID" : "66c9ead84d9309bce59c77d12a913bd3471edec1",
"triggerType" : "PUSH"
}, {
"hash" : "42654639404e713c482245aa77474c731a918ad4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25423",
"triggerID" : "42654639404e713c482245aa77474c731a918ad4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 66c9ead84d9309bce59c77d12a913bd3471edec1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25378)
* 42654639404e713c482245aa77474c731a918ad4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25423)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17550: [FLINK-24599][table] Replace static methods with member methods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17550:
URL: https://github.com/apache/flink/pull/17550#issuecomment-949779530
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "66c9ead84d9309bce59c77d12a913bd3471edec1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25378",
"triggerID" : "66c9ead84d9309bce59c77d12a913bd3471edec1",
"triggerType" : "PUSH"
}, {
"hash" : "42654639404e713c482245aa77474c731a918ad4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25423",
"triggerID" : "42654639404e713c482245aa77474c731a918ad4",
"triggerType" : "PUSH"
}, {
"hash" : "220fcb4c0756aa76684923447db7983457b353a5",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25429",
"triggerID" : "220fcb4c0756aa76684923447db7983457b353a5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 220fcb4c0756aa76684923447db7983457b353a5 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25429)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17550: [FLINK-24599][table] Replace static methods with member methods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17550:
URL: https://github.com/apache/flink/pull/17550#issuecomment-949779530
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "66c9ead84d9309bce59c77d12a913bd3471edec1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25378",
"triggerID" : "66c9ead84d9309bce59c77d12a913bd3471edec1",
"triggerType" : "PUSH"
}, {
"hash" : "42654639404e713c482245aa77474c731a918ad4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25423",
"triggerID" : "42654639404e713c482245aa77474c731a918ad4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 66c9ead84d9309bce59c77d12a913bd3471edec1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25378)
* 42654639404e713c482245aa77474c731a918ad4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25423)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17550: [FLINK-24599][table] Replace static methods with member methods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17550:
URL: https://github.com/apache/flink/pull/17550#issuecomment-949779530
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "66c9ead84d9309bce59c77d12a913bd3471edec1",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25378",
"triggerID" : "66c9ead84d9309bce59c77d12a913bd3471edec1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 66c9ead84d9309bce59c77d12a913bd3471edec1 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25378)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17550: [FLINK-24599][table] Replace static methods with member methods
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17550:
URL: https://github.com/apache/flink/pull/17550#issuecomment-949779530
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "66c9ead84d9309bce59c77d12a913bd3471edec1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25378",
"triggerID" : "66c9ead84d9309bce59c77d12a913bd3471edec1",
"triggerType" : "PUSH"
}, {
"hash" : "42654639404e713c482245aa77474c731a918ad4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25423",
"triggerID" : "42654639404e713c482245aa77474c731a918ad4",
"triggerType" : "PUSH"
}, {
"hash" : "220fcb4c0756aa76684923447db7983457b353a5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "220fcb4c0756aa76684923447db7983457b353a5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 66c9ead84d9309bce59c77d12a913bd3471edec1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25378)
* 42654639404e713c482245aa77474c731a918ad4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25423)
* 220fcb4c0756aa76684923447db7983457b353a5 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org