You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/04/06 06:01:10 UTC
[GitHub] [pulsar] michaeljmarshall commented on a change in pull request #10130: Reduce redundant logs on Producer/Consumer create/close operations
michaeljmarshall commented on a change in pull request #10130:
URL: https://github.com/apache/pulsar/pull/10130#discussion_r607527079
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java
##########
@@ -1208,11 +1208,11 @@ protected void handleProducer(final CommandProducer cmdProducer) {
}
} else {
producer.closeNow(true);
- log.info("[{}] Cleared producer created after connection was closed: {}",
- remoteAddress, producer);
- producerFuture.completeExceptionally(
- new IllegalStateException(
- "Producer created after connection was closed"));
+ log.info("[{}] Cleared producer created after connection was closed: {}",
Review comment:
This is only adjusting the whitespace, not the log level.
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java
##########
@@ -1193,7 +1193,7 @@ protected void handleProducer(final CommandProducer cmdProducer) {
topic.addProducer(producer, producerQueuedFuture).thenAccept(newTopicEpoch -> {
if (isActive()) {
if (producerFuture.complete(producer)) {
- log.info("[{}] Created new producer: {}", remoteAddress, producer);
+ log.debug("[{}] Created new producer: {}", remoteAddress, producer);
Review comment:
@merlimat - by itself, it might not appear redundant, but when considered against a line shortly before it where we log `Creating producer`, I think it should be considered redundant.
https://github.com/apache/pulsar/blob/fa68cb20b5dab17732cdfebef353145c753c4533/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java#L1138
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org