You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/09/10 15:01:48 UTC
[GitHub] [hadoop-ozone] elek opened a new pull request #1416: HDDS-4233. Interrupted exeception printed out from DatanodeStateMachine
elek opened a new pull request #1416:
URL: https://github.com/apache/hadoop-ozone/pull/1416
## What changes were proposed in this pull request?
Hide Interrupted exceptions from WARN level as they are expected.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4233
## How was this patch tested?
CI. Simple change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek commented on a change in pull request #1416: HDDS-4233. Interrupted exeception printed out from DatanodeStateMachine
Posted by GitBox <gi...@apache.org>.
elek commented on a change in pull request #1416:
URL: https://github.com/apache/hadoop-ozone/pull/1416#discussion_r490755304
##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeStateMachine.java
##########
@@ -242,7 +241,7 @@ private void start() throws IOException {
try {
Thread.sleep(nextHB.get() - now);
} catch (InterruptedException e) {
- LOG.warn("Interrupt the execution.", e);
+ //triggerHeartbeat is called during the sleep
Review comment:
Good question. Based on my understanding the interrupt is intentional (when DN would like to send out a HB immediately)
```java
/**
* Calling this will immediately trigger a heartbeat to the SCMs.
* This heartbeat will also include all the reports which are ready to
* be sent by datanode.
*/
public void triggerHeartbeat() {
if (stateMachineThread != null) {
stateMachineThread.interrupt();
}
}
```
I think it's expected to interrupt the thread, therefore we need to hide the exception.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai merged pull request #1416: HDDS-4233. Interrupted exeception printed out from DatanodeStateMachine
Posted by GitBox <gi...@apache.org>.
adoroszlai merged pull request #1416:
URL: https://github.com/apache/hadoop-ozone/pull/1416
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] amaliujia commented on a change in pull request #1416: HDDS-4233. Interrupted exeception printed out from DatanodeStateMachine
Posted by GitBox <gi...@apache.org>.
amaliujia commented on a change in pull request #1416:
URL: https://github.com/apache/hadoop-ozone/pull/1416#discussion_r486500932
##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeStateMachine.java
##########
@@ -242,7 +241,7 @@ private void start() throws IOException {
try {
Thread.sleep(nextHB.get() - now);
} catch (InterruptedException e) {
- LOG.warn("Interrupt the execution.", e);
+ //triggerHeartbeat is called during the sleep
Review comment:
Hmm I might misunderstand this: will then the InterruptedException silently be hidden? If so is this expected behavior?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] amaliujia commented on a change in pull request #1416: HDDS-4233. Interrupted exeception printed out from DatanodeStateMachine
Posted by GitBox <gi...@apache.org>.
amaliujia commented on a change in pull request #1416:
URL: https://github.com/apache/hadoop-ozone/pull/1416#discussion_r491096229
##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeStateMachine.java
##########
@@ -242,7 +241,7 @@ private void start() throws IOException {
try {
Thread.sleep(nextHB.get() - now);
} catch (InterruptedException e) {
- LOG.warn("Interrupt the execution.", e);
+ //triggerHeartbeat is called during the sleep
Review comment:
Got it! Thanks for your clarification.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org