You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by Carl Hall <ca...@hallwaytech.com> on 2012/01/03 15:05:05 UTC
Looking around
Hi Rave devs,
I'm Carl Hall and I'm a codeaholic. I met a few of you at ApacheCon in
Vancouver last year. My day job is on the Sakai Project and I'm a committer
to Apache Sling. I spend most of my time with Apache Sling (Apache Felix
[OSGi], Apache JackRabbit [JCR]) but I have some history with Spring and
OpenSocial[1].
I started looking through the Rave source a few weeks ago and found some
time yesterday to dig into a few issues. As Matt noted on RAVE-374, patches
are normally posted to reviews.apache.org. Before I create more noise, are
there other patch contribution steps I should follow? Are there particular
issues that anyone would prefer I work on?
Thanks,
Carl
1 https://github.com/thecarlhall/dancehall
Re: Looking around
Posted by Jasha Joachimsthal <j....@onehippo.com>.
Thanks Ross for correcting me. I'm happy I was wrong this time :-)
Op 3 jan. 2012 17:03 schreef "Ross Gardler" <rg...@opendirective.com>
het volgende:
> On 3 January 2012 15:23, Jasha Joachimsthal <j....@onehippo.com>
> wrote:
> > Unfortunately yes :( (correct me if I'm wrong)
>
> That was my understanding too, however, I recently learned otherwise
> see [1]. Summary: "ALv2 section 5 makes no reference to how the
> contribution is submitted.
> It applies equally to contributions made via any method including but
> not limited to JIRA (with or without the ALv2 check box), Bugzilla,
> e-mail and carrier pigeon."
>
> Of course you can add review board after carrier pigeon.
>
> The key is that the patch must have been intentionally submitted for
> inclusion and the ASF must also be able to verify that it was
> intentional. Jira with a commit message to the issue is a nice "paper
> trail" providing this proof. But an appropriate link to an ASF hosted
> review board would also be suffcient.
>
> Note, you still need an iCLA for significant contributions.
>
> Feel free to fine tune your patch submission process, just as long as
> you maintain that "paper trail" and only use ASF hardware.
>
> Ross
>
> [1] http://markmail.org/message/i7xeljlmj52owzxh
>
> >
> >
> > On 3 January 2012 16:14, marijan milicevic <m....@onehippo.com>
> wrote:
> >
> >> Hi Jasha,
> >>
> >>
> >> On 01/03/2012 04:10 PM, Jasha Joachimsthal wrote:
> >>
> >>> Adding the patch in Jira is not optional for legal reasons. It's the
> only
> >>> place where you grant its license to ASF for inclusion.
> >>>
> >>
> >> so it means, patch needs to be attached to both, Jira and Review Board?
> >> cheers
> >> marijan
> >>
> >>
> >>
> >> Jasha Joachimsthal
> >>>
> >>> Europe - Amsterdam - Oosteinde 11, 1017 WT Amsterdam - +31(0)20 522
> 4466
> >>> US - Boston - 1 Broadway, Cambridge, MA 02142 - +1 877 414 4776 (toll
> >>> free)
> >>>
> >>> www.onehippo.com
> >>>
> >>>
> >>> On 3 January 2012 15:52, Marlon Pierce<ma...@iu.edu> wrote:
> >>>
> >>> -----BEGIN PGP SIGNED MESSAGE-----
> >>>> Hash: SHA1
> >>>>
> >>>> The main steps we've followed with others are what you know: post a
> >>>> comment (and optional patch) to Jira) and then request a review. We
> >>>> should
> >>>> add this to the "Get Involved" section of the website.
> >>>>
> >>>>
> >>>>
> >>>> Marlon
> >>>>
> >>>>
> >>>> On 1/3/12 9:05 AM, Carl Hall wrote:
> >>>>
> >>>>> Hi Rave devs,
> >>>>>
> >>>>> I'm Carl Hall and I'm a codeaholic. I met a few of you at ApacheCon
> in
> >>>>> Vancouver last year. My day job is on the Sakai Project and I'm a
> >>>>>
> >>>> committer
> >>>>
> >>>>> to Apache Sling. I spend most of my time with Apache Sling (Apache
> Felix
> >>>>> [OSGi], Apache JackRabbit [JCR]) but I have some history with Spring
> and
> >>>>> OpenSocial[1].
> >>>>>
> >>>>> I started looking through the Rave source a few weeks ago and found
> some
> >>>>> time yesterday to dig into a few issues. As Matt noted on RAVE-374,
> >>>>>
> >>>> patches
> >>>>
> >>>>> are normally posted to reviews.apache.org. Before I create more
> noise,
> >>>>>
> >>>> are
> >>>>
> >>>>> there other patch contribution steps I should follow? Are there
> >>>>>
> >>>> particular
> >>>>
> >>>>> issues that anyone would prefer I work on?
> >>>>>
> >>>>> Thanks,
> >>>>> Carl
> >>>>>
> >>>>> 1 https://github.com/**thecarlhall/dancehall<
> https://github.com/thecarlhall/dancehall>
> >>>>>
> >>>>> -----BEGIN PGP SIGNATURE-----
> >>>> Version: GnuPG/MacGPG2 v2.0.16 (Darwin)
> >>>> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
> >>>>
> >>>> iQEcBAEBAgAGBQJPAxY2AAoJEEfVXE**ODPFIDvLgH+**wSoHL5NNXUJhadRZwYfUrQy
> >>>> UwT3axSX9EC6D9g4AhTbqTdIpU2K5F**UVHvwEAqNY+**CFKNcocq2SgO7YaUtq6WXWL
> >>>> vetYEwxpNEh8zYfsmzgim+**Bpv7esaXA/OfkGamQJ0KkSvtFYO+**0yutxzAUmI0I5F
> >>>> EOvhb8uvfy19JpB7y2kt9l6c4mhQ4i**s9pHNrMmiKMKhZ5COth7gVB/**dzwMOzMeQT
> >>>> nMn+rqFU9+**Rtep5Kx1BcaCSDaIlgcYzr60lYdg1p**xaQHK45h69elkSnpb1ESziRQ
> >>>> Du2bCObuaOOCYhhiaxdtYFgTcvhJlJ**+fcJ8mSz5IIb3Pv7AJ+**1lw4FdEIVW7upU=
> >>>> =b0C2
> >>>> -----END PGP SIGNATURE-----
> >>>>
> >>>>
> >>
>
>
>
> --
> Ross Gardler (@rgardler)
> Programme Leader (Open Development)
> OpenDirective http://opendirective.com
>
Re: Looking around
Posted by Ross Gardler <rg...@opendirective.com>.
On 3 January 2012 15:23, Jasha Joachimsthal <j....@onehippo.com> wrote:
> Unfortunately yes :( (correct me if I'm wrong)
That was my understanding too, however, I recently learned otherwise
see [1]. Summary: "ALv2 section 5 makes no reference to how the
contribution is submitted.
It applies equally to contributions made via any method including but
not limited to JIRA (with or without the ALv2 check box), Bugzilla,
e-mail and carrier pigeon."
Of course you can add review board after carrier pigeon.
The key is that the patch must have been intentionally submitted for
inclusion and the ASF must also be able to verify that it was
intentional. Jira with a commit message to the issue is a nice "paper
trail" providing this proof. But an appropriate link to an ASF hosted
review board would also be suffcient.
Note, you still need an iCLA for significant contributions.
Feel free to fine tune your patch submission process, just as long as
you maintain that "paper trail" and only use ASF hardware.
Ross
[1] http://markmail.org/message/i7xeljlmj52owzxh
>
>
> On 3 January 2012 16:14, marijan milicevic <m....@onehippo.com> wrote:
>
>> Hi Jasha,
>>
>>
>> On 01/03/2012 04:10 PM, Jasha Joachimsthal wrote:
>>
>>> Adding the patch in Jira is not optional for legal reasons. It's the only
>>> place where you grant its license to ASF for inclusion.
>>>
>>
>> so it means, patch needs to be attached to both, Jira and Review Board?
>> cheers
>> marijan
>>
>>
>>
>> Jasha Joachimsthal
>>>
>>> Europe - Amsterdam - Oosteinde 11, 1017 WT Amsterdam - +31(0)20 522 4466
>>> US - Boston - 1 Broadway, Cambridge, MA 02142 - +1 877 414 4776 (toll
>>> free)
>>>
>>> www.onehippo.com
>>>
>>>
>>> On 3 January 2012 15:52, Marlon Pierce<ma...@iu.edu> wrote:
>>>
>>> -----BEGIN PGP SIGNED MESSAGE-----
>>>> Hash: SHA1
>>>>
>>>> The main steps we've followed with others are what you know: post a
>>>> comment (and optional patch) to Jira) and then request a review. We
>>>> should
>>>> add this to the "Get Involved" section of the website.
>>>>
>>>>
>>>>
>>>> Marlon
>>>>
>>>>
>>>> On 1/3/12 9:05 AM, Carl Hall wrote:
>>>>
>>>>> Hi Rave devs,
>>>>>
>>>>> I'm Carl Hall and I'm a codeaholic. I met a few of you at ApacheCon in
>>>>> Vancouver last year. My day job is on the Sakai Project and I'm a
>>>>>
>>>> committer
>>>>
>>>>> to Apache Sling. I spend most of my time with Apache Sling (Apache Felix
>>>>> [OSGi], Apache JackRabbit [JCR]) but I have some history with Spring and
>>>>> OpenSocial[1].
>>>>>
>>>>> I started looking through the Rave source a few weeks ago and found some
>>>>> time yesterday to dig into a few issues. As Matt noted on RAVE-374,
>>>>>
>>>> patches
>>>>
>>>>> are normally posted to reviews.apache.org. Before I create more noise,
>>>>>
>>>> are
>>>>
>>>>> there other patch contribution steps I should follow? Are there
>>>>>
>>>> particular
>>>>
>>>>> issues that anyone would prefer I work on?
>>>>>
>>>>> Thanks,
>>>>> Carl
>>>>>
>>>>> 1 https://github.com/**thecarlhall/dancehall<https://github.com/thecarlhall/dancehall>
>>>>>
>>>>> -----BEGIN PGP SIGNATURE-----
>>>> Version: GnuPG/MacGPG2 v2.0.16 (Darwin)
>>>> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
>>>>
>>>> iQEcBAEBAgAGBQJPAxY2AAoJEEfVXE**ODPFIDvLgH+**wSoHL5NNXUJhadRZwYfUrQy
>>>> UwT3axSX9EC6D9g4AhTbqTdIpU2K5F**UVHvwEAqNY+**CFKNcocq2SgO7YaUtq6WXWL
>>>> vetYEwxpNEh8zYfsmzgim+**Bpv7esaXA/OfkGamQJ0KkSvtFYO+**0yutxzAUmI0I5F
>>>> EOvhb8uvfy19JpB7y2kt9l6c4mhQ4i**s9pHNrMmiKMKhZ5COth7gVB/**dzwMOzMeQT
>>>> nMn+rqFU9+**Rtep5Kx1BcaCSDaIlgcYzr60lYdg1p**xaQHK45h69elkSnpb1ESziRQ
>>>> Du2bCObuaOOCYhhiaxdtYFgTcvhJlJ**+fcJ8mSz5IIb3Pv7AJ+**1lw4FdEIVW7upU=
>>>> =b0C2
>>>> -----END PGP SIGNATURE-----
>>>>
>>>>
>>
--
Ross Gardler (@rgardler)
Programme Leader (Open Development)
OpenDirective http://opendirective.com
RE: Looking around
Posted by "Franklin, Matthew B." <mf...@mitre.org>.
>-----Original Message-----
>From: Jasha Joachimsthal [mailto:j.joachimsthal@onehippo.com]
>Sent: Tuesday, January 03, 2012 10:23 AM
>To: rave-dev@incubator.apache.org
>Subject: Re: Looking around
>
>Unfortunately yes :( (correct me if I'm wrong)
You are absolutely correct. You MUST also select "Grant license to ASF for inclusion..." otherwise we can't apply it.
<snip />
>>>> The main steps we've followed with others are what you know: post a
>>>> comment (and optional patch) to Jira) and then request a review. We
>>>> should
>>>> add this to the "Get Involved" section of the website.
+1
Re: Looking around
Posted by Jasha Joachimsthal <j....@onehippo.com>.
Unfortunately yes :( (correct me if I'm wrong)
On 3 January 2012 16:14, marijan milicevic <m....@onehippo.com> wrote:
> Hi Jasha,
>
>
> On 01/03/2012 04:10 PM, Jasha Joachimsthal wrote:
>
>> Adding the patch in Jira is not optional for legal reasons. It's the only
>> place where you grant its license to ASF for inclusion.
>>
>
> so it means, patch needs to be attached to both, Jira and Review Board?
> cheers
> marijan
>
>
>
> Jasha Joachimsthal
>>
>> Europe - Amsterdam - Oosteinde 11, 1017 WT Amsterdam - +31(0)20 522 4466
>> US - Boston - 1 Broadway, Cambridge, MA 02142 - +1 877 414 4776 (toll
>> free)
>>
>> www.onehippo.com
>>
>>
>> On 3 January 2012 15:52, Marlon Pierce<ma...@iu.edu> wrote:
>>
>> -----BEGIN PGP SIGNED MESSAGE-----
>>> Hash: SHA1
>>>
>>> The main steps we've followed with others are what you know: post a
>>> comment (and optional patch) to Jira) and then request a review. We
>>> should
>>> add this to the "Get Involved" section of the website.
>>>
>>>
>>>
>>> Marlon
>>>
>>>
>>> On 1/3/12 9:05 AM, Carl Hall wrote:
>>>
>>>> Hi Rave devs,
>>>>
>>>> I'm Carl Hall and I'm a codeaholic. I met a few of you at ApacheCon in
>>>> Vancouver last year. My day job is on the Sakai Project and I'm a
>>>>
>>> committer
>>>
>>>> to Apache Sling. I spend most of my time with Apache Sling (Apache Felix
>>>> [OSGi], Apache JackRabbit [JCR]) but I have some history with Spring and
>>>> OpenSocial[1].
>>>>
>>>> I started looking through the Rave source a few weeks ago and found some
>>>> time yesterday to dig into a few issues. As Matt noted on RAVE-374,
>>>>
>>> patches
>>>
>>>> are normally posted to reviews.apache.org. Before I create more noise,
>>>>
>>> are
>>>
>>>> there other patch contribution steps I should follow? Are there
>>>>
>>> particular
>>>
>>>> issues that anyone would prefer I work on?
>>>>
>>>> Thanks,
>>>> Carl
>>>>
>>>> 1 https://github.com/**thecarlhall/dancehall<https://github.com/thecarlhall/dancehall>
>>>>
>>>> -----BEGIN PGP SIGNATURE-----
>>> Version: GnuPG/MacGPG2 v2.0.16 (Darwin)
>>> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
>>>
>>> iQEcBAEBAgAGBQJPAxY2AAoJEEfVXE**ODPFIDvLgH+**wSoHL5NNXUJhadRZwYfUrQy
>>> UwT3axSX9EC6D9g4AhTbqTdIpU2K5F**UVHvwEAqNY+**CFKNcocq2SgO7YaUtq6WXWL
>>> vetYEwxpNEh8zYfsmzgim+**Bpv7esaXA/OfkGamQJ0KkSvtFYO+**0yutxzAUmI0I5F
>>> EOvhb8uvfy19JpB7y2kt9l6c4mhQ4i**s9pHNrMmiKMKhZ5COth7gVB/**dzwMOzMeQT
>>> nMn+rqFU9+**Rtep5Kx1BcaCSDaIlgcYzr60lYdg1p**xaQHK45h69elkSnpb1ESziRQ
>>> Du2bCObuaOOCYhhiaxdtYFgTcvhJlJ**+fcJ8mSz5IIb3Pv7AJ+**1lw4FdEIVW7upU=
>>> =b0C2
>>> -----END PGP SIGNATURE-----
>>>
>>>
>
Re: Looking around
Posted by marijan milicevic <m....@onehippo.com>.
Hi Jasha,
On 01/03/2012 04:10 PM, Jasha Joachimsthal wrote:
> Adding the patch in Jira is not optional for legal reasons. It's the only
> place where you grant its license to ASF for inclusion.
so it means, patch needs to be attached to both, Jira and Review Board?
cheers
marijan
> Jasha Joachimsthal
>
> Europe - Amsterdam - Oosteinde 11, 1017 WT Amsterdam - +31(0)20 522 4466
> US - Boston - 1 Broadway, Cambridge, MA 02142 - +1 877 414 4776 (toll free)
>
> www.onehippo.com
>
>
> On 3 January 2012 15:52, Marlon Pierce<ma...@iu.edu> wrote:
>
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> The main steps we've followed with others are what you know: post a
>> comment (and optional patch) to Jira) and then request a review. We should
>> add this to the "Get Involved" section of the website.
>>
>>
>>
>> Marlon
>>
>>
>> On 1/3/12 9:05 AM, Carl Hall wrote:
>>> Hi Rave devs,
>>>
>>> I'm Carl Hall and I'm a codeaholic. I met a few of you at ApacheCon in
>>> Vancouver last year. My day job is on the Sakai Project and I'm a
>> committer
>>> to Apache Sling. I spend most of my time with Apache Sling (Apache Felix
>>> [OSGi], Apache JackRabbit [JCR]) but I have some history with Spring and
>>> OpenSocial[1].
>>>
>>> I started looking through the Rave source a few weeks ago and found some
>>> time yesterday to dig into a few issues. As Matt noted on RAVE-374,
>> patches
>>> are normally posted to reviews.apache.org. Before I create more noise,
>> are
>>> there other patch contribution steps I should follow? Are there
>> particular
>>> issues that anyone would prefer I work on?
>>>
>>> Thanks,
>>> Carl
>>>
>>> 1 https://github.com/thecarlhall/dancehall
>>>
>> -----BEGIN PGP SIGNATURE-----
>> Version: GnuPG/MacGPG2 v2.0.16 (Darwin)
>> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
>>
>> iQEcBAEBAgAGBQJPAxY2AAoJEEfVXEODPFIDvLgH+wSoHL5NNXUJhadRZwYfUrQy
>> UwT3axSX9EC6D9g4AhTbqTdIpU2K5FUVHvwEAqNY+CFKNcocq2SgO7YaUtq6WXWL
>> vetYEwxpNEh8zYfsmzgim+Bpv7esaXA/OfkGamQJ0KkSvtFYO+0yutxzAUmI0I5F
>> EOvhb8uvfy19JpB7y2kt9l6c4mhQ4is9pHNrMmiKMKhZ5COth7gVB/dzwMOzMeQT
>> nMn+rqFU9+Rtep5Kx1BcaCSDaIlgcYzr60lYdg1pxaQHK45h69elkSnpb1ESziRQ
>> Du2bCObuaOOCYhhiaxdtYFgTcvhJlJ+fcJ8mSz5IIb3Pv7AJ+1lw4FdEIVW7upU=
>> =b0C2
>> -----END PGP SIGNATURE-----
>>
Re: Looking around
Posted by Jasha Joachimsthal <j....@onehippo.com>.
Adding the patch in Jira is not optional for legal reasons. It's the only
place where you grant its license to ASF for inclusion.
Jasha Joachimsthal
Europe - Amsterdam - Oosteinde 11, 1017 WT Amsterdam - +31(0)20 522 4466
US - Boston - 1 Broadway, Cambridge, MA 02142 - +1 877 414 4776 (toll free)
www.onehippo.com
On 3 January 2012 15:52, Marlon Pierce <ma...@iu.edu> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> The main steps we've followed with others are what you know: post a
> comment (and optional patch) to Jira) and then request a review. We should
> add this to the "Get Involved" section of the website.
>
>
>
> Marlon
>
>
> On 1/3/12 9:05 AM, Carl Hall wrote:
> > Hi Rave devs,
> >
> > I'm Carl Hall and I'm a codeaholic. I met a few of you at ApacheCon in
> > Vancouver last year. My day job is on the Sakai Project and I'm a
> committer
> > to Apache Sling. I spend most of my time with Apache Sling (Apache Felix
> > [OSGi], Apache JackRabbit [JCR]) but I have some history with Spring and
> > OpenSocial[1].
> >
> > I started looking through the Rave source a few weeks ago and found some
> > time yesterday to dig into a few issues. As Matt noted on RAVE-374,
> patches
> > are normally posted to reviews.apache.org. Before I create more noise,
> are
> > there other patch contribution steps I should follow? Are there
> particular
> > issues that anyone would prefer I work on?
> >
> > Thanks,
> > Carl
> >
> > 1 https://github.com/thecarlhall/dancehall
> >
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG/MacGPG2 v2.0.16 (Darwin)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
>
> iQEcBAEBAgAGBQJPAxY2AAoJEEfVXEODPFIDvLgH+wSoHL5NNXUJhadRZwYfUrQy
> UwT3axSX9EC6D9g4AhTbqTdIpU2K5FUVHvwEAqNY+CFKNcocq2SgO7YaUtq6WXWL
> vetYEwxpNEh8zYfsmzgim+Bpv7esaXA/OfkGamQJ0KkSvtFYO+0yutxzAUmI0I5F
> EOvhb8uvfy19JpB7y2kt9l6c4mhQ4is9pHNrMmiKMKhZ5COth7gVB/dzwMOzMeQT
> nMn+rqFU9+Rtep5Kx1BcaCSDaIlgcYzr60lYdg1pxaQHK45h69elkSnpb1ESziRQ
> Du2bCObuaOOCYhhiaxdtYFgTcvhJlJ+fcJ8mSz5IIb3Pv7AJ+1lw4FdEIVW7upU=
> =b0C2
> -----END PGP SIGNATURE-----
>
Re: Looking around
Posted by Marlon Pierce <ma...@iu.edu>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
The main steps we've followed with others are what you know: post a comment (and optional patch) to Jira) and then request a review. We should add this to the "Get Involved" section of the website.
Marlon
On 1/3/12 9:05 AM, Carl Hall wrote:
> Hi Rave devs,
>
> I'm Carl Hall and I'm a codeaholic. I met a few of you at ApacheCon in
> Vancouver last year. My day job is on the Sakai Project and I'm a committer
> to Apache Sling. I spend most of my time with Apache Sling (Apache Felix
> [OSGi], Apache JackRabbit [JCR]) but I have some history with Spring and
> OpenSocial[1].
>
> I started looking through the Rave source a few weeks ago and found some
> time yesterday to dig into a few issues. As Matt noted on RAVE-374, patches
> are normally posted to reviews.apache.org. Before I create more noise, are
> there other patch contribution steps I should follow? Are there particular
> issues that anyone would prefer I work on?
>
> Thanks,
> Carl
>
> 1 https://github.com/thecarlhall/dancehall
>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.16 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQEcBAEBAgAGBQJPAxY2AAoJEEfVXEODPFIDvLgH+wSoHL5NNXUJhadRZwYfUrQy
UwT3axSX9EC6D9g4AhTbqTdIpU2K5FUVHvwEAqNY+CFKNcocq2SgO7YaUtq6WXWL
vetYEwxpNEh8zYfsmzgim+Bpv7esaXA/OfkGamQJ0KkSvtFYO+0yutxzAUmI0I5F
EOvhb8uvfy19JpB7y2kt9l6c4mhQ4is9pHNrMmiKMKhZ5COth7gVB/dzwMOzMeQT
nMn+rqFU9+Rtep5Kx1BcaCSDaIlgcYzr60lYdg1pxaQHK45h69elkSnpb1ESziRQ
Du2bCObuaOOCYhhiaxdtYFgTcvhJlJ+fcJ8mSz5IIb3Pv7AJ+1lw4FdEIVW7upU=
=b0C2
-----END PGP SIGNATURE-----