You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by "shuyouZZ (via GitHub)" <gi...@apache.org> on 2025/06/16 03:48:25 UTC
[PR] Update implementation for HMSHandler#get_databases [hive]
shuyouZZ opened a new pull request, #5873:
URL: https://github.com/apache/hive/pull/5873
### What changes were proposed in this pull request?
Update implementation for HMSHandler#get_databases
### Why are the changes needed?
[HIVE-28921](https://github.com/apache/hive/pull/5782) modified the HMSHandler#get_databases and re-implemented it using get_databases_req.
Here does not need to use getMS().getDatabaseObjects to get databases and then extract the name, just get the name directly using getMS().getDatabases.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Use the existing unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29021: Update implementation for HMSHandler#get_databases [hive]
Posted by "shuyouZZ (via GitHub)" <gi...@apache.org>.
shuyouZZ commented on PR #5873:
URL: https://github.com/apache/hive/pull/5873#issuecomment-2976004787
> I understand this is reverting [this change on HMSHandler](https://github.com/apache/hive/pull/5782/files#diff-90c669c961ab250c01087a409b31126cce7ac0672c40f465e7ee262ed7bcdadd). The intention is understandable and the implementation looks correct.
Yes, this PR revert the previous changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29021: Update implementation for HMSHandler#get_databases [hive]
Posted by "deniskuzZ (via GitHub)" <gi...@apache.org>.
deniskuzZ commented on PR #5873:
URL: https://github.com/apache/hive/pull/5873#issuecomment-2976143904
please wait for @dengzhhu653
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29021: Update implementation for HMSHandler#get_databases [hive]
Posted by "dengzhhu653 (via GitHub)" <gi...@apache.org>.
dengzhhu653 commented on PR #5873:
URL: https://github.com/apache/hive/pull/5873#issuecomment-2978667906
> please wait for @dengzhhu653. I think some of the request objects allow filtering out what fields need to be fetched, maybe we can do the same here
>
> ```
> GetTablesRequest req = new GetTablesRequest(dbName);
> ...
> GetProjectionsSpec projectionsSpec = new GetProjectionsSpec();
> projectionsSpec.setFieldList(Arrays.asList("dbName", "tableName", "owner", "ownerType"));
> ```
Thank you @deniskuzZ @shuyouZZ. This [this change on HMSHandler](https://github.com/apache/hive/pull/5782/files#diff-90c669c961ab250c01087a409b31126cce7ac0672c40f465e7ee262ed7bcdadd) is trying to fix the Ranger stack overflow on retrieving the owner from database, so we get the whole database and push it to validate the access(authorization).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29021: Update implementation for HMSHandler#get_databases [hive]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #5873:
URL: https://github.com/apache/hive/pull/5873#issuecomment-2975112808
## [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=5873) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=5873&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=5873&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=5873&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=5873&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=5873&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=5873)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29021: Update implementation for HMSHandler#get_databases [hive]
Posted by "deniskuzZ (via GitHub)" <gi...@apache.org>.
deniskuzZ closed pull request #5873: HIVE-29021: Update implementation for HMSHandler#get_databases
URL: https://github.com/apache/hive/pull/5873
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29021: Update implementation for HMSHandler#get_databases [hive]
Posted by "deniskuzZ (via GitHub)" <gi...@apache.org>.
deniskuzZ commented on PR #5873:
URL: https://github.com/apache/hive/pull/5873#issuecomment-3139639844
No response received from the author, so closing this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org