You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by sn...@apache.org on 2018/12/06 22:26:50 UTC

[incubator-pinot] branch improve-bloomfilter-indexing-config created (now c966893)

This is an automated email from the ASF dual-hosted git repository.

snlee pushed a change to branch improve-bloomfilter-indexing-config
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.


      at c966893  Add the bloom filter to equals() and hashCode() functions in IndexingConfig

This branch includes the following new commits:

     new c966893  Add the bloom filter to equals() and hashCode() functions in IndexingConfig

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[incubator-pinot] 01/01: Add the bloom filter to equals() and hashCode() functions in IndexingConfig

Posted by sn...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

snlee pushed a commit to branch improve-bloomfilter-indexing-config
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git

commit c966893de330cba6c6481d5a7186daa8d184165f
Author: Seunghyun Lee <sn...@linkedin.com>
AuthorDate: Thu Dec 6 14:25:53 2018 -0800

    Add the bloom filter to equals() and hashCode() functions in IndexingConfig
---
 .../main/java/com/linkedin/pinot/common/config/IndexingConfig.java  | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/pinot-common/src/main/java/com/linkedin/pinot/common/config/IndexingConfig.java b/pinot-common/src/main/java/com/linkedin/pinot/common/config/IndexingConfig.java
index 35de1e3..c3a45900 100644
--- a/pinot-common/src/main/java/com/linkedin/pinot/common/config/IndexingConfig.java
+++ b/pinot-common/src/main/java/com/linkedin/pinot/common/config/IndexingConfig.java
@@ -116,7 +116,7 @@ public class IndexingConfig {
     _sortedColumn = sortedColumn;
   }
 
-  
+
   public List<String> getBloomFilterColumns() {
     return _bloomFilterColumns;
   }
@@ -275,7 +275,8 @@ public class IndexingConfig {
         .isEqual(_noDictionaryColumns, that._noDictionaryColumns) && EqualityUtils.isEqual(_noDictionaryConfig,
         that._noDictionaryConfig) && EqualityUtils.isEqual(_onHeapDictionaryColumns, that._onHeapDictionaryColumns)
         && EqualityUtils.isEqual(_starTreeIndexSpec, that._starTreeIndexSpec) && EqualityUtils.isEqual(
-        _segmentPartitionConfig, that._segmentPartitionConfig);
+        _segmentPartitionConfig, that._segmentPartitionConfig) && EqualityUtils.isEqual(_bloomFilterColumns,
+        that._bloomFilterColumns);
   }
 
   @Override
@@ -293,6 +294,7 @@ public class IndexingConfig {
     result = EqualityUtils.hashCodeOf(result, _onHeapDictionaryColumns);
     result = EqualityUtils.hashCodeOf(result, _starTreeIndexSpec);
     result = EqualityUtils.hashCodeOf(result, _segmentPartitionConfig);
+    result = EqualityUtils.hashCodeOf(result, _bloomFilterColumns);
     return result;
   }
 }


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org