[jira] [Commented] (SOLR-7968) Allow extending QueryComponent

["Markus Jelsma (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-7968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14982567#comment-14982567 ] 

Markus Jelsma commented on SOLR-7968:
-------------------------------------

Hello - is this something that can make it into 5.4? It is so much easier to extend QueryComponent instead of copying it as a whole.

> Allow extending QueryComponent
> ------------------------------
>
>                 Key: SOLR-7968
>                 URL: https://issues.apache.org/jira/browse/SOLR-7968
>             Project: Solr
>          Issue Type: Bug
>          Components: SearchComponents - other
>    Affects Versions: 5.2.1
>            Reporter: Markus Jelsma
>             Fix For: 5.4
>
>         Attachments: SOLR-7968.patch
>
>
> QueryComponent is, after all this time, still not extendable. Overriding a simple method is mostly impossible due to members being private or usage of non-public classes. Copying all code to an external class is also not going to work because of this. This patch finally allows overriding QueryComponent methods such as createMainQuery and mergeIds.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org