You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/17 02:02:43 UTC

[GitHub] [spark] HyukjinKwon commented on a change in pull request #35882: [SPARK-38575][INFRA] Duduplicate branch specification in GitHub Actions workflow

HyukjinKwon commented on a change in pull request #35882:
URL: https://github.com/apache/spark/pull/35882#discussion_r828660112



##########
File path: .github/workflows/build_and_test.yml
##########
@@ -23,8 +23,8 @@ on:
   push:
     branches:
     - '**'
-    - '!branch-*.*'

Review comment:
       > Think aloud here, if we enable the all branch validation in each branch push event, that means `branch-*.*` will use the regular (hadoop3/java 8) to run ci in each commits in `branch-*.*` 
   
   I think other branches won't be affected - . branch-3.2 and branch-3.3 has `**` pattern. I referred to https://docs.github.com/en/actions/using-workflows/triggering-a-workflow#about-workflow-triggers
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org