You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/02/27 18:15:01 UTC

[GitHub] dgrove-oss commented on a change in pull request #3211: implement ContainerFactory.cpuShare to fix #3110

dgrove-oss commented on a change in pull request #3211: implement ContainerFactory.cpuShare to fix #3110
URL: https://github.com/apache/incubator-openwhisk/pull/3211#discussion_r171016731
 
 

 ##########
 File path: core/invoker/src/main/scala/whisk/core/containerpool/docker/DockerContainerFactory.scala
 ##########
 @@ -67,13 +70,13 @@ class DockerContainerFactory(config: WhiskConfig,
       image = image,
       userProvidedImage = userProvidedImage,
       memory = memory,
-      cpuShares = config.invokerCoreShare.toInt,
+      cpuShares = poolConfig.cpuShare,
 
 Review comment:
   go ahead and put it in;  I will update KubernetesContainerFactory later.  You are right, currently we are only passing in a memory limit in KubernetesContainerFactory.  However, passing in a CPU limit will be small to the change in container creation in #3338

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services