[GitHub] [incubator-shardingsphere] wgy8283335 commented on a change in pull request #3683: modify sharding-jdbc-orchestration-spring-boot-starter for orchestration-5.x

[GitBox <gi...@apache.org>]

wgy8283335 commented on a change in pull request #3683: modify sharding-jdbc-orchestration-spring-boot-starter for orchestration-5.x
URL: https://github.com/apache/incubator-shardingsphere/pull/3683#discussion_r355164026
 
 

 ##########
 File path: sharding-spring/sharding-jdbc-orchestration-spring/sharding-jdbc-orchestration-spring-boot-starter/src/main/resources/META-INF/additional-spring-configuration-metadata.json
 ##########
 @@ -87,9 +82,15 @@
     {
       "name": "spring.shardingsphere.props",
       "type": "java.util.Properties",
-      "sourceType": "org.apache.shardingsphere.shardingjdbc.orchestration.spring.boot.common.SpringBootPropertiesConfigurationProperties",
+      "sourceType": "org.apache.shardingsphere.shardingjdbc.orchestration.spring.boot.common.SpringBootRootConfigurationProperties",
       "description": "Customize shardingsphere properties."
     },
+    {
 
 Review comment:
   In "properties", the order of "name, type, sourceType" of elements is not kept the same. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services