[GitHub] [hudi] wxplovecc commented on a diff in pull request #5950: [HUDI-4311] Fix Flink lose data on some rollback scene

[GitBox <gi...@apache.org>]

wxplovecc commented on code in PR #5950:
URL: https://github.com/apache/hudi/pull/5950#discussion_r905865633


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/common/AbstractStreamWriteFunction.java:
##########
@@ -265,6 +265,6 @@ protected String instantToWrite(boolean hasData) {
    * Returns whether the pending instant is invalid to write with.
    */
   private boolean invalidInstant(String instant, boolean hasData) {
-    return instant.equals(this.currentInstant) && hasData && !this.ckpMetadata.isAborted(instant);
+    return instant.equals(this.currentInstant) && hasData && this.ckpMetadata.isAborted(instant);
   }

Review Comment:
   Yes it was not right .The aborted instant maybe also deleted by rollback if some write task failed , and other like checkpoint timeout we should reuse this instant . do you have some good idea



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org