[jira] [Work logged] (GOBBLIN-1997) Avoid deleting flowSpec too early

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/GOBBLIN-1997?focusedWorklogId=902730&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-902730 ]

ASF GitHub Bot logged work on GOBBLIN-1997:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 30/Jan/24 18:27
            Start Date: 30/Jan/24 18:27
    Worklog Time Spent: 10m 
      Work Description: umustafi opened a new pull request, #3872:
URL: https://github.com/apache/gobblin/pull/3872

   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   - [X] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-1997
   
   
   ### Description
   - [X] Here are some details about my PR, including screenshots (if applicable):
   If a non-active host receives and processes the `LAUNCH` event before the leader does, then we encounter a `SpecNotFoundException` [here](https://github.com/apache/gobblin/blob/67c610117c2b757bb15714826e0b0edc3e6b26a5/gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/DagActionStoreChangeMonitor.java#L290 ) when the leader goes to process the event and the execution of the `LAUNCH` will be missed. This PR moves the deletion to the `DagManager` and does it only after completing `addDag` to persist the event and after checking active status. 
   
   ### Tests
   - [X] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   
   ### Commits
   - [X] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   




Issue Time Tracking
-------------------

            Worklog Id:     (was: 902730)
    Remaining Estimate: 0h
            Time Spent: 10m

> Avoid deleting flowSpec too early 
> ----------------------------------
>
>                 Key: GOBBLIN-1997
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1997
>             Project: Apache Gobblin
>          Issue Type: Bug
>          Components: gobblin-service
>            Reporter: Urmi Mustafi
>            Assignee: Abhishek Tiwari
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> [https://github.com/apache/gobblin/blob/67c610117c2b757bb15714826e0b0edc3e6b26a5/gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/DagActionStoreChangeMonitor.java#L290] 
> If a non-active host receives and processes the LAUNCH event before the leader does, then we encounter a SpecNotFoundException when the leader goes to process the event and the execution of the LAUNCH will be missed. This PR moves the deletion to the DagManager and does it only after completing addDag to persist the event and after checking active status. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)