You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/03/29 02:01:21 UTC
[GitHub] [skywalking] wu-sheng opened a new pull request #4587: [WIP] OAP
Core polish, especially storage level
wu-sheng opened a new pull request #4587: [WIP] OAP Core polish, especially storage level
URL: https://github.com/apache/skywalking/pull/4587
There are a lot of `if/else` codes due to the differences of the storages, but I plan to merge them in a more elegance and consistent way.
1. Add length definition with reasonable default value.
2. Merge H2 and MySQL columntype mapping back to consistent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4587:
OAP Core polish, especially storage level
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4587: OAP Core polish, especially storage level
URL: https://github.com/apache/skywalking/pull/4587#discussion_r399907071
##########
File path: oap-server/oal-rt/src/main/java/org/apache/skywalking/oal/rt/OALRuntime.java
##########
@@ -377,10 +376,19 @@ private Class generateDispatcherClass(String scopeName,
*/
String sourceClassName = SOURCE_PACKAGE + dispatcherContext.getSource();
SignatureAttribute.ClassSignature dispatcherSignature = new SignatureAttribute.ClassSignature(null, null,
- // Set interface and its generic params
- new SignatureAttribute.ClassType[] {
- new SignatureAttribute.ClassType(SourceDispatcher.class.getCanonicalName(), new SignatureAttribute.TypeArgument[] {new SignatureAttribute.TypeArgument(new SignatureAttribute.ClassType(sourceClassName))})
- });
+ // Set interface and its generic params
+ new SignatureAttribute.ClassType[] {
+ new SignatureAttribute.ClassType(
+ SourceDispatcher.class
+ .getCanonicalName(),
+ new SignatureAttribute.TypeArgument[] {
+ new SignatureAttribute.TypeArgument(
+ new SignatureAttribute.ClassType(
+ sourceClassName))
+ }
+ )
+ }
Review comment:
These are not blank :) Scroll to the right.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4587: OAP Core
polish, especially storage level
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4587: OAP Core polish, especially storage level
URL: https://github.com/apache/skywalking/pull/4587#issuecomment-605550126
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=h1) Report
> Merging [#4587](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4474907fef809e2342b644a324da011834a55420&el=desc) will **increase** coverage by `0.50%`.
> The diff coverage is `21.54%`.
[](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4587 +/- ##
==========================================
+ Coverage 26.43% 26.93% +0.50%
==========================================
Files 1253 1256 +3
Lines 28989 28965 -24
Branches 3952 3963 +11
==========================================
+ Hits 7663 7803 +140
+ Misses 20623 20449 -174
- Partials 703 713 +10
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../skywalking/oap/server/core/alarm/AlarmRecord.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1SZWNvcmQuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...core/analysis/manual/endpoint/EndpointTraffic.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2VuZHBvaW50L0VuZHBvaW50VHJhZmZpYy5qYXZh) | `55.00% <0.00%> (+3.43%)` | :arrow_up: |
| [...intrelation/EndpointRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2VuZHBvaW50cmVsYXRpb24vRW5kcG9pbnRSZWxhdGlvblNlcnZlclNpZGVNZXRyaWNzLmphdmE=) | `0.00% <ø> (ø)` | |
| [...ance/ServiceInstanceRelationClientSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2luc3RhbmNlL1NlcnZpY2VJbnN0YW5jZVJlbGF0aW9uQ2xpZW50U2lkZU1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ance/ServiceInstanceRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2luc3RhbmNlL1NlcnZpY2VJbnN0YW5jZVJlbGF0aW9uU2VydmVyU2lkZU1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...tion/service/ServiceRelationClientSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL3NlcnZpY2UvU2VydmljZVJlbGF0aW9uQ2xpZW50U2lkZU1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...tion/service/ServiceRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL3NlcnZpY2UvU2VydmljZVJlbGF0aW9uU2VydmVyU2lkZU1ldHJpY3MuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `0.00% <ø> (ø)` | |
| ... and [52 more](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=footer). Last update [4474907...4f0eeb8](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4587: [WIP] OAP
Core polish, especially storage level
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4587: [WIP] OAP Core polish, especially storage level
URL: https://github.com/apache/skywalking/pull/4587#issuecomment-605550126
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=h1) Report
> Merging [#4587](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4474907fef809e2342b644a324da011834a55420&el=desc) will **increase** coverage by `0.50%`.
> The diff coverage is `29.77%`.
[](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4587 +/- ##
==========================================
+ Coverage 26.43% 26.94% +0.50%
==========================================
Files 1253 1256 +3
Lines 28989 28960 -29
Branches 3952 3964 +12
==========================================
+ Hits 7663 7803 +140
+ Misses 20623 20444 -179
- Partials 703 713 +10
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../skywalking/oap/server/core/alarm/AlarmRecord.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1SZWNvcmQuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...intrelation/EndpointRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2VuZHBvaW50cmVsYXRpb24vRW5kcG9pbnRSZWxhdGlvblNlcnZlclNpZGVNZXRyaWNzLmphdmE=) | `0.00% <ø> (ø)` | |
| [...ance/ServiceInstanceRelationClientSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2luc3RhbmNlL1NlcnZpY2VJbnN0YW5jZVJlbGF0aW9uQ2xpZW50U2lkZU1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ance/ServiceInstanceRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2luc3RhbmNlL1NlcnZpY2VJbnN0YW5jZVJlbGF0aW9uU2VydmVyU2lkZU1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...tion/service/ServiceRelationClientSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL3NlcnZpY2UvU2VydmljZVJlbGF0aW9uQ2xpZW50U2lkZU1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...tion/service/ServiceRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL3NlcnZpY2UvU2VydmljZVJlbGF0aW9uU2VydmVyU2lkZU1ldHJpY3MuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `0.00% <ø> (ø)` | |
| [...oap/server/core/analysis/metrics/ApdexMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9BcGRleE1ldHJpY3MuamF2YQ==) | `100.00% <ø> (ø)` | |
| ... and [45 more](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=footer). Last update [4474907...c44975e](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4587:
OAP Core polish, especially storage level
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4587: OAP Core polish, especially storage level
URL: https://github.com/apache/skywalking/pull/4587#discussion_r399909277
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/annotation/Column.java
##########
@@ -55,5 +55,12 @@
/**
* The column is just saved, never used in query.
*/
- boolean content() default false;
+ boolean storageOnly() default false;
Review comment:
No, you can't. There are countless place in the codes, including the OAL generated codes. If you use this, we are facing more changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4587:
OAP Core polish, especially storage level
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4587: OAP Core polish, especially storage level
URL: https://github.com/apache/skywalking/pull/4587#discussion_r399908759
##########
File path: oap-server/oal-rt/src/main/java/org/apache/skywalking/oal/rt/OALRuntime.java
##########
@@ -377,10 +376,19 @@ private Class generateDispatcherClass(String scopeName,
*/
String sourceClassName = SOURCE_PACKAGE + dispatcherContext.getSource();
SignatureAttribute.ClassSignature dispatcherSignature = new SignatureAttribute.ClassSignature(null, null,
- // Set interface and its generic params
- new SignatureAttribute.ClassType[] {
- new SignatureAttribute.ClassType(SourceDispatcher.class.getCanonicalName(), new SignatureAttribute.TypeArgument[] {new SignatureAttribute.TypeArgument(new SignatureAttribute.ClassType(sourceClassName))})
- });
+ // Set interface and its generic params
+ new SignatureAttribute.ClassType[] {
+ new SignatureAttribute.ClassType(
+ SourceDispatcher.class
+ .getCanonicalName(),
+ new SignatureAttribute.TypeArgument[] {
+ new SignatureAttribute.TypeArgument(
+ new SignatureAttribute.ClassType(
+ sourceClassName))
+ }
+ )
+ }
Review comment:
Updated, should be better now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] hanahmily commented on a change in pull request #4587:
OAP Core polish, especially storage level
Posted by GitBox <gi...@apache.org>.
hanahmily commented on a change in pull request #4587: OAP Core polish, especially storage level
URL: https://github.com/apache/skywalking/pull/4587#discussion_r399906792
##########
File path: oap-server/oal-rt/src/main/java/org/apache/skywalking/oal/rt/OALRuntime.java
##########
@@ -377,10 +376,19 @@ private Class generateDispatcherClass(String scopeName,
*/
String sourceClassName = SOURCE_PACKAGE + dispatcherContext.getSource();
SignatureAttribute.ClassSignature dispatcherSignature = new SignatureAttribute.ClassSignature(null, null,
- // Set interface and its generic params
- new SignatureAttribute.ClassType[] {
- new SignatureAttribute.ClassType(SourceDispatcher.class.getCanonicalName(), new SignatureAttribute.TypeArgument[] {new SignatureAttribute.TypeArgument(new SignatureAttribute.ClassType(sourceClassName))})
- });
+ // Set interface and its generic params
+ new SignatureAttribute.ClassType[] {
+ new SignatureAttribute.ClassType(
+ SourceDispatcher.class
+ .getCanonicalName(),
+ new SignatureAttribute.TypeArgument[] {
+ new SignatureAttribute.TypeArgument(
+ new SignatureAttribute.ClassType(
+ sourceClassName))
+ }
+ )
+ }
Review comment:
Why blank lines here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4587: [WIP] OAP
Core polish, especially storage level
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4587: [WIP] OAP Core polish, especially storage level
URL: https://github.com/apache/skywalking/pull/4587#issuecomment-605550126
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=h1) Report
> Merging [#4587](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4474907fef809e2342b644a324da011834a55420&el=desc) will **increase** coverage by `0.50%`.
> The diff coverage is `27.89%`.
[](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4587 +/- ##
==========================================
+ Coverage 26.43% 26.94% +0.50%
==========================================
Files 1253 1256 +3
Lines 28989 28961 -28
Branches 3952 3964 +12
==========================================
+ Hits 7663 7803 +140
+ Misses 20623 20445 -178
- Partials 703 713 +10
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../skywalking/oap/server/core/alarm/AlarmRecord.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1SZWNvcmQuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...intrelation/EndpointRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2VuZHBvaW50cmVsYXRpb24vRW5kcG9pbnRSZWxhdGlvblNlcnZlclNpZGVNZXRyaWNzLmphdmE=) | `0.00% <ø> (ø)` | |
| [...ance/ServiceInstanceRelationClientSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2luc3RhbmNlL1NlcnZpY2VJbnN0YW5jZVJlbGF0aW9uQ2xpZW50U2lkZU1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ance/ServiceInstanceRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2luc3RhbmNlL1NlcnZpY2VJbnN0YW5jZVJlbGF0aW9uU2VydmVyU2lkZU1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...tion/service/ServiceRelationClientSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL3NlcnZpY2UvU2VydmljZVJlbGF0aW9uQ2xpZW50U2lkZU1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...tion/service/ServiceRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL3NlcnZpY2UvU2VydmljZVJlbGF0aW9uU2VydmVyU2lkZU1ldHJpY3MuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `0.00% <ø> (ø)` | |
| [...oap/server/core/analysis/metrics/ApdexMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9BcGRleE1ldHJpY3MuamF2YQ==) | `100.00% <ø> (ø)` | |
| ... and [51 more](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=footer). Last update [4474907...ab81183](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4587:
OAP Core polish, especially storage level
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4587: OAP Core polish, especially storage level
URL: https://github.com/apache/skywalking/pull/4587#discussion_r399954769
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/model/ExtraQueryIndex.java
##########
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.storage.model;
+
+import lombok.Getter;
+import org.apache.skywalking.oap.server.library.util.CollectionUtils;
+
+/**
+ * The extra query index if the storage could support this mode. Many NO-SQL support one column index only, in that
+ * case, this could be ignored in the implementation level.
+ */
+@Getter
+public class ExtraQueryIndex {
+ private String[] columns;
+
+ public ExtraQueryIndex(String mainColumn, final String[] withColumns) {
+ if (CollectionUtils.isNotEmpty(withColumns)) {
+ this.columns = new String[withColumns.length + 1];
+ for (int i = 0; i < columns.length; i++) {
+ if (i == 0) {
+ columns[i] = mainColumn;
+ } else {
+ columns[i] = withColumns[i - 1];
+ }
+ }
Review comment:
Yes, adopted this method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] hanahmily commented on a change in pull request #4587:
OAP Core polish, especially storage level
Posted by GitBox <gi...@apache.org>.
hanahmily commented on a change in pull request #4587: OAP Core polish, especially storage level
URL: https://github.com/apache/skywalking/pull/4587#discussion_r399909635
##########
File path: oap-server/oal-rt/src/main/java/org/apache/skywalking/oal/rt/OALRuntime.java
##########
@@ -377,10 +376,19 @@ private Class generateDispatcherClass(String scopeName,
*/
String sourceClassName = SOURCE_PACKAGE + dispatcherContext.getSource();
SignatureAttribute.ClassSignature dispatcherSignature = new SignatureAttribute.ClassSignature(null, null,
- // Set interface and its generic params
- new SignatureAttribute.ClassType[] {
- new SignatureAttribute.ClassType(SourceDispatcher.class.getCanonicalName(), new SignatureAttribute.TypeArgument[] {new SignatureAttribute.TypeArgument(new SignatureAttribute.ClassType(sourceClassName))})
- });
+ // Set interface and its generic params
+ new SignatureAttribute.ClassType[] {
+ new SignatureAttribute.ClassType(
+ SourceDispatcher.class
+ .getCanonicalName(),
+ new SignatureAttribute.TypeArgument[] {
+ new SignatureAttribute.TypeArgument(
+ new SignatureAttribute.ClassType(
+ sourceClassName))
+ }
+ )
+ }
Review comment:
LTGM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4587: [WIP] OAP
Core polish, especially storage level
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4587: [WIP] OAP Core polish, especially storage level
URL: https://github.com/apache/skywalking/pull/4587#issuecomment-605550126
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=h1) Report
> Merging [#4587](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4474907fef809e2342b644a324da011834a55420&el=desc) will **increase** coverage by `0.38%`.
> The diff coverage is `43.22%`.
[](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4587 +/- ##
==========================================
+ Coverage 26.43% 26.82% +0.38%
==========================================
Files 1253 1255 +2
Lines 28989 28877 -112
Branches 3952 3946 -6
==========================================
+ Hits 7663 7745 +82
+ Misses 20623 20423 -200
- Partials 703 709 +6
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../apache/skywalking/oap/server/core/CoreModule.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZS5qYXZh) | `4.08% <0.00%> (ø)` | |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../skywalking/oap/server/core/alarm/AlarmRecord.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1SZWNvcmQuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...intrelation/EndpointRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2VuZHBvaW50cmVsYXRpb24vRW5kcG9pbnRSZWxhdGlvblNlcnZlclNpZGVNZXRyaWNzLmphdmE=) | `0.00% <ø> (ø)` | |
| [...ance/ServiceInstanceRelationClientSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2luc3RhbmNlL1NlcnZpY2VJbnN0YW5jZVJlbGF0aW9uQ2xpZW50U2lkZU1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ance/ServiceInstanceRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2luc3RhbmNlL1NlcnZpY2VJbnN0YW5jZVJlbGF0aW9uU2VydmVyU2lkZU1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...tion/service/ServiceRelationClientSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL3NlcnZpY2UvU2VydmljZVJlbGF0aW9uQ2xpZW50U2lkZU1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...tion/service/ServiceRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL3NlcnZpY2UvU2VydmljZVJlbGF0aW9uU2VydmVyU2lkZU1ldHJpY3MuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `0.00% <ø> (ø)` | |
| ... and [40 more](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=footer). Last update [4474907...84b48db](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng merged pull request #4587: OAP Core polish,
especially storage level
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #4587: OAP Core polish, especially storage level
URL: https://github.com/apache/skywalking/pull/4587
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4587:
OAP Core polish, especially storage level
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4587: OAP Core polish, especially storage level
URL: https://github.com/apache/skywalking/pull/4587#discussion_r399907208
##########
File path: oap-server/oal-rt/src/main/java/org/apache/skywalking/oal/rt/OALRuntime.java
##########
@@ -377,10 +376,19 @@ private Class generateDispatcherClass(String scopeName,
*/
String sourceClassName = SOURCE_PACKAGE + dispatcherContext.getSource();
SignatureAttribute.ClassSignature dispatcherSignature = new SignatureAttribute.ClassSignature(null, null,
- // Set interface and its generic params
- new SignatureAttribute.ClassType[] {
- new SignatureAttribute.ClassType(SourceDispatcher.class.getCanonicalName(), new SignatureAttribute.TypeArgument[] {new SignatureAttribute.TypeArgument(new SignatureAttribute.ClassType(sourceClassName))})
- });
+ // Set interface and its generic params
+ new SignatureAttribute.ClassType[] {
+ new SignatureAttribute.ClassType(
+ SourceDispatcher.class
+ .getCanonicalName(),
+ new SignatureAttribute.TypeArgument[] {
+ new SignatureAttribute.TypeArgument(
+ new SignatureAttribute.ClassType(
+ sourceClassName))
+ }
+ )
+ }
Review comment:
I could reformat it manually a little.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io commented on issue #4587: [WIP] OAP Core
polish, especially storage level
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4587: [WIP] OAP Core polish, especially storage level
URL: https://github.com/apache/skywalking/pull/4587#issuecomment-605550126
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=h1) Report
> Merging [#4587](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4474907fef809e2342b644a324da011834a55420&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `34.04%`.
[](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4587 +/- ##
==========================================
+ Coverage 26.43% 26.46% +0.03%
==========================================
Files 1253 1254 +1
Lines 28989 28992 +3
Branches 3952 3947 -5
==========================================
+ Hits 7663 7673 +10
+ Misses 20623 20614 -9
- Partials 703 705 +2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...intrelation/EndpointRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2VuZHBvaW50cmVsYXRpb24vRW5kcG9pbnRSZWxhdGlvblNlcnZlclNpZGVNZXRyaWNzLmphdmE=) | `0.00% <ø> (ø)` | |
| [...ance/ServiceInstanceRelationClientSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2luc3RhbmNlL1NlcnZpY2VJbnN0YW5jZVJlbGF0aW9uQ2xpZW50U2lkZU1ldHJpY3MuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...ance/ServiceInstanceRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2luc3RhbmNlL1NlcnZpY2VJbnN0YW5jZVJlbGF0aW9uU2VydmVyU2lkZU1ldHJpY3MuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...tion/service/ServiceRelationClientSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL3NlcnZpY2UvU2VydmljZVJlbGF0aW9uQ2xpZW50U2lkZU1ldHJpY3MuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...tion/service/ServiceRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL3NlcnZpY2UvU2VydmljZVJlbGF0aW9uU2VydmVyU2lkZU1ldHJpY3MuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `0.00% <ø> (ø)` | |
| [...oap/server/core/analysis/metrics/ApdexMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9BcGRleE1ldHJpY3MuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...g/oap/server/core/analysis/metrics/CPMMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9DUE1NZXRyaWNzLmphdmE=) | `0.00% <ø> (ø)` | |
| [...server/core/analysis/metrics/DoubleAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Eb3VibGVBdmdNZXRyaWNzLmphdmE=) | `0.00% <ø> (ø)` | |
| ... and [16 more](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=footer). Last update [4474907...8d7a944](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4587: [WIP] OAP
Core polish, especially storage level
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4587: [WIP] OAP Core polish, especially storage level
URL: https://github.com/apache/skywalking/pull/4587#issuecomment-605550126
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=h1) Report
> Merging [#4587](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4474907fef809e2342b644a324da011834a55420&el=desc) will **increase** coverage by `0.50%`.
> The diff coverage is `25.11%`.
[](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4587 +/- ##
==========================================
+ Coverage 26.43% 26.93% +0.50%
==========================================
Files 1253 1256 +3
Lines 28989 28968 -21
Branches 3952 3966 +14
==========================================
+ Hits 7663 7803 +140
+ Misses 20623 20452 -171
- Partials 703 713 +10
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../skywalking/oap/server/core/alarm/AlarmRecord.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1SZWNvcmQuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...core/analysis/manual/endpoint/EndpointTraffic.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2VuZHBvaW50L0VuZHBvaW50VHJhZmZpYy5qYXZh) | `53.22% <0.00%> (+1.66%)` | :arrow_up: |
| [...intrelation/EndpointRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2VuZHBvaW50cmVsYXRpb24vRW5kcG9pbnRSZWxhdGlvblNlcnZlclNpZGVNZXRyaWNzLmphdmE=) | `0.00% <ø> (ø)` | |
| [...ance/ServiceInstanceRelationClientSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2luc3RhbmNlL1NlcnZpY2VJbnN0YW5jZVJlbGF0aW9uQ2xpZW50U2lkZU1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ance/ServiceInstanceRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2luc3RhbmNlL1NlcnZpY2VJbnN0YW5jZVJlbGF0aW9uU2VydmVyU2lkZU1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...tion/service/ServiceRelationClientSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL3NlcnZpY2UvU2VydmljZVJlbGF0aW9uQ2xpZW50U2lkZU1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...tion/service/ServiceRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL3NlcnZpY2UvU2VydmljZVJlbGF0aW9uU2VydmVyU2lkZU1ldHJpY3MuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `0.00% <ø> (ø)` | |
| ... and [52 more](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=footer). Last update [4474907...7bfaa8e](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4587: OAP Core
polish, especially storage level
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4587: OAP Core polish, especially storage level
URL: https://github.com/apache/skywalking/pull/4587#issuecomment-605550126
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=h1) Report
> Merging [#4587](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4474907fef809e2342b644a324da011834a55420&el=desc) will **increase** coverage by `0.51%`.
> The diff coverage is `21.42%`.
[](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4587 +/- ##
==========================================
+ Coverage 26.43% 26.94% +0.51%
==========================================
Files 1253 1256 +3
Lines 28989 28963 -26
Branches 3952 3961 +9
==========================================
+ Hits 7663 7804 +141
+ Misses 20623 20446 -177
- Partials 703 713 +10
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../skywalking/oap/server/core/alarm/AlarmRecord.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1SZWNvcmQuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...core/analysis/manual/endpoint/EndpointTraffic.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2VuZHBvaW50L0VuZHBvaW50VHJhZmZpYy5qYXZh) | `55.00% <0.00%> (+3.43%)` | :arrow_up: |
| [...intrelation/EndpointRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2VuZHBvaW50cmVsYXRpb24vRW5kcG9pbnRSZWxhdGlvblNlcnZlclNpZGVNZXRyaWNzLmphdmE=) | `0.00% <ø> (ø)` | |
| [...ance/ServiceInstanceRelationClientSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2luc3RhbmNlL1NlcnZpY2VJbnN0YW5jZVJlbGF0aW9uQ2xpZW50U2lkZU1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ance/ServiceInstanceRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2luc3RhbmNlL1NlcnZpY2VJbnN0YW5jZVJlbGF0aW9uU2VydmVyU2lkZU1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...tion/service/ServiceRelationClientSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL3NlcnZpY2UvU2VydmljZVJlbGF0aW9uQ2xpZW50U2lkZU1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...tion/service/ServiceRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL3NlcnZpY2UvU2VydmljZVJlbGF0aW9uU2VydmVyU2lkZU1ldHJpY3MuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `0.00% <ø> (ø)` | |
| ... and [55 more](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=footer). Last update [f56d98d...a168c4f](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] hanahmily commented on a change in pull request #4587:
OAP Core polish, especially storage level
Posted by GitBox <gi...@apache.org>.
hanahmily commented on a change in pull request #4587: OAP Core polish, especially storage level
URL: https://github.com/apache/skywalking/pull/4587#discussion_r399907363
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/MetricsExtension.java
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.analysis;
+
+import java.lang.annotation.ElementType;
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
+import java.lang.annotation.Target;
+import org.apache.skywalking.oap.server.core.analysis.worker.MetricsStreamProcessor;
+
+/**
+ * MetricsExtension annotation defines extension attributes of the {@link Stream} with {@link MetricsStreamProcessor}.
+ */
+@Target(ElementType.TYPE)
+@Retention(RetentionPolicy.RUNTIME)
+public @interface MetricsExtension {
+ /**
+ * @return true if this metrics stream support down sampling.
+ */
+ boolean supportDownSampling();
+
+ /**
+ * @return true if this metrics doesn't support update.
+ */
+ boolean insertOnly();
Review comment:
We should name it to `supportUpdate` or change the comment description. They are not identical.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4587: OAP Core polish,
especially storage level
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4587: OAP Core polish, especially storage level
URL: https://github.com/apache/skywalking/pull/4587#issuecomment-605829628
@hanahmily Recheck please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4587: [WIP] OAP
Core polish, especially storage level
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4587: [WIP] OAP Core polish, especially storage level
URL: https://github.com/apache/skywalking/pull/4587#issuecomment-605550126
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=h1) Report
> Merging [#4587](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4474907fef809e2342b644a324da011834a55420&el=desc) will **increase** coverage by `0.50%`.
> The diff coverage is `29.44%`.
[](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4587 +/- ##
==========================================
+ Coverage 26.43% 26.94% +0.50%
==========================================
Files 1253 1256 +3
Lines 28989 28961 -28
Branches 3952 3964 +12
==========================================
+ Hits 7663 7803 +140
+ Misses 20623 20445 -178
- Partials 703 713 +10
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../skywalking/oap/server/core/alarm/AlarmRecord.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1SZWNvcmQuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...intrelation/EndpointRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2VuZHBvaW50cmVsYXRpb24vRW5kcG9pbnRSZWxhdGlvblNlcnZlclNpZGVNZXRyaWNzLmphdmE=) | `0.00% <ø> (ø)` | |
| [...ance/ServiceInstanceRelationClientSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2luc3RhbmNlL1NlcnZpY2VJbnN0YW5jZVJlbGF0aW9uQ2xpZW50U2lkZU1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ance/ServiceInstanceRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2luc3RhbmNlL1NlcnZpY2VJbnN0YW5jZVJlbGF0aW9uU2VydmVyU2lkZU1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...tion/service/ServiceRelationClientSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL3NlcnZpY2UvU2VydmljZVJlbGF0aW9uQ2xpZW50U2lkZU1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...tion/service/ServiceRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL3NlcnZpY2UvU2VydmljZVJlbGF0aW9uU2VydmVyU2lkZU1ldHJpY3MuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `0.00% <ø> (ø)` | |
| [...oap/server/core/analysis/metrics/ApdexMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9BcGRleE1ldHJpY3MuamF2YQ==) | `100.00% <ø> (ø)` | |
| ... and [45 more](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=footer). Last update [4474907...a60c7d4](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] hanahmily commented on a change in pull request #4587:
OAP Core polish, especially storage level
Posted by GitBox <gi...@apache.org>.
hanahmily commented on a change in pull request #4587: OAP Core polish, especially storage level
URL: https://github.com/apache/skywalking/pull/4587#discussion_r399909717
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/MetricsExtension.java
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.analysis;
+
+import java.lang.annotation.ElementType;
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
+import java.lang.annotation.Target;
+import org.apache.skywalking.oap.server.core.analysis.worker.MetricsStreamProcessor;
+
+/**
+ * MetricsExtension annotation defines extension attributes of the {@link Stream} with {@link MetricsStreamProcessor}.
+ */
+@Target(ElementType.TYPE)
+@Retention(RetentionPolicy.RUNTIME)
+public @interface MetricsExtension {
+ /**
+ * @return true if this metrics stream support down sampling.
+ */
+ boolean supportDownSampling();
+
+ /**
+ * @return true if this metrics doesn't support update.
+ */
+ boolean insertOnly();
Review comment:
👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] hanahmily commented on a change in pull request #4587:
OAP Core polish, especially storage level
Posted by GitBox <gi...@apache.org>.
hanahmily commented on a change in pull request #4587: OAP Core polish, especially storage level
URL: https://github.com/apache/skywalking/pull/4587#discussion_r399909085
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/model/ExtraQueryIndex.java
##########
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.storage.model;
+
+import lombok.Getter;
+import org.apache.skywalking.oap.server.library.util.CollectionUtils;
+
+/**
+ * The extra query index if the storage could support this mode. Many NO-SQL support one column index only, in that
+ * case, this could be ignored in the implementation level.
+ */
+@Getter
+public class ExtraQueryIndex {
+ private String[] columns;
+
+ public ExtraQueryIndex(String mainColumn, final String[] withColumns) {
+ if (CollectionUtils.isNotEmpty(withColumns)) {
+ this.columns = new String[withColumns.length + 1];
+ for (int i = 0; i < columns.length; i++) {
+ if (i == 0) {
+ columns[i] = mainColumn;
+ } else {
+ columns[i] = withColumns[i - 1];
+ }
+ }
Review comment:
We can simplify them with `System.arraycopy`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4587:
OAP Core polish, especially storage level
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4587: OAP Core polish, especially storage level
URL: https://github.com/apache/skywalking/pull/4587#discussion_r399908687
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/MetricsExtension.java
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.analysis;
+
+import java.lang.annotation.ElementType;
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
+import java.lang.annotation.Target;
+import org.apache.skywalking.oap.server.core.analysis.worker.MetricsStreamProcessor;
+
+/**
+ * MetricsExtension annotation defines extension attributes of the {@link Stream} with {@link MetricsStreamProcessor}.
+ */
+@Target(ElementType.TYPE)
+@Retention(RetentionPolicy.RUNTIME)
+public @interface MetricsExtension {
+ /**
+ * @return true if this metrics stream support down sampling.
+ */
+ boolean supportDownSampling();
+
+ /**
+ * @return true if this metrics doesn't support update.
+ */
+ boolean insertOnly();
Review comment:
Rename `insertOnly` to `supportUpdate`. EndpointTraffic has wrong definition before.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] mrproliu commented on a change in pull request #4587:
OAP Core polish, especially storage level
Posted by GitBox <gi...@apache.org>.
mrproliu commented on a change in pull request #4587: OAP Core polish, especially storage level
URL: https://github.com/apache/skywalking/pull/4587#discussion_r399908578
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/annotation/Column.java
##########
@@ -55,5 +55,12 @@
/**
* The column is just saved, never used in query.
*/
- boolean content() default false;
+ boolean storageOnly() default false;
Review comment:
I suggest the storageOnly default is `true` in the Column annotation? Because I think most of the columns are just for storage.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4587: OAP Core polish,
especially storage level
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4587: OAP Core polish, especially storage level
URL: https://github.com/apache/skywalking/pull/4587#issuecomment-605753899
Another update, if you has read my previous #4570, you may have noticed there is duplicated record in the endpoint_traffic index. In this PR, I also update the id()/hashcode()/equal() logic for it, therefore, every endpoint has an unique record, once it was deleted by TTL, it will regenerate when new request of this endpoint comes.
Notice the **_id**, no time bucket included anymore. Time bucket is only for time-related insert and TTL mechanism.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4587: [WIP] OAP
Core polish, especially storage level
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4587: [WIP] OAP Core polish, especially storage level
URL: https://github.com/apache/skywalking/pull/4587#issuecomment-605550126
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=h1) Report
> Merging [#4587](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4474907fef809e2342b644a324da011834a55420&el=desc) will **increase** coverage by `0.50%`.
> The diff coverage is `26.36%`.
[](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4587 +/- ##
==========================================
+ Coverage 26.43% 26.94% +0.50%
==========================================
Files 1253 1256 +3
Lines 28989 28964 -25
Branches 3952 3965 +13
==========================================
+ Hits 7663 7803 +140
+ Misses 20623 20448 -175
- Partials 703 713 +10
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../skywalking/oap/server/core/alarm/AlarmRecord.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1SZWNvcmQuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...core/analysis/manual/endpoint/EndpointTraffic.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2VuZHBvaW50L0VuZHBvaW50VHJhZmZpYy5qYXZh) | `53.22% <0.00%> (+1.66%)` | :arrow_up: |
| [...intrelation/EndpointRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2VuZHBvaW50cmVsYXRpb24vRW5kcG9pbnRSZWxhdGlvblNlcnZlclNpZGVNZXRyaWNzLmphdmE=) | `0.00% <ø> (ø)` | |
| [...ance/ServiceInstanceRelationClientSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2luc3RhbmNlL1NlcnZpY2VJbnN0YW5jZVJlbGF0aW9uQ2xpZW50U2lkZU1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ance/ServiceInstanceRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2luc3RhbmNlL1NlcnZpY2VJbnN0YW5jZVJlbGF0aW9uU2VydmVyU2lkZU1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...tion/service/ServiceRelationClientSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL3NlcnZpY2UvU2VydmljZVJlbGF0aW9uQ2xpZW50U2lkZU1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...tion/service/ServiceRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL3NlcnZpY2UvU2VydmljZVJlbGF0aW9uU2VydmVyU2lkZU1ldHJpY3MuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `0.00% <ø> (ø)` | |
| ... and [52 more](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=footer). Last update [4474907...7bfaa8e](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4587:
OAP Core polish, especially storage level
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4587: OAP Core polish, especially storage level
URL: https://github.com/apache/skywalking/pull/4587#discussion_r399909277
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/annotation/Column.java
##########
@@ -55,5 +55,12 @@
/**
* The column is just saved, never used in query.
*/
- boolean content() default false;
+ boolean storageOnly() default false;
Review comment:
No, you can't. There are countless places in the codes, including the OAL generated codes. If you use this, we are facing more changes.
In your case, that will be impossible to review this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4587: [WIP] OAP Core
polish, especially storage level
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4587: [WIP] OAP Core polish, especially storage level
URL: https://github.com/apache/skywalking/pull/4587#issuecomment-605750687
@hanahmily @dmsolr @mrproliu @JaredTan95 @kezhenxu94 This PR is ready to review. Please feedback.
If you have more optimization idea, I am happy to know.
FYI @apache/skywalking-committers , this PR provides more elegance way for SQL storage and ES storage. But for InfluxDB, I have nothing to do. According to @dmsolr, it seems having different logic. Also, I have asked him to summarize those and we could discuss in another thread. InfluxDB is not a very production ready implementation today. I am still expecting the performance test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4587: [WIP] OAP
Core polish, especially storage level
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4587: [WIP] OAP Core polish, especially storage level
URL: https://github.com/apache/skywalking/pull/4587#issuecomment-605550126
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=h1) Report
> Merging [#4587](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4474907fef809e2342b644a324da011834a55420&el=desc) will **increase** coverage by `0.39%`.
> The diff coverage is `44.16%`.
[](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4587 +/- ##
==========================================
+ Coverage 26.43% 26.82% +0.39%
==========================================
Files 1253 1255 +2
Lines 28989 28879 -110
Branches 3952 3946 -6
==========================================
+ Hits 7663 7747 +84
+ Misses 20623 20423 -200
- Partials 703 709 +6
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../apache/skywalking/oap/server/core/CoreModule.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZS5qYXZh) | `4.08% <0.00%> (ø)` | |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../skywalking/oap/server/core/alarm/AlarmRecord.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1SZWNvcmQuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...intrelation/EndpointRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2VuZHBvaW50cmVsYXRpb24vRW5kcG9pbnRSZWxhdGlvblNlcnZlclNpZGVNZXRyaWNzLmphdmE=) | `0.00% <ø> (ø)` | |
| [...ance/ServiceInstanceRelationClientSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2luc3RhbmNlL1NlcnZpY2VJbnN0YW5jZVJlbGF0aW9uQ2xpZW50U2lkZU1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ance/ServiceInstanceRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2luc3RhbmNlL1NlcnZpY2VJbnN0YW5jZVJlbGF0aW9uU2VydmVyU2lkZU1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...tion/service/ServiceRelationClientSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL3NlcnZpY2UvU2VydmljZVJlbGF0aW9uQ2xpZW50U2lkZU1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...tion/service/ServiceRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL3NlcnZpY2UvU2VydmljZVJlbGF0aW9uU2VydmVyU2lkZU1ldHJpY3MuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `0.00% <ø> (ø)` | |
| ... and [39 more](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=footer). Last update [4474907...84b48db](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4587: [WIP] OAP
Core polish, especially storage level
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4587: [WIP] OAP Core polish, especially storage level
URL: https://github.com/apache/skywalking/pull/4587#issuecomment-605550126
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=h1) Report
> Merging [#4587](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4474907fef809e2342b644a324da011834a55420&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `31.11%`.
[](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4587 +/- ##
==========================================
+ Coverage 26.43% 26.46% +0.02%
==========================================
Files 1253 1254 +1
Lines 28989 28990 +1
Branches 3952 3946 -6
==========================================
+ Hits 7663 7671 +8
+ Misses 20623 20614 -9
- Partials 703 705 +2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...intrelation/EndpointRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2VuZHBvaW50cmVsYXRpb24vRW5kcG9pbnRSZWxhdGlvblNlcnZlclNpZGVNZXRyaWNzLmphdmE=) | `0.00% <ø> (ø)` | |
| [...ance/ServiceInstanceRelationClientSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2luc3RhbmNlL1NlcnZpY2VJbnN0YW5jZVJlbGF0aW9uQ2xpZW50U2lkZU1ldHJpY3MuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...ance/ServiceInstanceRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2luc3RhbmNlL1NlcnZpY2VJbnN0YW5jZVJlbGF0aW9uU2VydmVyU2lkZU1ldHJpY3MuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...tion/service/ServiceRelationClientSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL3NlcnZpY2UvU2VydmljZVJlbGF0aW9uQ2xpZW50U2lkZU1ldHJpY3MuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...tion/service/ServiceRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL3NlcnZpY2UvU2VydmljZVJlbGF0aW9uU2VydmVyU2lkZU1ldHJpY3MuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `0.00% <ø> (ø)` | |
| [...oap/server/core/analysis/metrics/ApdexMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9BcGRleE1ldHJpY3MuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...g/oap/server/core/analysis/metrics/CPMMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9DUE1NZXRyaWNzLmphdmE=) | `0.00% <ø> (ø)` | |
| [...server/core/analysis/metrics/DoubleAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Eb3VibGVBdmdNZXRyaWNzLmphdmE=) | `0.00% <ø> (ø)` | |
| ... and [16 more](https://codecov.io/gh/apache/skywalking/pull/4587/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=footer). Last update [4474907...90a3813](https://codecov.io/gh/apache/skywalking/pull/4587?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services