[GitHub] [cassandra] adelapena edited a comment on pull request #1533: CASSANDRA-17499 Remove global Guardrails Enable flag

[GitBox <gi...@apache.org>]

adelapena edited a comment on pull request #1533:
URL: https://github.com/apache/cassandra/pull/1533#issuecomment-1084476388


   @thingtwin1 thanks for pulling those changes. I think it might be more practical to rebase on top of trunk with `git rebase trunk` instead of merging from trunk on top of the patch branch. That way the PR would show the proposed changes on top of trunk's commits, without the additional merge commit.
   
   It seems that the removal of the property breaks the dtests [`GuardrailCollectionSizeOnSSTableWriteTest`](https://github.com/apache/cassandra/blob/935bcf1e8732a4138c15205896945c2f02ddb844/test/distributed/org/apache/cassandra/distributed/test/guardrails/GuardrailCollectionSizeOnSSTableWriteTest.java#L57) and [`GuardrailItemsPerCollectionOnSSTableWriteTest`](https://github.com/apache/cassandra/blob/935bcf1e8732a4138c15205896945c2f02ddb844/test/distributed/org/apache/cassandra/distributed/test/guardrails/GuardrailItemsPerCollectionOnSSTableWriteTest.java#L52). Those tests are still mentioning the removed property.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org