You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by GitBox <gi...@apache.org> on 2021/06/18 21:21:26 UTC
[GitHub] [knox] xuzikun2003 opened a new pull request #459: [KNOX-2622] Support Deflate Encoding for the Inbound Response
xuzikun2003 opened a new pull request #459:
URL: https://github.com/apache/knox/pull/459
## What changes were proposed in this pull request?
Currently, Knox only supports the Content-Encoding "gzip" and the Content-Encoding "deflate" is not supported. When the upstream server (such as Livy 0.7 Server) returns a response which is deflated, Knox does not know how to decode it.
The current code only considers the "gzip" format and the "deflate" format is not considered. We should also handle the case when the format is "deflate" and use InflaterInputStream to read the in-bound response and use DeflaterOutputStream to write the out-bound response.
Here is the JIRA (https://issues.apache.org/jira/browse/KNOX-2622) that describes this issue.
## How was this patch tested?
Existing unit tests and newly added unit tests.
Please review [Knox Contributing Process](https://cwiki.apache.org/confluence/display/KNOX/Contribution+Process#ContributionProcess-GithubWorkflow) before opening a pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] lmccay commented on pull request #459: [KNOX-2622] Support Deflate Encoding for the Inbound Response
Posted by GitBox <gi...@apache.org>.
lmccay commented on pull request #459:
URL: https://github.com/apache/knox/pull/459#issuecomment-865463654
@xuzikun2003 - thank you for your contribution! I will assign the JIRA to you and this will be available in Knox 1.6.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] xuzikun2003 commented on pull request #459: [KNOX-2622] Support Deflate Encoding for the Inbound Response
Posted by GitBox <gi...@apache.org>.
xuzikun2003 commented on pull request #459:
URL: https://github.com/apache/knox/pull/459#issuecomment-864207198
@lmccay , the style issue is already fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] lmccay commented on pull request #459: [KNOX-2622] Support Deflate Encoding for the Inbound Response
Posted by GitBox <gi...@apache.org>.
lmccay commented on pull request #459:
URL: https://github.com/apache/knox/pull/459#issuecomment-865463654
@xuzikun2003 - thank you for your contribution! I will assign the JIRA to you and this will be available in Knox 1.6.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] lmccay merged pull request #459: [KNOX-2622] Support Deflate Encoding for the Inbound Response
Posted by GitBox <gi...@apache.org>.
lmccay merged pull request #459:
URL: https://github.com/apache/knox/pull/459
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] lmccay commented on pull request #459: [KNOX-2622] Support Deflate Encoding for the Inbound Response
Posted by GitBox <gi...@apache.org>.
lmccay commented on pull request #459:
URL: https://github.com/apache/knox/pull/459#issuecomment-864198747
@xuzikun2003 - it seems you have some checkstyle issues that need to be resolved.
Please see https://travis-ci.com/github/apache/knox/jobs/515699869 for the issues towards the bottom of the build output.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] lmccay merged pull request #459: [KNOX-2622] Support Deflate Encoding for the Inbound Response
Posted by GitBox <gi...@apache.org>.
lmccay merged pull request #459:
URL: https://github.com/apache/knox/pull/459
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org