You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@tajo.apache.org by hyunsik <gi...@git.apache.org> on 2014/08/01 08:10:56 UTC

[GitHub] tajo pull request: TAJO-978: RoundFloat8 should return Float8Datum...

Github user hyunsik commented on the pull request:

    https://github.com/apache/tajo/pull/96#issuecomment-50852178
  
    +1
    
    The patch looks good to me. Even tough this patch includes dividing by zero problem, infinity, and NaN issues in real values, you seem to be going to solve it in TAJO-979 (https://issues.apache.org/jira/browse/TAJO-979). Otherwise, please the problems in TAJO-979.
    
    Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---