You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "john-jac (via GitHub)" <gi...@apache.org> on 2023/03/10 18:49:16 UTC

[GitHub] [airflow] john-jac opened a new pull request, #30026: Update workday example

john-jac opened a new pull request, #30026:
URL: https://github.com/apache/airflow/pull/30026

   **Updates to Workday Example in Customizing DAG Scheduling with Timetables**
   
   The existing workday example provided a good demonstration of customizing DAG scheduling with timetables. However the benefits were somewhat limited over using a CRON string.
   
   This PR provides a more robust example for Airflow users by adding a holiday filter to the existing weekend exclusions. The primary benefits of this change are as follows:
   
   1. It provides a solution to a common use case for Airflow users that cannot be approximated with CRON.
   2. It separates out the logic of determining whether to schedule on a given day from the common logic used by Airflow to request what the next scheduled date/time should be.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] john-jac commented on pull request #30026: Update workday example

Posted by "john-jac (via GitHub)" <gi...@apache.org>.
john-jac commented on PR #30026:
URL: https://github.com/apache/airflow/pull/30026#issuecomment-1468992529

   > Looks like there are related tests that need to be fixed
   
   Sorry Jarek...I didn't realize the sample code was being used in tests as well.  I've updated the corresponding test code and all checks have passed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #30026: Update workday example

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #30026:
URL: https://github.com/apache/airflow/pull/30026#issuecomment-1465283307

   Looks like there are related tests that need to be fixed 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #30026: Update workday example

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #30026:
URL: https://github.com/apache/airflow/pull/30026#issuecomment-1470950100

   > Sorry Jarek...I didn't realize the sample code was being used in tests as well. I've updated the corresponding test code and all checks have passed.
   
   No wories. This is normal :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #30026: Update workday example

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #30026:
URL: https://github.com/apache/airflow/pull/30026


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #30026: Update workday example

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #30026:
URL: https://github.com/apache/airflow/pull/30026#issuecomment-1465283312

   Looks like there are related tests that need to be fixed 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ferruzzi commented on pull request #30026: Update workday example

Posted by "ferruzzi (via GitHub)" <gi...@apache.org>.
ferruzzi commented on PR #30026:
URL: https://github.com/apache/airflow/pull/30026#issuecomment-1469250491

   Classic off-by-one error :P 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org