You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Anthony Penniston <ap...@pivotal.io> on 2014/10/24 22:16:47 UTC
Review Request 27158: Dialog overlays do not receive keyboard focus
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27158/
-----------------------------------------------------------
Review request for Ambari.
Bugs: AMBARI-7728
https://issues.apache.org/jira/browse/AMBARI-7728
Repository: ambari
Description
-------
Message boxes do not receive focus. This was observed in at least two places on the Configs screen, where typing on they keyboard still sent characters to the background page rather than the overlayed pop-up.
Diffs
-----
ambari-web/app/assets/test/tests.js cd78e01
ambari-web/app/views/common/modal_popup.js 223a77a
ambari-web/test/views/common/modal_popup_test.js PRE-CREATION
Diff: https://reviews.apache.org/r/27158/diff/
Testing
-------
on config screen, activated modal dialog by clicking 'Add custom property', ensured that first input textbox was focused by default.
Thanks,
Anthony Penniston
Re: Review Request 27158: Dialog overlays do not receive keyboard
focus
Posted by Grace Li <gl...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27158/#review58347
-----------------------------------------------------------
Ship it!
Ship It!
- Grace Li
On Oct. 24, 2014, 8:16 p.m., Anthony Penniston wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27158/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2014, 8:16 p.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-7728
> https://issues.apache.org/jira/browse/AMBARI-7728
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Message boxes do not receive focus. This was observed in at least two places on the Configs screen, where typing on they keyboard still sent characters to the background page rather than the overlayed pop-up.
>
>
> Diffs
> -----
>
> ambari-web/app/assets/test/tests.js cd78e01
> ambari-web/app/views/common/modal_popup.js 223a77a
> ambari-web/test/views/common/modal_popup_test.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27158/diff/
>
>
> Testing
> -------
>
> on config screen, activated modal dialog by clicking 'Add custom property', ensured that first input textbox was focused by default.
>
>
> Thanks,
>
> Anthony Penniston
>
>
Re: Review Request 27158: Dialog overlays do not receive keyboard
focus
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27158/#review58460
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Oct. 24, 2014, 8:16 p.m., Anthony Penniston wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27158/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2014, 8:16 p.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-7728
> https://issues.apache.org/jira/browse/AMBARI-7728
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Message boxes do not receive focus. This was observed in at least two places on the Configs screen, where typing on they keyboard still sent characters to the background page rather than the overlayed pop-up.
>
>
> Diffs
> -----
>
> ambari-web/app/assets/test/tests.js cd78e01
> ambari-web/app/views/common/modal_popup.js 223a77a
> ambari-web/test/views/common/modal_popup_test.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27158/diff/
>
>
> Testing
> -------
>
> on config screen, activated modal dialog by clicking 'Add custom property', ensured that first input textbox was focused by default.
>
>
> Thanks,
>
> Anthony Penniston
>
>