[GitHub] justinleet edited a comment on issue #1342: METRON-2009: Address Javadoc checkstyle issues in metron-common

[GitBox <gi...@apache.org>]

justinleet edited a comment on issue #1342: METRON-2009: Address Javadoc checkstyle issues in metron-common
URL: https://github.com/apache/metron/pull/1342#issuecomment-465157047
 
 
   Sidenote, most of the issues printed in the build, iirc are from error-prone.  That charset PR should help fix a lot of them. I believe most of the other error prone issues are raw types resulting from our use of json-simple.  There's a forked/upgraded version of json-simple that actually has types enforced, but some of the APIs change, so there's a fairly widespread code changes that touches a ton of stuff involved in doing that.
   
   Re: enforcing checkstyle, I'd like to see if we can get individual violations banned on a per ~project~ module basis at CI time.  Completely cleaning out our project of violations is going to be a substantial effort, either on a module by module basis or on a violation basis (or some combination of the two).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services