You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/12/01 21:27:50 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request, #4469: MINOR: Add note about sqllogictest to contributor guide
alamb opened a new pull request, #4469:
URL: https://github.com/apache/arrow-datafusion/pull/4469
# Which issue does this PR close?
re https://github.com/apache/arrow-datafusion/issues/4460
# Rationale for this change
make the harness added in https://github.com/apache/arrow-datafusion/pull/4395 by @mvanschellebeeck easier to find
# What changes are included in this PR?
Add a pointer to these tests in the contributor guide
# Are these changes tested?
N/A
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #4469: MINOR: Add note about sqllogictest to contributor guide
Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #4469:
URL: https://github.com/apache/arrow-datafusion/pull/4469#discussion_r1038178896
##########
docs/source/contributor-guide/index.md:
##########
@@ -134,6 +134,10 @@ cargo test -p datafusion --tests sql_integration
One very important test is the [sql_integration](../../../datafusion/core/tests/sql_integration.rs) test which validates DataFusion's ability to run a large assortment of SQL queries against an assortment of data setups.
+### sqllogictests Tests
+
+The [sqllogictests](../../../datafusion/core/tests/sqllogictests) also validate DataFusion SQL against an assortment of data setups.
Review Comment:
```suggestion
The [sqllogictests](../../../datafusion/core/tests/sqllogictests) also validate DataFusion SQL against an assortment of data setups.
Data Driven tests have many benefits including being easier to write and maintain. We are in the process of [migrating sql_integration tests](https://github.com/apache/arrow-datafusion/issues/4460) and encourage
you to add new tests using sqllogictests if possible.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] xudong963 merged pull request #4469: MINOR: Add note about sqllogictest to contributor guide
Posted by GitBox <gi...@apache.org>.
xudong963 merged PR #4469:
URL: https://github.com/apache/arrow-datafusion/pull/4469
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] xudong963 commented on a diff in pull request #4469: MINOR: Add note about sqllogictest to contributor guide
Posted by GitBox <gi...@apache.org>.
xudong963 commented on code in PR #4469:
URL: https://github.com/apache/arrow-datafusion/pull/4469#discussion_r1037761511
##########
docs/source/contributor-guide/index.md:
##########
@@ -134,6 +134,10 @@ cargo test -p datafusion --tests sql_integration
One very important test is the [sql_integration](../../../datafusion/core/tests/sql_integration.rs) test which validates DataFusion's ability to run a large assortment of SQL queries against an assortment of data setups.
+### sqllogictests Tests
Review Comment:
How about adding some comparison with `Rust Integration Tests` and encouraging adding logictestes as far as possible?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #4469: MINOR: Add note about sqllogictest to contributor guide
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #4469:
URL: https://github.com/apache/arrow-datafusion/pull/4469#issuecomment-1334467816
cc @xudong963
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #4469: MINOR: Add note about sqllogictest to contributor guide
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #4469:
URL: https://github.com/apache/arrow-datafusion/pull/4469#issuecomment-1335391259
Benchmark runs are scheduled for baseline = b229e0ff8ac3783adec0e2b4020e95971b147be4 and contender = 5d69fa33b84e9d7b54477ec0f464cbac69825157. 5d69fa33b84e9d7b54477ec0f464cbac69825157 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/cf399cf0c54c4f27a9c0ea7c7367c29d...695b0f1126894189b75dfa42262046b7/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/12c2d7cb19b44feea9911f1a237a173a...800860919348438bbcaaeb34b3f1dc1d/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/e982dc81da1e4d21a67334772b35ac29...16bbc67d0a3c45de8c7b73658f60e81d/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/5f17750830e84315886784aaba9f0ca5...b9d3d07855864e098a11149ee0d2b5ee/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org