You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "dsmiley (via GitHub)" <gi...@apache.org> on 2025/10/19 03:47:30 UTC
[PR] SOLR-17884: Don't depend on Apache HttpClient [solr]
dsmiley opened a new pull request, #3792:
URL: https://github.com/apache/solr/pull/3792
Discovered more changes needed...
* solrj-streaming DatabaseMetaDataImpl
* ZkController
* ConcurrentUpdateHttp2SolrClient (jetty)
https://issues.apache.org/jira/browse/SOLR-17884
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17884: Don't depend on Apache HttpClient [solr]
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley merged PR #3792:
URL: https://github.com/apache/solr/pull/3792
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17884: Don't depend on Apache HttpClient [solr]
Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy commented on PR #3792:
URL: https://github.com/apache/solr/pull/3792#issuecomment-3425100640
Wooot 🎉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17884: Don't depend on Apache HttpClient [solr]
Posted by "iamsanjay (via GitHub)" <gi...@apache.org>.
iamsanjay commented on code in PR #3792:
URL: https://github.com/apache/solr/pull/3792#discussion_r2443230915
##########
solr/core/src/java/org/apache/solr/cloud/ZkController.java:
##########
@@ -2306,12 +2306,12 @@ private ZkCoreNodeProps waitForLeaderToSeeDownState(
}
// short timeouts, we may be in a storm and this is just best effort, and maybe we should be
- // the
- // leader now
+ // the leader now
+ // TODO .withHttpClient(getCoreContainer().getDefaultHttpSolrClient())
try (SolrClient client =
- new Builder(leaderBaseUrl)
+ new Http2SolrClient.Builder(leaderBaseUrl)
.withConnectionTimeout(8000, TimeUnit.MILLISECONDS)
- .withSocketTimeout(30000, TimeUnit.MILLISECONDS)
+ .withIdleTimeout(30000, TimeUnit.MILLISECONDS)
.build()) {
Review Comment:
What about the security listeners?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17884: Don't depend on Apache HttpClient [solr]
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley commented on PR #3792:
URL: https://github.com/apache/solr/pull/3792#issuecomment-3422048937
Planning to merge tonight (12 hours; 9:22 EST). Happy to pause for any reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17884: Don't depend on Apache HttpClient [solr]
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley commented on code in PR #3792:
URL: https://github.com/apache/solr/pull/3792#discussion_r2442756478
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/ConcurrentUpdateHttp2SolrClient.java:
##########
@@ -32,7 +32,6 @@
import org.apache.solr.client.solrj.SolrClient;
import org.apache.solr.client.solrj.SolrRequest;
import org.apache.solr.client.solrj.SolrServerException;
-import org.apache.solr.client.solrj.impl.ConcurrentUpdateSolrClient.Update;
Review Comment:
Don't want to use that internal POJO, so I created a similar record, copying the same javadoc line as well.
##########
solr/core/src/java/org/apache/solr/cloud/ZkController.java:
##########
@@ -2306,12 +2306,12 @@ private ZkCoreNodeProps waitForLeaderToSeeDownState(
}
// short timeouts, we may be in a storm and this is just best effort, and maybe we should be
- // the
- // leader now
+ // the leader now
+ // TODO .withHttpClient(getCoreContainer().getDefaultHttpSolrClient())
Review Comment:
Preferable; however that means accepting its connection timeout. Heck; wouldn't need to create a new Http2SolrClient either; just use the default client. Personally I'd prefer that but... :shrug:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17884: Don't depend on Apache HttpClient [solr]
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley commented on code in PR #3792:
URL: https://github.com/apache/solr/pull/3792#discussion_r2443329807
##########
solr/core/src/java/org/apache/solr/cloud/ZkController.java:
##########
@@ -2306,12 +2306,12 @@ private ZkCoreNodeProps waitForLeaderToSeeDownState(
}
// short timeouts, we may be in a storm and this is just best effort, and maybe we should be
- // the
- // leader now
+ // the leader now
+ // TODO .withHttpClient(getCoreContainer().getDefaultHttpSolrClient())
try (SolrClient client =
- new Builder(leaderBaseUrl)
+ new Http2SolrClient.Builder(leaderBaseUrl)
.withConnectionTimeout(8000, TimeUnit.MILLISECONDS)
- .withSocketTimeout(30000, TimeUnit.MILLISECONDS)
+ .withIdleTimeout(30000, TimeUnit.MILLISECONDS)
.build()) {
Review Comment:
I changed it now. It's a trade-off but at least the listener issue could be a real bug
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org