You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/12/12 06:39:27 UTC

[GitHub] [calcite] docete opened a new pull request #1650: [CALCITE-3597] The conversion between java.sql.Timestamp and long is …

docete opened a new pull request #1650: [CALCITE-3597] The conversion between java.sql.Timestamp and long is …
URL: https://github.com/apache/calcite/pull/1650
 
 
   …not asymmetric
   
   In Calcite, we use SqlFunctions.toLong(Timestamp) and SqlFunctions.internalToTimestamp(long) to convert java.sql.Timestmap to internal long and vice versa. The main logical inside is +/- local time zone offset.But in the comments of TimeZone.getOffset(long date), the parameter represents in milliseconds since January 1, 1970 00:00:00 GMT. It means that there will one conversion above doesn't satisfy this hypothesis. This PR use LocalDateTime as intermediate of the conversion and solves the dissymmetry.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services