You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Richard Ding (JIRA)" <ji...@apache.org> on 2010/06/16 21:31:23 UTC
[jira] Created: (PIG-1454) Consider clean up backend code
Consider clean up backend code
------------------------------
Key: PIG-1454
URL: https://issues.apache.org/jira/browse/PIG-1454
Project: Pig
Issue Type: Improvement
Components: impl
Affects Versions: 0.7.0
Reporter: Richard Ding
Assignee: Richard Ding
Fix For: 0.8.0
Prior to 0.7, Pig had its own local execution mode, in addition to hadoop map reduce execution mode. To support these two different execution modes, Pig implemented an abstraction layer with a set of interfaces and abstract classes. Pig 0.7 replaced the local mode with hadoop local mode and made this abstraction layer redundant.
Our goal is to remove those extra code. But we need also keep code backward compatible since some interfaces are exposed by top-level API.
So we propose the first steps:
* Deprecate methods on FileLocalizer that have DataStorage as parameter.
* Remove ExecPhysicalOperator, ExecPhysicalPlan, ExecScopedLogicalOperator, ExecutionEngine and util/ExecTools from org.apache.pig.backend.executionengine package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1454) Consider clean up backend code
Posted by "Richard Ding (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Richard Ding updated PIG-1454:
------------------------------
Attachment: PIG-1454.patch
> Consider clean up backend code
> ------------------------------
>
> Key: PIG-1454
> URL: https://issues.apache.org/jira/browse/PIG-1454
> Project: Pig
> Issue Type: Improvement
> Components: impl
> Affects Versions: 0.7.0
> Reporter: Richard Ding
> Assignee: Richard Ding
> Fix For: 0.8.0
>
> Attachments: PIG-1454.patch
>
>
> Prior to 0.7, Pig had its own local execution mode, in addition to hadoop map reduce execution mode. To support these two different execution modes, Pig implemented an abstraction layer with a set of interfaces and abstract classes. Pig 0.7 replaced the local mode with hadoop local mode and made this abstraction layer redundant.
> Our goal is to remove those extra code. But we need also keep code backward compatible since some interfaces are exposed by top-level API.
> So we propose the first steps:
> * Deprecate methods on FileLocalizer that have DataStorage as parameter.
> * Remove ExecPhysicalOperator, ExecPhysicalPlan, ExecScopedLogicalOperator, ExecutionEngine and util/ExecTools from org.apache.pig.backend.executionengine package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1454) Consider clean up backend code
Posted by "Richard Ding (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12882640#action_12882640 ]
Richard Ding commented on PIG-1454:
-----------------------------------
I've run the core tests manually and they passed.
> Consider clean up backend code
> ------------------------------
>
> Key: PIG-1454
> URL: https://issues.apache.org/jira/browse/PIG-1454
> Project: Pig
> Issue Type: Improvement
> Components: impl
> Affects Versions: 0.7.0
> Reporter: Richard Ding
> Assignee: Richard Ding
> Fix For: 0.8.0
>
> Attachments: PIG-1454.patch
>
>
> Prior to 0.7, Pig had its own local execution mode, in addition to hadoop map reduce execution mode. To support these two different execution modes, Pig implemented an abstraction layer with a set of interfaces and abstract classes. Pig 0.7 replaced the local mode with hadoop local mode and made this abstraction layer redundant.
> Our goal is to remove those extra code. But we need also keep code backward compatible since some interfaces are exposed by top-level API.
> So we propose the first steps:
> * Deprecate methods on FileLocalizer that have DataStorage as parameter.
> * Remove ExecPhysicalOperator, ExecPhysicalPlan, ExecScopedLogicalOperator, ExecutionEngine and util/ExecTools from org.apache.pig.backend.executionengine package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1454) Consider clean up backend code
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12882655#action_12882655 ]
Olga Natkovich commented on PIG-1454:
-------------------------------------
+1
> Consider clean up backend code
> ------------------------------
>
> Key: PIG-1454
> URL: https://issues.apache.org/jira/browse/PIG-1454
> Project: Pig
> Issue Type: Improvement
> Components: impl
> Affects Versions: 0.7.0
> Reporter: Richard Ding
> Assignee: Richard Ding
> Fix For: 0.8.0
>
> Attachments: PIG-1454.patch
>
>
> Prior to 0.7, Pig had its own local execution mode, in addition to hadoop map reduce execution mode. To support these two different execution modes, Pig implemented an abstraction layer with a set of interfaces and abstract classes. Pig 0.7 replaced the local mode with hadoop local mode and made this abstraction layer redundant.
> Our goal is to remove those extra code. But we need also keep code backward compatible since some interfaces are exposed by top-level API.
> So we propose the first steps:
> * Deprecate methods on FileLocalizer that have DataStorage as parameter.
> * Remove ExecPhysicalOperator, ExecPhysicalPlan, ExecScopedLogicalOperator, ExecutionEngine and util/ExecTools from org.apache.pig.backend.executionengine package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1454) Consider clean up backend code
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12882031#action_12882031 ]
Hadoop QA commented on PIG-1454:
--------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12447897/PIG-1454.patch
against trunk revision 957277.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 27 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
-1 release audit. The applied patch generated 394 release audit warnings (more than the trunk's current 389 warnings).
-1 core tests. The patch failed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/333/testReport/
Release audit warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/333/artifact/trunk/patchprocess/releaseAuditDiffWarnings.txt
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/333/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/333/console
This message is automatically generated.
> Consider clean up backend code
> ------------------------------
>
> Key: PIG-1454
> URL: https://issues.apache.org/jira/browse/PIG-1454
> Project: Pig
> Issue Type: Improvement
> Components: impl
> Affects Versions: 0.7.0
> Reporter: Richard Ding
> Assignee: Richard Ding
> Fix For: 0.8.0
>
> Attachments: PIG-1454.patch
>
>
> Prior to 0.7, Pig had its own local execution mode, in addition to hadoop map reduce execution mode. To support these two different execution modes, Pig implemented an abstraction layer with a set of interfaces and abstract classes. Pig 0.7 replaced the local mode with hadoop local mode and made this abstraction layer redundant.
> Our goal is to remove those extra code. But we need also keep code backward compatible since some interfaces are exposed by top-level API.
> So we propose the first steps:
> * Deprecate methods on FileLocalizer that have DataStorage as parameter.
> * Remove ExecPhysicalOperator, ExecPhysicalPlan, ExecScopedLogicalOperator, ExecutionEngine and util/ExecTools from org.apache.pig.backend.executionengine package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1454) Consider clean up backend code
Posted by "Richard Ding (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Richard Ding updated PIG-1454:
------------------------------
Status: Patch Available (was: Open)
> Consider clean up backend code
> ------------------------------
>
> Key: PIG-1454
> URL: https://issues.apache.org/jira/browse/PIG-1454
> Project: Pig
> Issue Type: Improvement
> Components: impl
> Affects Versions: 0.7.0
> Reporter: Richard Ding
> Assignee: Richard Ding
> Fix For: 0.8.0
>
> Attachments: PIG-1454.patch
>
>
> Prior to 0.7, Pig had its own local execution mode, in addition to hadoop map reduce execution mode. To support these two different execution modes, Pig implemented an abstraction layer with a set of interfaces and abstract classes. Pig 0.7 replaced the local mode with hadoop local mode and made this abstraction layer redundant.
> Our goal is to remove those extra code. But we need also keep code backward compatible since some interfaces are exposed by top-level API.
> So we propose the first steps:
> * Deprecate methods on FileLocalizer that have DataStorage as parameter.
> * Remove ExecPhysicalOperator, ExecPhysicalPlan, ExecScopedLogicalOperator, ExecutionEngine and util/ExecTools from org.apache.pig.backend.executionengine package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1454) Consider clean up backend code
Posted by "Richard Ding (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Richard Ding updated PIG-1454:
------------------------------
Status: Resolved (was: Patch Available)
Hadoop Flags: [Reviewed]
Resolution: Fixed
> Consider clean up backend code
> ------------------------------
>
> Key: PIG-1454
> URL: https://issues.apache.org/jira/browse/PIG-1454
> Project: Pig
> Issue Type: Improvement
> Components: impl
> Affects Versions: 0.7.0
> Reporter: Richard Ding
> Assignee: Richard Ding
> Fix For: 0.8.0
>
> Attachments: PIG-1454.patch
>
>
> Prior to 0.7, Pig had its own local execution mode, in addition to hadoop map reduce execution mode. To support these two different execution modes, Pig implemented an abstraction layer with a set of interfaces and abstract classes. Pig 0.7 replaced the local mode with hadoop local mode and made this abstraction layer redundant.
> Our goal is to remove those extra code. But we need also keep code backward compatible since some interfaces are exposed by top-level API.
> So we propose the first steps:
> * Deprecate methods on FileLocalizer that have DataStorage as parameter.
> * Remove ExecPhysicalOperator, ExecPhysicalPlan, ExecScopedLogicalOperator, ExecutionEngine and util/ExecTools from org.apache.pig.backend.executionengine package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.