[GitHub] [druid] clintropolis commented on a change in pull request #11109: Issue #10953: ARM64 - Build and test on AWS Graviton2 node

[GitBox <gi...@apache.org>]

clintropolis commented on a change in pull request #11109:
URL: https://github.com/apache/druid/pull/11109#discussion_r614584818



##########
File path: processing/src/test/java/org/apache/druid/segment/virtual/ExpressionVectorSelectorsTest.java
##########
@@ -96,25 +96,31 @@
   private static QueryableIndex INDEX;
   private static Closer CLOSER;
 
+  private static final String CPU_ARCH = System.getProperty("os.arch");
+
   @BeforeClass
   public static void setupClass()
   {
     CLOSER = Closer.create();
 
-    final GeneratorSchemaInfo schemaInfo = GeneratorBasicSchemas.SCHEMA_MAP.get("expression-testbench");
+    // Do not run the tests on ARM64.
+    // SegmentGenerator#generate() fails with OutOfMemoryError on TravisCI ARM64

Review comment:
       maybe it would be trying with a smaller segment size (`ROWS_PER_SEGMENT`) instead of skipping the test entirely?

##########
File path: .travis.yml
##########
@@ -303,6 +303,17 @@ jobs:
       after_success:
         - (cd web-console && travis_retry npm run codecov)  # retry in case of network error
 
+    - name: "Build and test on ARM64 CPU architecture"
+      stage: Tests - phase 2
+      arch: arm64-graviton2
+      dist: focal
+      virt: vm
+      group: edge
+      jdk: openjdk11
+      env:
+        - MAVEN_PROJECTS='core,indexing-hadoop,indexing-service,processing,server,services'

Review comment:
       should probably consider adding `sql` to this set too so we at least have coverage of most core Druid things.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org