You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/09/12 00:49:08 UTC

[GitHub] [incubator-mxnet] samskalicky commented on a change in pull request #16131: Fix for duplicate subgraph inputs/outputs

samskalicky commented on a change in pull request #16131: Fix for duplicate subgraph inputs/outputs
URL: https://github.com/apache/incubator-mxnet/pull/16131#discussion_r323517546
 
 

 ##########
 File path: src/operator/subgraph/subgraph_property.h
 ##########
 @@ -296,8 +296,20 @@ class SubgraphProperty {
    */
   virtual void ConnectSubgraphOutputs(const nnvm::NodePtr subgraph_node,
                                       std::vector<nnvm::NodeEntry*>* output_entries) const {
+    // Collapse output_entries pointing to same NodeEntry
 
 Review comment:
   Any suggestion on how to do this without creating a map or changing the interface/API of createSubgraphOutputs? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services