You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Anindya Sinha <an...@gmail.com> on 2015/05/13 01:24:04 UTC

Review Request 34129: Add 2 optional args public_ip and public_port for libprocess to advertise.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34129/
-----------------------------------------------------------

Review request for mesos.


Bugs: MESOS-809
    https://issues.apache.org/jira/browse/MESOS-809


Repository: mesos


Description
-------

If set, these IP/Port shall be advertised by libprocess (although bind is
not done on this IP/Port). If not set, libprocess advertises the IP/Port
on which bind was done.

Command line arguments added:
public_ip: Public IP address to reach mesos. Defaults to the command line argument `ip`.
public_port: Public port to reach mesos. Defaults to the command line argument `port`.


Diffs
-----

  docs/configuration.md 54c4e31ed6dfed3c23d492c19a301ce119a0519b 
  src/master/main.cpp 18f8c3178459da0cbf23a1817ec49cd9d3998bfd 

Diff: https://reviews.apache.org/r/34129/diff/


Testing
-------

Testing:
  make test


Thanks,

Anindya Sinha