[GitHub] [beam] scwhittle commented on a change in pull request #15416: [BEAM-12818] Write windowed file output directly to temporary directory and with hash prefix

[GitBox <gi...@apache.org>]

scwhittle commented on a change in pull request #15416:
URL: https://github.com/apache/beam/pull/15416#discussion_r719138472



##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileBasedSink.java
##########
@@ -522,16 +526,17 @@ protected static ResourceId buildTemporaryFilename(ResourceId tempDirectory, Str
      * Constructs a WriteOperation using the default strategy for generating a temporary directory
      * from the base output filename.
      *
-     * <p>Default is a uniquely named subdirectory of the provided tempDirectory, e.g. if
-     * tempDirectory is /path/to/foo/, the temporary directory will be
+     * <p>Without windowing, the default is a uniquely named subdirectory of the provided
+     * tempDirectory, e.g. if tempDirectory is /path/to/foo/, the temporary directory will be
      * /path/to/foo/.temp-beam-$uuid.
      *
+     * <p>With windowing, the default is to use tempDirectory directly.

Review comment:
       Done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org