You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "Z-Beatles (via GitHub)" <gi...@apache.org> on 2023/10/19 10:05:32 UTC

[PR] Support collect ZGC memory pool metrics [skywalking]

Z-Beatles opened a new pull request, #11432:
URL: https://github.com/apache/skywalking/pull/11432

   <!--
       ⚠️ Please make sure to read this template first, pull requests that don't accord with this template
       maybe closed without notice.
       Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
       Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
   -->
   
   <!-- ==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👇 ====
   ### Fix <bug description or the bug issue number or bug issue link>
   - [ ] Add a unit test to verify that the fix works.
   - [ ] Explain briefly why the bug exists and how to fix it.
        ==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👆 ==== -->
   
   <!-- ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👇 ====
   ### Improve the performance of <class or module or ...>
   - [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking/blob/master/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
   - [ ] The benchmark result.
   ```text
   <Paste the benchmark results here>
   ```
   - [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
        ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👆 ==== -->
   
   <!-- ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👇 ====
   ### <Feature description>
   - [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
   - [ ] Update the documentation to include this new feature.
   - [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
   - [ ] If it's UI related, attach the screenshots below.
        ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👆 ==== -->
   
   - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>.
   - [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md).
   
   for UI setting change, see [skywalking-java #622](https://github.com/apache/skywalking-java/pull/622)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Support collect ZGC memory pool metrics [skywalking]

Posted by "Z-Beatles (via GitHub)" <gi...@apache.org>.
Z-Beatles commented on PR #11432:
URL: https://github.com/apache/skywalking/pull/11432#issuecomment-1770507682

   ![image](https://github.com/apache/skywalking/assets/20594866/49911d38-ab37-41d9-aeb9-3176994815a2)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Support collect ZGC memory pool metrics [skywalking]

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #11432:
URL: https://github.com/apache/skywalking/pull/11432#issuecomment-1771910865

   Please make the submodule correctly, pointing to the master branch commit ID.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Support collect ZGC memory pool metrics [skywalking]

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #11432:
URL: https://github.com/apache/skywalking/pull/11432#discussion_r1365299551


##########
oap-server/server-starter/src/main/resources/oal/java-agent.oal:
##########
@@ -22,6 +22,17 @@ instance_jvm_memory_heap = from(ServiceInstanceJVMMemory.used).filter(heapStatus
 instance_jvm_memory_noheap = from(ServiceInstanceJVMMemory.used).filter(heapStatus == false).longAvg();
 instance_jvm_memory_heap_max = from(ServiceInstanceJVMMemory.max).filter(heapStatus == true).longAvg();
 instance_jvm_memory_noheap_max = from(ServiceInstanceJVMMemory.max).filter(heapStatus == false).longAvg();
+instance_jvm_memory_pool_code_cache = from(ServiceInstanceJVMMemoryPool.used).filter(poolType == MemoryPoolType.CODE_CACHE_USAGE).longAvg();
+instance_jvm_memory_pool_newgen = from(ServiceInstanceJVMMemoryPool.used).filter(poolType == MemoryPoolType.NEWGEN_USAGE).longAvg();
+instance_jvm_memory_pool_oldgen = from(ServiceInstanceJVMMemoryPool.used).filter(poolType == MemoryPoolType.OLDGEN_USAGE).longAvg();
+instance_jvm_memory_pool_survivor = from(ServiceInstanceJVMMemoryPool.used).filter(poolType == MemoryPoolType.SURVIVOR_USAGE).longAvg();
+instance_jvm_memory_pool_permgen = from(ServiceInstanceJVMMemoryPool.used).filter(poolType == MemoryPoolType.PERMGEN_USAGE).longAvg();

Review Comment:
   Why these? All thses are not new metrics.
   
   I am not following.



##########
oap-server/server-starter/src/main/resources/ui-initialized-templates/general/general-instance.json:
##########
@@ -326,7 +326,88 @@
                   ]
                 },
                 {
-                  "x": 8,
+                  "x": 16,
+                  "y": 0,
+                  "w": 8,
+                  "h": 13,
+                  "i": "5",
+                  "type": "Widget",
+                  "widget": {
+                    "title": "JVM Memory Detail (MB)"

Review Comment:
   Are you adding a new widget?
   This name doesn't seem diff from other GC model.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Support collect ZGC memory pool metrics [skywalking]

Posted by "Z-Beatles (via GitHub)" <gi...@apache.org>.
Z-Beatles commented on PR #11432:
URL: https://github.com/apache/skywalking/pull/11432#issuecomment-1772088474

   > Still missing one.
   > 
   > <img alt="image" width="1262" src="https://user-images.githubusercontent.com/5441976/276816603-bfeae130-24d9-4fac-a5e0-8e948e822e96.png">
   > Please check from git history https://github.com/apache/skywalking-booster-ui/commits/main
   Which one missing? There are no changes in the [skywalking-booster-ui](https://github.com/apache/skywalking-booster-ui).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Support collect ZGC memory pool metrics [skywalking]

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #11432:
URL: https://github.com/apache/skywalking/pull/11432


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Support collect ZGC memory pool metrics [skywalking]

Posted by "Z-Beatles (via GitHub)" <gi...@apache.org>.
Z-Beatles commented on PR #11432:
URL: https://github.com/apache/skywalking/pull/11432#issuecomment-1770699247

   ### changes:
   1. Add a new widget `JVM Memory Detail (MB)` to show memory pool detail.
   2. Support collect and show ZGC memory pool metrics.
   
   ### before:
   ![image](https://github.com/apache/skywalking/assets/20594866/aabd7d26-d0bb-4962-830d-9d921531ace8)
   
   ### after:
    Case1: app start up use default G1 gc. `-XX:+UseG1GC`
   ![image](https://github.com/apache/skywalking/assets/20594866/6b7b2af5-af0b-4e71-8565-dc0148735118)
   
   Case2: app start up use ZGC. `-XX:+UseZGC`
   ![image](https://github.com/apache/skywalking/assets/20594866/876f1861-3c36-4305-99e6-50be4d2e87a4)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Support collect ZGC memory pool metrics [skywalking]

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #11432:
URL: https://github.com/apache/skywalking/pull/11432#issuecomment-1772041590

   Still missing one. 
   
   <img width="1262" alt="image" src="https://github.com/apache/skywalking/assets/5441976/bfeae130-24d9-4fac-a5e0-8e948e822e96">
   
   Please check from git history https://github.com/apache/skywalking-booster-ui/commits/main


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Support collect ZGC memory pool metrics [skywalking]

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #11432:
URL: https://github.com/apache/skywalking/pull/11432#issuecomment-1772093729

   The one I was showing above. It wasn't synced, but you are syncing sub module now, so, you need to add this to change log as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Support collect ZGC memory pool metrics [skywalking]

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #11432:
URL: https://github.com/apache/skywalking/pull/11432#issuecomment-1771910923

   Please make the submodule correctly, pointing to the master branch commit ID.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Support collect ZGC memory pool metrics [skywalking]

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #11432:
URL: https://github.com/apache/skywalking/pull/11432#issuecomment-1772034152

   As you have updated UI, I think there is UI side commit gap too. Please update the UI part change logs accordingly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org