You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by el...@apache.org on 2026/07/01 12:04:51 UTC

(maven-shared-utils) 02/02: PrettyPrintXMLWriter: handle null lineIndent/lineSeparator in constructors

This is an automated email from the ASF dual-hosted git repository.

elharo pushed a commit to branch fix/prettyprint-npe-null-lineindent
in repository https://gitbox.apache.org/repos/asf/maven-shared-utils.git

commit b38df77f1e57ad66b017c6ba914b4f63c0558323
Author: Elliotte Rusty Harold <el...@ibiblio.org>
AuthorDate: Wed Jul 1 08:04:39 2026 -0400

    PrettyPrintXMLWriter: handle null lineIndent/lineSeparator in constructors
---
 .../maven/shared/utils/xml/PrettyPrintXMLWriter.java       | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/src/main/java/org/apache/maven/shared/utils/xml/PrettyPrintXMLWriter.java b/src/main/java/org/apache/maven/shared/utils/xml/PrettyPrintXMLWriter.java
index f611d2f..523a106 100644
--- a/src/main/java/org/apache/maven/shared/utils/xml/PrettyPrintXMLWriter.java
+++ b/src/main/java/org/apache/maven/shared/utils/xml/PrettyPrintXMLWriter.java
@@ -95,7 +95,12 @@ public class PrettyPrintXMLWriter implements XMLWriter {
      * @param doctype can be null
      */
     public PrettyPrintXMLWriter(PrintWriter writer, String lineIndent, String encoding, String doctype) {
-        this(writer, lineIndent.toCharArray(), "\n".toCharArray(), encoding, doctype);
+        this(
+                writer,
+                lineIndent != null ? lineIndent.toCharArray() : DEFAULT_LINE_INDENT,
+                "\n".toCharArray(),
+                encoding,
+                doctype);
     }
 
     /**
@@ -135,7 +140,12 @@ public class PrettyPrintXMLWriter implements XMLWriter {
      */
     public PrettyPrintXMLWriter(
             PrintWriter writer, String lineIndent, String lineSeparator, String encoding, String doctype) {
-        this(writer, lineIndent.toCharArray(), lineSeparator.toCharArray(), encoding, doctype);
+        this(
+                writer,
+                lineIndent != null ? lineIndent.toCharArray() : DEFAULT_LINE_INDENT,
+                lineSeparator != null ? lineSeparator.toCharArray() : "\n".toCharArray(),
+                encoding,
+                doctype);
     }
 
     /**